From: "Zhang, Helin" <helin.zhang@intel.com>
To: "xuelin.shi@freescale.com" <xuelin.shi@freescale.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix ixgbe PCI access endian issue
Date: Wed, 25 Mar 2015 06:33:20 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A830B56@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1423703990-29031-1-git-send-email-xuelin.shi@freescale.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> xuelin.shi@freescale.com
> Sent: Thursday, February 12, 2015 9:20 AM
> To: thomas.monjalon@6wind.com
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ixgbe: fix ixgbe PCI access endian issue
>
> From: Xuelin Shi <xuelin.shi@freescale.com>
>
> ixgbe is little endian, but cpu maybe not.
> add necessary conversions.
> rte_cpu_to_le_32(...) for PCI write
> rte_le_to_cpu_32(...) for PCI read.
>
> Signed-off-by: Xuelin Shi <xuelin.shi@freescale.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
> ---
> lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
> b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
> index 2d40bfd..f8bfb3f 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
> +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
> @@ -119,11 +119,11 @@ typedef int bool;
>
> static inline uint32_t ixgbe_read_addr(volatile void* addr) {
> - return IXGBE_PCI_REG(addr);
> + return rte_le_to_cpu_32(IXGBE_PCI_REG(addr));
> }
>
> #define IXGBE_PCI_REG_WRITE(reg, value) do { \
> - IXGBE_PCI_REG((reg)) = (value); \
> + IXGBE_PCI_REG((reg)) = (rte_cpu_to_le_32(value)); \
> } while(0)
>
> #define IXGBE_PCI_REG_ADDR(hw, reg) \
> --
> 1.9.1
prev parent reply other threads:[~2015-03-25 6:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 1:19 xuelin.shi
2015-02-20 10:53 ` Thomas Monjalon
2015-03-25 6:33 ` Zhang, Helin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A830B56@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=xuelin.shi@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).