From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Pei, Yulong" <yulong.pei@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] i40e: Enlarge the number of supported queues
Date: Mon, 19 Oct 2015 08:37:02 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A918F54@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F8D035B4@SHSMSX104.ccr.corp.intel.com>
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Monday, October 19, 2015 4:30 PM
> To: Zhang, Helin; dev@dpdk.org
> Cc: Pei, Yulong; Liu, Yong
> Subject: RE: [PATCH 2/2] i40e: Enlarge the number of supported queues
>
> Hi, helin
>
> Few comments
>
> > a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> > index
> > 4b70588..3bdcaa4 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -2240,113 +2240,88 @@ i40e_pf_parameter_init(struct rte_eth_dev
> > *dev) {
> > struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data-
> > >dev_private);
> > struct i40e_hw *hw = I40E_PF_TO_HW(pf);
> > - uint16_t sum_queues = 0, sum_vsis, left_queues;
> > + uint16_t qp_count = 0, vsi_count = 0;
> >
> > - /* First check if FW support SRIOV */
> > if (dev->pci_dev->max_vfs && !hw->func_caps.sr_iov_1_1) {
> > PMD_INIT_LOG(ERR, "HW configuration doesn't support SRIOV");
> > return -EINVAL;
> > }
> >
> > pf->flags = I40E_FLAG_HEADER_SPLIT_DISABLED;
> > - pf->max_num_vsi = RTE_MIN(hw->func_caps.num_vsis,
> > I40E_MAX_NUM_VSIS);
> > - PMD_INIT_LOG(INFO, "Max supported VSIs:%u", pf->max_num_vsi);
> > - /* Allocate queues for pf */
> > - if (hw->func_caps.rss) {
> > - pf->flags |= I40E_FLAG_RSS;
> > - pf->lan_nb_qps = RTE_MIN(hw->func_caps.num_tx_qp,
> > - (uint32_t)(1 << hw-
> > >func_caps.rss_table_entry_width));
> > - pf->lan_nb_qps = i40e_align_floor(pf->lan_nb_qps);
> > - } else
> > + pf->max_num_vsi = hw->func_caps.num_vsis;
> > + pf->lan_nb_qp_max = RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF;
> > + pf->vmdq_nb_qp_max = RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM;
> > + pf->vf_nb_qp_max = RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF;
> > +
> Need use the NUM_PER_VF but not NUM_PER_PF
> pf->vf_nb_qp_max = RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF； ==>
> pf->pf->vf_nb_qp_max = RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF;
Yes, you are right. Thank you very much!
I will correct it in the next version.
Helin
>
next prev parent reply other threads:[~2015-10-19 8:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-20 14:51 [dpdk-dev] [PATCH 0/2] i40e: enlarge " Helin Zhang
2015-09-20 14:51 ` [dpdk-dev] [PATCH 1/2] i40e: adjust the number of queues for RSS Helin Zhang
2015-09-20 14:51 ` [dpdk-dev] [PATCH 2/2] i40e: Enlarge the number of supported queues Helin Zhang
2015-09-21 7:41 ` David Marchand
2015-09-21 8:15 ` Zhang, Helin
2015-09-22 6:36 ` Zhang, Helin
2015-10-19 8:29 ` Wu, Jingjing
2015-10-19 8:37 ` Zhang, Helin [this message]
2015-10-22 7:28 ` [dpdk-dev] [PATCH v2 0/2] " Helin Zhang
2015-10-22 7:28 ` [dpdk-dev] [PATCH v2 1/2] i40e: adjust the number of queues for RSS Helin Zhang
2015-10-22 7:28 ` [dpdk-dev] [PATCH v2 2/2] i40e: Enlarge the number of supported queues Helin Zhang
2015-11-03 1:16 ` Thomas Monjalon
2015-11-03 2:49 ` Zhang, Helin
2015-10-22 15:36 ` [dpdk-dev] [PATCH v2 0/2] " Wu, Jingjing
2015-11-03 15:40 ` [dpdk-dev] [PATCH v3 " Helin Zhang
2015-11-03 15:40 ` [dpdk-dev] [PATCH v3 1/2] i40e: adjust the number of queues for RSS Helin Zhang
2015-11-03 15:40 ` [dpdk-dev] [PATCH v3 2/2] i40e: Enlarge the number of supported queues Helin Zhang
2015-11-03 21:59 ` [dpdk-dev] [PATCH v3 0/2] " Thomas Monjalon
2015-11-04 14:54 ` Traynor, Kevin
2015-11-05 0:39 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A918F54@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=yulong.pei@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).