From: "Zhang, Helin" <helin.zhang@intel.com>
To: Vlad Zolotarov <vladz@cloudius-systems.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] ixgbe: Drop flow control frames from VFs
Date: Mon, 26 Oct 2015 00:47:21 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A91D225@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <5629F71D.4090402@cloudius-systems.com>
> -----Original Message-----
> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com]
> Sent: Friday, October 23, 2015 5:00 PM
> To: Zhang, Helin
> Cc: Lu, Wenzhuo; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] ixgbe: Drop flow control frames from VFs
>
>
>
> On 10/23/15 11:32, Zhang, Helin wrote:
> >
> >> -----Original Message-----
> >> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com]
> >> Sent: Friday, October 23, 2015 4:27 PM
> >> To: Zhang, Helin
> >> Cc: Lu, Wenzhuo; dev@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH v4] ixgbe: Drop flow control frames
> >> from VFs
> >>
> >>
> >>
> >> On 10/23/15 10:14, Zhang, Helin wrote:
> >>> From: Vladislav Zolotarov [mailto:vladz@cloudius-systems.com]
> >>> Sent: Friday, October 23, 2015 2:57 PM
> >>> To: Zhang, Helin
> >>> Cc: Lu, Wenzhuo; dev@dpdk.org
> >>> Subject: RE: [dpdk-dev] [PATCH v4] ixgbe: Drop flow control frames
> >>> from VFs
> >>>
> >>>
> >>> On Oct 23, 2015 9:30 AM, "Zhang, Helin" <helin.zhang@intel.com> wrote:
> >>>>
> >>>> From: Vladislav Zolotarov [mailto:vladz@cloudius-systems.com]
> >>>> Sent: Friday, October 23, 2015 2:24 PM
> >>>> To: Zhang, Helin
> >>>> Cc: Lu, Wenzhuo; dev@dpdk.org
> >>>> Subject: Re: [dpdk-dev] [PATCH v4] ixgbe: Drop flow control frames
> >>>> from VFs
> >>>>
> >>>>
> >>>> On Oct 23, 2015 9:02 AM, "Zhang, Helin" <helin.zhang@intel.com> wrote:
> >>>>>
> >>>>>> -----Original Message-----
> >>>>>> From: Lu, Wenzhuo
> >>>>>> Sent: Friday, October 23, 2015 1:52 PM
> >>>>>> To: dev@dpdk.org
> >>>>>> Cc: Zhang, Helin; Lu, Wenzhuo
> >>>>>> Subject: [PATCH v4] ixgbe: Drop flow control frames from VFs
> >>>>>>
> >>>>>> This patch will drop flow control frames from being transmitted from
> VSIs.
> >>>>>> With this patch in place a malicious VF cannot send flow control
> >>>>>> or PFC packets out on the wire.
> >>>> The whole idea of this (and similar i40e patches sent before) is
> >>>> really
> >> confusing.
> >>>> If u want to disable FC feature for VFs then go and disable the
> >>>> feature. Why
> >> keep (not malicious) user think that he/she has enabled the feature
> >> while u silently block it?
> >>>> Helin: I don't think disabling FC is equal to filtering out any
> >>>> pause frames. How
> >> about the software application constructs a pause frame and then
> >> tries to send it out?
> >>> But not disabling FC for the user and silently preventing it is
> >>> bogus. First, the
> >> conventional user should not be affected. I think this patch (and all
> >> its clones) should be extended to, first, disable the FC Tx feature
> >> for the relevant devices and only then adding any anti malicious filtering.
> >>> Helin: Disabling FC will disable both PF and VF FC, I don't find out
> >>> where can
> >> disable VF FC only. Am I wrong?
> >>
> >> There are flow_ctrl_get/set callbacks in eth_dev_ops which are used
> >> for configuring FC.
> >> I see that they are not set for either ixgbevf or i40evf, so here we
> >> are all set for these.
> > Helin: The behaviors rely on the hardware capability, but not the SW.
> > I meant I don't think it can support disabling VF FC. Please correct me in case I
> am wrong!
>
> I see. After a shallow sweep on the x540 and xl710 specs it seems that u r right.
> However I was talking about the SW interface only and since it is not enabled for
> the devices in question my whole objection is removed.
>
> thanks,
> vlad
Vlad, thank you very much!
The best way for this issue is to do that in hardware, but now we need a fix/workaround.
It is really good to have the discussion with you, and clarify a lot. I think it can also remove a lot of questions from others. Thank you!
Regards,
Helin
>
> >
> >
> >>>>>> V2:
> >>>>>> Reword the comments.
> >>>>>>
> >>>>>> V3:
> >>>>>> Move the check of set_ethertype_anti_spoofing to the top of the
> >>>>>> function,
> >> to
> >>>>>> avoid occupying an ethertype_filter entity without using it.
> >>>>>>
> >>>>>> V4:
> >>>>>> Remove the useless braces and return.
> >>>>>>
> >>>>>> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> >>>>> Acked-by: Helin Zhang <helin.zhang@intel.com>
> >>>>>
next prev parent reply other threads:[~2015-10-26 0:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-10 2:56 [dpdk-dev] [PATCH] ixgbe: workaround for Security issue in SR-IOV mode Wenzhuo Lu
2015-10-22 7:34 ` [dpdk-dev] [PATCH v2] ixgbe: Drop flow control frames from VFs Wenzhuo Lu
2015-10-23 2:49 ` Zhang, Helin
2015-10-23 3:26 ` Lu, Wenzhuo
2015-10-23 5:52 ` [dpdk-dev] [PATCH v4] " Wenzhuo Lu
2015-10-23 6:02 ` Zhang, Helin
2015-10-23 6:24 ` Vladislav Zolotarov
2015-10-23 6:30 ` Zhang, Helin
2015-10-23 6:57 ` Vladislav Zolotarov
2015-10-23 7:14 ` Zhang, Helin
2015-10-23 8:27 ` Vlad Zolotarov
2015-10-23 8:32 ` Zhang, Helin
2015-10-23 9:00 ` Vlad Zolotarov
2015-10-26 0:47 ` Zhang, Helin [this message]
2015-10-28 16:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A91D225@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=vladz@cloudius-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).