From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: fix issue of reconfigure hash enable flags
Date: Mon, 23 Nov 2015 05:58:02 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A94DC88@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F8D3E2EB@SHSMSX104.ccr.corp.intel.com>
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Monday, November 23, 2015 1:54 PM
> To: Zhang, Helin; dev@dpdk.org
> Cc: Pei, Yulong
> Subject: RE: [PATCH] i40e: fix issue of reconfigure hash enable flags
>
> >
> > - if (!key || key_len != ((I40E_PFQF_HKEY_MAX_INDEX + 1) *
> > - sizeof(uint32_t)))
> > + if (!key || key_len == 0) {
> > + PMD_DRV_LOG(DEBUG, "No key to be configured");
> > + return 0;
> > + } else if (key && (key_len != (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> > + sizeof(uint32_t))) {
> No need to check key in else if, it shouldn't be NULL here.
Yes, it should be removed. Thanks!
Regards,
Helin
> > + PMD_DRV_LOG(ERR, "Invalid key length %u", key_len);
> > return -EINVAL;
> > + }
>
> Thanks
> Jingjing
next prev parent reply other threads:[~2015-11-23 5:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 5:36 Helin Zhang
2015-11-23 5:53 ` Wu, Jingjing
2015-11-23 5:58 ` Zhang, Helin [this message]
2015-11-23 6:19 ` [dpdk-dev] [PATCH v2] " Helin Zhang
2015-11-23 8:29 ` Wu, Jingjing
2015-11-23 21:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A94DC88@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).