From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: skip any phy config as a workaround
Date: Tue, 24 Nov 2015 00:33:05 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A94E338@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <2795108.MCDRmV9y9P@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, November 24, 2015 6:17 AM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] i40e: skip any phy config as a workaround
>
> 2015-11-17 15:09, Helin Zhang:
> > As firmware does not support any link control from software driver
> > side, any phy config should be ignored as a workaround. Otherwise the
> > link might not be up again after binding back to kernel driver.
> >
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> [...]
> > +i40e_phy_conf_link(__rte_unused struct i40e_hw *hw,
> > + __rte_unused uint8_t abilities,
> > + __rte_unused uint8_t force_speed) {
> > + /* Skip any phy config on both 10G and 40G interfaces, as a
> workaround
> > + * for the link control limitation of that all link control should be
> > + * handled by firmware. It should follow up if link control will be
> > + * opened to software driver in future firmware versions.
> > + */
> > return I40E_SUCCESS;
> > }
>
> An error code seems more appropriate.
> But I guess you perfectly know what you do, so Applied, thanks
Yes, for now, I'd prefer to use I40E_SUCCESS. We will continue working on this when
firmware provides the link control to sw driver. Thank you very much!
Regards,
Helin
prev parent reply other threads:[~2015-11-24 0:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 7:09 Helin Zhang
2015-11-23 22:17 ` Thomas Monjalon
2015-11-24 0:33 ` Zhang, Helin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A94E338@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).