From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Topel, Bjorn" <bjorn.topel@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "david.marchand@6wind.com" <david.marchand@6wind.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] i40evf: Report error if HW CRC strip is disabled for Linux PF hosts
Date: Fri, 22 Apr 2016 05:18:59 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70AA123A9@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <6B5F13689D63284BBB0B66A5B315C82DBAC621@IRSMSX103.ger.corp.intel.com>
> -----Original Message-----
> From: Topel, Bjorn
> Sent: Friday, April 22, 2016 1:17 PM
> To: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org
> Cc: david.marchand@6wind.com; Wu, Jingjing <jingjing.wu@intel.com>
> Subject: RE: [PATCH v2] i40evf: Report error if HW CRC strip is disabled for Linux
> PF hosts
>
> >> >> + /* For Linux PF hosts, VF has no ability to disable HW CRC strip,
> >> >> + * and is implicitly enabled by the PF.
> >> >> + */
> >> >> + if (!conf->rxmode.hw_strip_crc) {
> >> >> + vf =
> I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
> >> >> + if ((vf->version_major ==
> I40E_VIRTCHNL_VERSION_MAJOR) &&
> >> >> + (vf->version_minor <=
> I40E_VIRTCHNL_VERSION_MINOR)) {
> >> >> + /* Peer is Linux PF host. */
> >> > Can you reword above comments?
> >> > It just means the host is not DPDK PF host driver, it could be
> >> > Linux driver, and possible others (e.g. FreeBSD, VMWARE?).
> >>
> >> Sure, I'll reword it! The broader question, however, is this correct
> >> for non- Linux/non-DPDK PF drivers?
> >> For FreeBSD I'll dig into the code, but for VMWARE (and I'd assume
> >> Microsoft
> >> Windows) it'll be harder.
> >>
> >> Do you have any insights on the behavior for the non-open i40e PF drivers?
> >>
> >> From the documentation [1], it's unclear whether non-Linux/non-DPDK
> >> PF drivers are supported. My interpretation was that only DPDK and
> >> Linux PF hosts are supported for Fortville NICs.
> > I guess only DPDK is different, though I am not sure.
> > As all other NIC drivers were developped by the same organization.
> > Even assuming that FreeBSD supports both configuration, it will not be
> > a problem, as DPDK just doesn't support, and nothing wrong.
>
> I verified against the FreeBSD ixl-1.4.27 driver, and it behaves (in terms of rxq
> crcstrip) the same way.
>
> It would be a problem if the non-Linux/non-DPDK drivers had it (rx crcstrip)
> *disabled* by default. (Further, being able to actually change the setting from a
> VF would be nice as well. :-)) This doesn't seem to be case, though.
>
> So, I'll change the wording from "Linux PF hosts" to "non-DPDK PF host". Would
> that be OK?
I would agree with you. :)
Thank you!
Helin
>
>
> Björn
next prev parent reply other threads:[~2016-04-22 5:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 14:58 [dpdk-dev] [PATCH] i40evf: Ignore disabled HW CRC strip " Björn Töpel
2016-04-15 7:40 ` David Marchand
2016-04-15 8:07 ` Zhang, Helin
2016-04-18 18:47 ` Topel, Bjorn
2016-04-19 2:31 ` Zhang, Helin
2016-04-21 15:02 ` [dpdk-dev] [PATCH v2] i40evf: Report error if HW CRC strip is disabled " Björn Töpel
2016-04-22 1:52 ` Zhang, Helin
2016-04-22 4:54 ` Topel, Bjorn
2016-04-22 5:07 ` Zhang, Helin
2016-04-22 5:17 ` Topel, Bjorn
2016-04-22 5:18 ` Zhang, Helin [this message]
2016-04-22 5:39 ` [dpdk-dev] [PATCH v3] i40evf: Report error if HW CRC strip is disabled for non-DPDK " Björn Töpel
2016-04-29 13:42 ` Zhang, Helin
2016-05-03 10:55 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70AA123A9@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=bjorn.topel@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).