From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: move PCI device ids to driver
Date: Mon, 11 Jul 2016 08:31:31 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E717D95794@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F80E16A0F6@SHSMSX103.ccr.corp.intel.com>
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Monday, July 11, 2016 3:29 PM
> To: Zhang, Helin <helin.zhang@intel.com>; Thomas Monjalon
> <thomas.monjalon@6wind.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] i40e: move PCI device ids to driver
>
> Hi, helin
>
> What I did is exactly same as what David's patch set did in i40e. I agree with his
> change.
> About the new header file, there is already i40e_devids.h in base code which
> defines the device IDs and vendor ID. This patch just combines them to be a pci
> device id in struct pci_id_i40e_map in source file. So I don't think a new header
> file is required. And about kernel driver, I checked it and it did in the similar way.
OK, I agree with you of that. Thanks!
Helin
>
> Thanks
> Jingjing
>
> > -----Original Message-----
> > From: Zhang, Helin
> > Sent: Monday, July 11, 2016 3:02 PM
> > To: Thomas Monjalon
> > Cc: Wu, Jingjing; dev@dpdk.org
> > Subject: RE: [PATCH] i40e: move PCI device ids to driver
> >
> > Hi Thomas
> >
> > It should be the one from David as I read that before. I am not sure
> > if all PMD has its own header files for device IDs, but I did see there was.
> > Even in recent kernel drivers (e.g. i40e), there is a new header file
> > for device ID list. I think it could be clearer, though no correct or wrong.
> >
> > Regards,
> > Helin
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > Sent: Monday, July 11, 2016 2:55 PM
> > > To: Zhang, Helin
> > > Cc: Wu, Jingjing; dev@dpdk.org
> > > Subject: Re: [PATCH] i40e: move PCI device ids to driver
> > >
> > > Hi Helin,
> > >
> > > 2016-07-11 06:19, Zhang, Helin:
> > > > Hi Jingjing
> > > >
> > > > I'd suggest to add a new header file in each PMD to define what we
> > defined
> > > in rte_pci_dev_ids.h.
> > >
> > > Why?
> > >
> > > > There was a patch set submitted several months ago, like that.
> > >
> > > Which one?
next prev parent reply other threads:[~2016-07-11 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 4:01 Jingjing Wu
2016-07-11 6:19 ` Zhang, Helin
2016-07-11 6:55 ` Thomas Monjalon
2016-07-11 7:02 ` Zhang, Helin
2016-07-11 7:29 ` Wu, Jingjing
2016-07-11 8:31 ` Zhang, Helin [this message]
2016-07-11 16:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E717D95794@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).