From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [DPDK] net/i40e: add return value checks
Date: Thu, 11 May 2017 01:04:05 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71AAADC17@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1494340654-29221-1-git-send-email-herakliusz.lipiec@intel.com>
> -----Original Message-----
> From: Lipiec, Herakliusz
> Sent: Tuesday, May 9, 2017 10:38 PM
> To: Zhang, Helin; Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: [DPDK] net/i40e: add return value checks
>
> Coverity issue: 1379362
> Coverity issue: 1379365
> Fixes: 71d35259ff67 ("i40e: tear down flow director")
>
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_fdir.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index
> 28cc554..b8cfa0f 100644
> --- a/drivers/net/i40e/i40e_fdir.c
> +++ b/drivers/net/i40e/i40e_fdir.c
> @@ -300,8 +300,12 @@ i40e_fdir_teardown(struct i40e_pf *pf)
> vsi = pf->fdir.fdir_vsi;
> if (!vsi)
> return;
> - i40e_switch_tx_queue(hw, vsi->base_queue, FALSE);
> - i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
> + int err = i40e_switch_tx_queue(hw, vsi->base_queue, FALSE);
> + if (err)
> + PMD_DRV_LOG(DEBUG, "Failed to do FDIR TX switch off");
> + err = i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
> + if (err)
> + PMD_DRV_LOG(DEBUG, "Failed to do FDIR RX switch off");
> i40e_dev_rx_queue_release(pf->fdir.rxq);
> pf->fdir.rxq = NULL;
> i40e_dev_tx_queue_release(pf->fdir.txq);
> --
> 2.7.4
next prev parent reply other threads:[~2017-05-11 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 14:37 Herakliusz Lipiec
2017-05-11 1:04 ` Zhang, Helin [this message]
2017-05-12 12:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71AAADC17@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=herakliusz.lipiec@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).