From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Zhao1, Wei" <wei.zhao1@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: add break case in flow API
Date: Sat, 13 Jan 2018 05:55:49 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71ACFC70D@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E706115312BB6B@SHSMSX103.ccr.corp.intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Friday, January 12, 2018 2:48 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: Yigit, Ferruh
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: add break case in flow API
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Friday, January 12, 2018 2:14 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [PATCH] net/i40e: add break case in flow API
> >
> > This bug may cause build error when there is no break case code, so add it.
> >
> > Fixes: accf70b2ae64e ("net/i40e: move RSS to flow API")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/i40e/i40e_flow.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index
> > 6106f78..cd9a9b6 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -4600,6 +4600,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
> > case RTE_ETH_FILTER_HASH:
> > ret = i40e_config_rss_filter_del(dev,
> > (struct i40e_rte_flow_rss_conf *)flow->rule);
> > + break;
> > default:
> > PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> > filter_type);
> > --
> > 2.9.3
>
> Thanks Ferruh's capture.
>
> Acked by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
prev parent reply other threads:[~2018-01-13 5:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 6:13 Wei Zhao
2018-01-12 6:47 ` Zhang, Qi Z
2018-01-13 5:55 ` Zhang, Helin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71ACFC70D@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).