From: "Zhang, Helin" <helin.zhang@intel.com>
To: "xiangxia.m.yue@gmail.com" <xiangxia.m.yue@gmail.com>,
"Dai, Wei" <wei.dai@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other interrupts not allowed.
Date: Wed, 17 Jan 2018 14:49:03 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71AD07DC5@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1515924222-19044-1-git-send-email-xiangxia.m.yue@gmail.com>
Hi Tonghao, Xiangxia
In general, I have several comments for your patch sets.
1. As there are 6 patches in your patch set, so a cover letter is needed.
2. You have send several version of patch sets, so '--in-reply-to' is needed to
make sure all can see the history version together. Please follow the guidance
on dpdk.org to contribute patches.
3. I saw one ACKs for one of your patches. You still need to get ACKs for all of
your patch set. Please address the comments, and ask maintainers to help directly.
4. As today is the integration deadline, I don't know if canbe applied in 18.02. Anyway
I will apply it as early as possibel whenever everything is ready and reasonable.
Thank you very much for your contribution!
Regards,
Helin
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> xiangxia.m.yue@gmail.com
> Sent: Sunday, January 14, 2018 6:04 PM
> To: Dai, Wei; Xing, Beilei
> Cc: dev@dpdk.org; Tonghao Zhang
> Subject: [dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when
> other interrupts not allowed.
>
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> When bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the rx-interrupt,
> there will be more than one epoll_wait on intr_handle.fd.
> One is in "eal-intr-thread" thread, and the others are in the thread which call
> the "rte_epoll_wait". The problem is that sometimes "eal-intr-thread" thread
> will process the rx interrupt, and then rte_epoll_wait can't get the event
> anymore, and the packets may be lost.
>
> The patch unregister the status interrupt handler in "eal-intr-thread"
> thread and the ixgbe pf is in the same case.
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ff19a56..0e056a2 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -5078,6 +5078,15 @@ static int
> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
> }
> ixgbevf_configure_msix(dev);
>
> + if (!rte_intr_allow_others(intr_handle)) {
> + rte_intr_callback_unregister(intr_handle,
> + ixgbevf_dev_interrupt_handler,
> + dev);
> + if (dev->data->dev_conf.intr_conf.lsc != 0)
> + PMD_INIT_LOG(INFO, "lsc won't enable because of"
> + " no intr multiplex");
> + }
> +
> /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt
> * is mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ).
> * If previous VFIO interrupt mapping setting in eth_ixgbevf_dev_init( )
> @@ -5120,6 +5129,12 @@ static int
> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
>
> ixgbe_dev_clear_queues(dev);
>
> + if (!rte_intr_allow_others(intr_handle))
> + /* resume to the default handler */
> + rte_intr_callback_register(intr_handle,
> + ixgbevf_dev_interrupt_handler,
> + (void *)dev);
> +
> /* Clean datapath event and queue/vec mapping */
> rte_intr_efd_disable(intr_handle);
> if (intr_handle->intr_vec != NULL) {
> --
> 1.8.3.1
prev parent reply other threads:[~2018-01-17 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 10:03 xiangxia.m.yue
2018-01-14 10:03 ` [dpdk-dev] [PATCH v3 2/6] net/ixgbevf: set the inter-interrupt interval for EITR xiangxia.m.yue
2018-01-14 10:03 ` [dpdk-dev] [PATCH v3 3/6] net/ixgbe: set the ITR via configuration xiangxia.m.yue
2018-01-14 10:03 ` [dpdk-dev] [PATCH v3 5/6] net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance xiangxia.m.yue
2018-01-14 10:03 ` [dpdk-dev] [PATCH v3 6/6] net/ixgbe: remove the unnecessary call rte_intr_enable xiangxia.m.yue
2018-01-15 4:57 ` [dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other interrupts not allowed Dai, Wei
2018-01-15 8:57 ` Tonghao Zhang
2018-01-17 1:38 ` Tonghao Zhang
2018-01-17 14:49 ` Zhang, Helin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71AD07DC5@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=wei.dai@intel.com \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).