From: "Zhang, Helin" <helin.zhang@intel.com>
To: Yong Wang <wang.yong19@zte.com.cn>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] net/i40e: add null point check and fix mem leak
Date: Wed, 24 Jan 2018 08:41:15 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71AD2055C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1516675500-10878-1-git-send-email-wang.yong19@zte.com.cn>
Hi Yong
Thank you so much for your contribution! I have comments in general.
1. for a patch set, you need a cover letter for the series.
2. If a patch is to fix a bug/issue, the title should start with 'fix'.
3. A 'Fixes:' line is needed for any bug fixes.
4. A 'Cc:' line is needed, if the patch should be back ported into any stable release version.
5. you can find some good examples from the 'git log'.
Thanks!
Regards,
Helin
next prev parent reply other threads:[~2018-01-24 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 2:44 Yong Wang
2018-01-23 2:44 ` [dpdk-dev] [PATCH v3 2/3] net/e1000: add null point check for rte_zmalloc Yong Wang
2018-01-23 2:45 ` [dpdk-dev] [PATCH v3 3/3] crypto/qat: add null point check and fix mem leak Yong Wang
2018-01-23 12:16 ` [dpdk-dev] [PATCH v3 3/3] crypto/qat: hebing " Trahe, Fiona
2018-01-23 12:16 ` [dpdk-dev] [PATCH v3 3/3] crypto/qat: " Trahe, Fiona
2018-01-24 8:41 ` Zhang, Helin [this message]
2018-01-24 9:28 ` [dpdk-dev] 答复: RE: [PATCH v3 1/3] net/i40e: add null point check andfix " wang.yong19
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71AD2055C@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=wang.yong19@zte.com.cn \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).