From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"eduser25@gmail.com" <eduser25@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e/vf: reset scatter_rx flag when configuration complies
Date: Fri, 6 Apr 2018 15:53:54 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71AE1605C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E706115317784D@SHSMSX103.ccr.corp.intel.com>
> -----Original Message-----
> From: Zhang, Helin
> Sent: Friday, April 6, 2018 4:46 PM
> To: Zhang, Qi Z; eduser25@gmail.com
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] net/i40e/vf: reset scatter_rx flag when configuration
> complies
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> > Sent: Monday, April 2, 2018 8:14 PM
> > To: eduser25@gmail.com
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] net/i40e/vf: reset scatter_rx flag
> > when configuration complies
> >
> > Hi Serra:
> >
> > > -----Original Message-----
> > > From: eduser25@gmail.com [mailto:eduser25@gmail.com]
> > > Sent: Friday, March 30, 2018 4:13 AM
> > > To: Zhang, Qi Z <qi.z.zhang@intel.com>
> > > Cc: dev@dpdk.org; Eduard Serra <eduser25@gmail.com>
> > > Subject: [PATCH] net/i40e/vf: reset scatter_rx flag when
> > > configuration complies
> > >
> > > From: Eduard Serra <eduser25@gmail.com>
> > >
> > > Scatter RX (scattered_rx) flag is currently not being resetted when
> > > new configuration is suplied to reconfigure a port, rendering the rx
> > > callback logic to
> >
> > s/suplied/supplied
> >
> > > always fall through the scatter branch.
> > >
> > > Signed-off-by: Eduard Serra <eduser25@gmail.com>
> > > ---
> > > drivers/net/i40e/i40e_ethdev_vf.c | 2 ++
> > > drivers/net/i40e/i40e_rxtx.c | 2 ++
> > > 2 files changed, 4 insertions(+)
> > >
> > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> > > b/drivers/net/i40e/i40e_ethdev_vf.c
> > > index 750d849..a072154 100644
> > > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > > @@ -1750,6 +1750,8 @@ i40evf_rxq_init(struct rte_eth_dev *dev,
> > > struct i40e_rx_queue *rxq)
> > > if (dev_data->dev_conf.rxmode.enable_scatter ||
> > > (rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size) {
> > > dev_data->scattered_rx = 1;
> > > + } else {
> > > + dev_data->scattered_rx = 0;
> >
> > Scattered_rx should not be reset if any queue already required You
> > should reset it before the queue loop
> Does it mean a NACK?
>
> /Helin
Anyway, please fix the checkpatch warnings reported on patchwork. Thanks!
/Helin
>
> >
> > > }
> > >
> > > return 0;
> > > diff --git a/drivers/net/i40e/i40e_rxtx.c
> > > b/drivers/net/i40e/i40e_rxtx.c index
> > > 1217e5a..8698747 100644
> > > --- a/drivers/net/i40e/i40e_rxtx.c
> > > +++ b/drivers/net/i40e/i40e_rxtx.c
> > > @@ -2561,6 +2561,8 @@ i40e_rx_queue_init(struct i40e_rx_queue *rxq)
> > > /* Check if scattered RX needs to be used. */
> > > if ((rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size) {
> > > dev_data->scattered_rx = 1;
> > > + } else {
> > > + dev_data->scattered_rx = 0;
> >
> > Same as above.
> >
> > Regards
> > Qi
> >
> > > }
> > >
> > > /* Init the RX tail regieter. */
> > > --
> > > 2.7.4
next prev parent reply other threads:[~2018-04-06 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 20:13 eduser25
2018-04-02 12:14 ` Zhang, Qi Z
2018-04-06 8:46 ` Zhang, Helin
2018-04-06 15:53 ` Zhang, Helin [this message]
2018-04-06 16:00 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71AE1605C@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=eduser25@gmail.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).