From: "Cel, TomaszX" <tomaszx.cel@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>, Akhil Goyal <akhil.goyal@nxp.com>,
"Daly, Lee" <lee.daly@intel.com>
Subject: [dpdk-dev] [PATCH] compress/isal: add appropriate flag on overflow
Date: Wed, 27 Mar 2019 17:44:37 +0000 [thread overview]
Message-ID: <F41EA7C757B0A74DB2ACA0C2C77F199401304877@HASMSX111.ger.corp.intel.com> (raw)
In-Reply-To: <6976F642F4CB7B4C9D17DE41C99F326019177641@hasmsx107.ger.corp.intel.com>
Hi Lee,
> This patch will change the operation status when ISA-L returns because of a
> recoverable out of space error, rather than a just generic fail.
>
> Signed-off-by: Lee Daly <lee.daly@intel.com>
> ---
> drivers/compress/isal/isal_compress_pmd.c | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/compress/isal/isal_compress_pmd.c
> b/drivers/compress/isal/isal_compress_pmd.c
> index 4748238..19c4d70 100644
> --- a/drivers/compress/isal/isal_compress_pmd.c
> +++ b/drivers/compress/isal/isal_compress_pmd.c
> @@ -348,12 +348,6 @@ chained_mbuf_decompression(struct rte_comp_op
> *op, struct isal_comp_qp *qp)
>
> ret = isal_inflate(qp->state);
>
> - if (ret != ISAL_DECOMP_OK) {
> - ISAL_PMD_LOG(ERR, "Decompression operation
> failed\n");
> - op->status = RTE_COMP_OP_STATUS_ERROR;
> - return ret;
> - }
> -
> /* Check for first segment, offset needs to be accounted for
> */
> if (remaining_data == op->src.length) {
> consumed_data = src->data_len -
> src_remaining_offset; @@ -374,6 +368,20 @@
> chained_mbuf_decompression(struct rte_comp_op *op, struct
> isal_comp_qp *qp)
> }
> }
>
> + if (ret == ISAL_OUT_OVERFLOW) {
> + ISAL_PMD_LOG(ERR, "Decompression operation ran
> "
> + "out of space, but can be recovered.\n%d
> bytes "
> + "consumed\t%d bytes produced\n",
> + consumed_data, qp->state->total_out);
> + op->status =
> +
> RTE_COMP_OP_STATUS_OUT_OF_SPACE_RECOVERABLE;
> + return ret;
> + } else if (ret < 0) {
> + ISAL_PMD_LOG(ERR, "Decompression operation
> failed\n");
> + op->status = RTE_COMP_OP_STATUS_ERROR;
> + return ret;
> + }
> +
> if (qp->state->avail_out == 0 &&
> qp->state->block_state !=
> ISAL_BLOCK_FINISH) {
> if (dst->next != NULL) {
> --
Tested-by: Tomasz Cel <tomaszx.cel@intel.com>
next prev parent reply other threads:[~2019-03-27 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 15:19 Lee Daly
[not found] ` <6976F642F4CB7B4C9D17DE41C99F326019177641@hasmsx107.ger.corp.intel.com>
2019-03-27 17:44 ` Cel, TomaszX [this message]
2019-03-27 17:44 ` Cel, TomaszX
2019-03-29 15:23 ` Akhil Goyal
2019-03-29 15:23 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F41EA7C757B0A74DB2ACA0C2C77F199401304877@HASMSX111.ger.corp.intel.com \
--to=tomaszx.cel@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=lee.daly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).