From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Shaw, Jeffrey B" <jeffrey.b.shaw@intel.com>
Cc: dev <dev@dpdk.org>,
"mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v2] eal: remove variable length array
Date: Sat, 15 Dec 2018 14:26:37 +0000 [thread overview]
Message-ID: <F5199A94-9AE3-4D55-89D3-CFD90308B996@intel.com> (raw)
In-Reply-To: <20181214204042.6435-1-jeffrey.b.shaw@intel.com>
> On Dec 14, 2018, at 2:40 PM, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
>
> Compilers that do not support the C99 standard, or do not implement
> gcc extensions, may not support variable length arrays.
>
> The code prior to this commit produced the following warning when
> compiled with "-Wvla -std=c90".
>
> warning: ISO C90 forbids variable length array ‘array’ [-Wvla]
>
> This commit removes the variable length array from the PMD debug
> trace function by allocating memory dynamically on the stack using
> alloca().
>
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> ---
>
> V2:
> - Reference C99 in commit message instead of C11.
> - Remove unnecessary cast of alloca() returning void *.
>
> ---
> lib/librte_eal/common/include/rte_dev.h | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
> index a9724dc91..6d7a220b0 100644
> --- a/lib/librte_eal/common/include/rte_dev.h
> +++ b/lib/librte_eal/common/include/rte_dev.h
> @@ -47,22 +47,21 @@ __attribute__((format(printf, 2, 0)))
> static inline void
> rte_pmd_debug_trace(const char *func_name, const char *fmt, ...)
> {
> + char *buffer;
> + int buf_len;
> va_list ap;
>
> va_start(ap, fmt);
> + buf_len = vsnprintf(NULL, 0, fmt, ap) + 1;
> + va_end(ap);
>
> - {
> - char buffer[vsnprintf(NULL, 0, fmt, ap) + 1];
> + buffer = alloca(buf_len);
Looks like some formatting problems with tab and/or spaces. DPDK is tabs of size 8 and no spaces before tabs.
The code looks fine to me, except for the calling vsnprintf twice. Could we have used char buffer[SOME_NUMBER_THAT_IS_REASONABLE];
This would remove the two calls to vsnprintf() and alloca usage.
If everyone is OK with it then I am ok after the formatting problems get fixed.
>
> - va_end(ap);
> -
> - va_start(ap, fmt);
> - vsnprintf(buffer, sizeof(buffer), fmt, ap);
> - va_end(ap);
> + va_start(ap, fmt);
> + vsnprintf(buffer, buf_len, fmt, ap);
> + va_end(ap);
>
> - rte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, "%s: %s",
> - func_name, buffer);
> - }
> + rte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, "%s: %s", func_name, buffer);
> }
>
> /*
> --
> 2.14.3
>
Regards,
Keith
prev parent reply other threads:[~2018-12-15 14:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 16:38 [dpdk-dev] [PATCH] " Jeff Shaw
2018-12-14 18:36 ` Stephen Hemminger
2018-12-14 18:59 ` Jeff Shaw
2018-12-14 19:17 ` Jeff Shaw
2018-12-14 18:36 ` Mattias Rönnblom
2018-12-14 19:07 ` Jeff Shaw
2018-12-14 20:28 ` Mattias Rönnblom
2018-12-14 20:50 ` [dpdk-dev] [PATCH] eal: simplify RTE_PMD_DEBUG_TRACE Stephen Hemminger
2018-12-14 21:20 ` Jeff Shaw
2018-12-14 21:57 ` Stephen Hemminger
2018-12-21 16:17 ` Ferruh Yigit
2018-12-21 18:11 ` [dpdk-dev] [PATCH v2] " Jeff Shaw
2018-12-21 18:18 ` [dpdk-dev] [PATCH v3] " Jeff Shaw
2018-12-22 0:37 ` Ferruh Yigit
2018-12-19 21:45 ` [dpdk-dev] [PATCH] eal: remove variable length array Thomas Monjalon
2018-12-20 10:53 ` Mattias Rönnblom
2018-12-20 11:03 ` Thomas Monjalon
2018-12-14 20:40 ` [dpdk-dev] [PATCH v2] " Jeff Shaw
2018-12-15 14:26 ` Wiles, Keith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5199A94-9AE3-4D55-89D3-CFD90308B996@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=jeffrey.b.shaw@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).