From: "Ouyang, Changchun" <changchun.ouyang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss
Date: Wed, 28 Jan 2015 01:35:00 +0000 [thread overview]
Message-ID: <F52918179C57134FAEC9EA62FA2F96251198EBCF@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1561845.4QtzaTeLCI@xps13>
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, January 27, 2015 8:13 PM
> To: Ouyang, Changchun
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss
>
> > To follow up the comments from Wodkowski, PawelX, remove this
> > unnecessary check, as check_mq_mode has already check the queue
> number
> > in device configure stage, if the queue number of vf is not correct,
> > it will return error code and exit, so it doesn't need check again
> > here in device start stage(note: pf_host_configure is called in device start
> stage).
> >
> > This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f
> >
> > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
>
> Suggested-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> Fixes: 42d2f78abcb77 ("configure VF RSS")
>
> Applied
>
Thanks very much for the applying!
> Changchun, as you are working on ixgbe, maybe you would like to review
> some ixgbe patches from others?
>
No problem, I will try to do it when my bandwidth allows me to do it, :-)
Thanks
Changchun
next prev parent reply other threads:[~2015-01-28 1:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 3:38 Ouyang Changchun
2015-01-27 12:12 ` Thomas Monjalon
2015-01-28 1:35 ` Ouyang, Changchun [this message]
2015-01-29 16:13 ` Wodkowski, PawelX
2015-01-30 1:20 ` Ouyang, Changchun
2015-01-30 10:16 ` Wodkowski, PawelX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F52918179C57134FAEC9EA62FA2F96251198EBCF@shsmsx102.ccr.corp.intel.com \
--to=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).