From: "Daly, Lee" <lee.daly@intel.com>
To: "Cel, TomaszX" <tomaszx.cel@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"Tucker, Greg B" <greg.b.tucker@intel.com>,
"Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com>
Subject: Re: [dpdk-stable] [PATCH] compress/isal: fix compression stream initialization
Date: Wed, 27 Mar 2019 11:35:28 +0000 [thread overview]
Message-ID: <F5C6929789601049BEB7272E267355988931B9@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <1553593329-8075-1-git-send-email-tomaszx.cel@intel.com>
Hi Tomasz,
> -----Original Message-----
> From: Cel, TomaszX
> Sent: Tuesday, March 26, 2019 9:42 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Daly, Lee
> <lee.daly@intel.com>; Tucker, Greg B <greg.b.tucker@intel.com>; Jozwiak,
> TomaszX <tomaszx.jozwiak@intel.com>
> Subject: [PATCH] compress/isal: fix compression stream initialization
>
> This patch fixes ISAL internal state fields initialization.
>
> Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
> ---
> drivers/compress/isal/isal_compress_pmd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/compress/isal/isal_compress_pmd.c
> b/drivers/compress/isal/isal_compress_pmd.c
> index 8879a42..1e518b3 100644
> --- a/drivers/compress/isal/isal_compress_pmd.c
> +++ b/drivers/compress/isal/isal_compress_pmd.c
> @@ -412,7 +412,7 @@ process_isal_deflate(struct rte_comp_op *op, struct
> isal_comp_qp *qp,
> uint8_t *temp_level_buf = qp->stream->level_buf;
>
> /* Initialize compression stream */
> - isal_deflate_stateless_init(qp->stream);
> + isal_deflate_init(qp->stream);
>
> qp->stream->level_buf = temp_level_buf;
>
> @@ -514,8 +514,6 @@ process_isal_deflate(struct rte_comp_op *op, struct
> isal_comp_qp *qp,
> op->output_chksum = qp->stream->internal_state.crc;
> }
>
> - isal_deflate_reset(qp->stream);
I have tested this and it works, removing this reset function makes sense as everything cleared here is cleared in the init function anyway,
On that note, the same is to be said to isal_inflate_reset, everything cleared in reset is cleared, plus more, in isal_inflate_init.
I suggest we also remove isal_inflate_reset for commonality across both functions.
> -
> return ret;
> }
>
> --
> 2.7.4
next prev parent reply other threads:[~2019-03-27 11:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 9:42 Tomasz Cel
2019-03-27 11:35 ` Daly, Lee [this message]
2019-03-27 17:46 ` [dpdk-stable] [PATCH v2] This patch " Tomasz Cel
2019-03-27 17:46 ` [dpdk-stable] [PATCH v2] compress/isal: " Tomasz Cel
2019-03-28 9:06 ` [dpdk-stable] [PATCH v3 0/1] This patch " Tomasz Cel
2019-03-28 9:06 ` [dpdk-stable] [PATCH v3 1/1] compress/isal: " Tomasz Cel
2019-03-28 12:58 ` Trahe, Fiona
2019-03-28 13:23 ` Daly, Lee
2019-03-29 14:20 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5C6929789601049BEB7272E267355988931B9@IRSMSX106.ger.corp.intel.com \
--to=lee.daly@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=greg.b.tucker@intel.com \
--cc=stable@dpdk.org \
--cc=tomaszx.cel@intel.com \
--cc=tomaszx.jozwiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).