From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: supported offload capabilities query
Date: Tue, 27 Dec 2016 09:40:36 +0000 [thread overview]
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDC8901@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013158B9AE@SHSMSX101.ccr.corp.intel.com>
Hi, Beilei
Nothing is missing. This capability have no switch in DPDK now. So it don't have 'on' or 'off'.
-----Original Message-----
From: Xing, Beilei
Sent: Tuesday, December 27, 2016 4:18 PM
To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
Cc: Wu, Jingjing <jingjing.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>
Subject: RE: [dpdk-dev] [PATCH v4] app/testpmd: supported offload capabilities query
Hi Qiming,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
> Sent: Friday, December 23, 2016 5:32 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Subject: [dpdk-dev] [PATCH v4] app/testpmd: supported offload
> capabilities query
>
> Add two new commands "show port cap <port>" and "show port cap all"to
> diaplay what offload capabilities supported in ports. It will not only
> display all the capabilities of the port, but also the enabling
> condition for each capability in the running time.
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
> v2 changes:
> * fixed the output style as Ferruh's patch show and add some
> description in docs for new functions.
> v3 changes:
> * add new command in cmd_help_long_parsed.
> v4 changes:
> * use 'cap' instead of 'capa'.
> ---
> ---
> app/test-pmd/cmdline.c | 17 ++-
> app/test-pmd/config.c | 172
> ++++++++++++++++++++++++++++
> app/test-pmd/testpmd.h | 1 +
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
> 4 files changed, 192 insertions(+), 10 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> 63b55dc..bbfafab 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> +
> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_CKSUM) {
> + printf("TCP checksum: ");
> + if (dev->data->dev_conf.rxmode.hw_ip_checksum)
> + printf("on\n");
> + else
> + printf("off\n");
> + }
> +
> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_LRO) {
> + printf("Large receive offload: ");
> + if (dev->data->dev_conf.rxmode.enable_lro)
> + printf("on\n");
> + else
> + printf("off\n");
> + }
> +
> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_QINQ_STRIP) {
> + printf("Double VLANs stripped: ");
> + if (dev->data->dev_conf.rxmode.hw_vlan_extend)
> + printf("on\n");
> + else
> + printf("off\n");
> + }
> +
> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM)
> + printf("Outer IPv4 checksum: ");
Seems there's no 'on' or 'off' printed here, do I miss anything?
> +
> + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_VLAN_INSERT) {
> + printf("VLAN insert: ");
> + if (ports[port_id].tx_ol_flags &
> TESTPMD_TX_OFFLOAD_INSERT_VLAN)
> + printf("on\n");
> + else
> + printf("off\n");
> + }
> +
next prev parent reply other threads:[~2016-12-27 9:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 11:31 [dpdk-dev] [PATCH] " Qiming Yang
2016-12-02 11:40 ` Mcnamara, John
2016-12-02 11:42 ` Mcnamara, John
2016-12-06 7:07 ` [dpdk-dev] [PATCH v2] " Qiming Yang
2016-12-20 5:50 ` Wu, Jingjing
2016-12-21 2:20 ` [dpdk-dev] [PATCH v3] " Qiming Yang
2016-12-21 2:37 ` Yuanhan Liu
2016-12-21 11:09 ` Yang, Qiming
2016-12-23 9:31 ` [dpdk-dev] [PATCH v4] " Qiming Yang
2016-12-26 1:21 ` Wu, Jingjing
2016-12-27 8:18 ` Xing, Beilei
2016-12-27 9:40 ` Yang, Qiming [this message]
2016-12-27 9:47 ` Xing, Beilei
2017-01-12 3:26 ` [dpdk-dev] [PATCH v5] " Qiming Yang
2017-01-13 8:43 ` De Lara Guarch, Pablo
2017-01-13 9:40 ` Yang, Qiming
2017-01-13 12:35 ` De Lara Guarch, Pablo
2017-01-14 3:06 ` Yang, Qiming
2017-01-16 2:00 ` Yang, Qiming
2017-01-13 12:17 ` [dpdk-dev] [PATCH v6] " Qiming Yang
2017-01-16 2:31 ` [dpdk-dev] [PATCH v7] " Qiming Yang
2017-01-16 10:10 ` De Lara Guarch, Pablo
2017-01-30 15:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDC8901@SHSMSX101.ccr.corp.intel.com \
--to=qiming.yang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).