From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Chen, Jing D" <jing.d.chen@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] test: add delay time in test alarm
Date: Fri, 7 Jul 2017 04:35:38 +0000 [thread overview]
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7C488A@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D3C678919@shsmsx102.ccr.corp.intel.com>
Hi, Mark
"2" and "10" is the special number in this test case, not a general number.
/* Test that we cannot cancel an alarm from within the callback itself
* Also test that we can cancel head-of-line callbacks ok.*/
flag = 0;
recursive_error = 0;
rte_eal_alarm_set(10 * US_PER_MS, test_remove_in_callback, (void *)1);
rte_eal_alarm_set(20 * US_PER_MS, test_remove_in_callback, (void *)2);
> -----Original Message-----
> From: Chen, Jing D
> Sent: Thursday, July 6, 2017 4:29 PM
> To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>
> Subject: RE: [PATCH v3] test: add delay time in test alarm
>
>
> + while (flag != 2 && count++ < RTE_TEST_MAX_REPEAT)
> + rte_delay_ms(10);
>
> Why you don't replace "2" and "10" with macro?
>
> -----Original Message-----
> From: Yang, Qiming
> Sent: Tuesday, June 20, 2017 11:24 AM
> To: dev@dpdk.org
> Cc: Chen, Jing D <jing.d.chen@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>
> Subject: [PATCH v3] test: add delay time in test alarm
>
> Because accuracy of timing to the microsecond is not guaranteed in
> rte_eal_alarm_set, this function will not be called before the requested time,
> but may be called a period of time afterwards which can not be calculated. In
> order to ensure test alarm running success, this patch added the delay time
> before check the flag.
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
> v2 changes:
> * fixed coding style problems
> v3 changes:
> * replaced the numeric by macro
> ---
> ---
> test/test/test_alarm.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/test/test/test_alarm.c b/test/test/test_alarm.c index
> ecb2f6d..40f55b5 100644
> --- a/test/test/test_alarm.c
> +++ b/test/test/test_alarm.c
> @@ -47,6 +47,7 @@
>
> #define RTE_TEST_ALARM_TIMEOUT 10 /* ms */
> #define RTE_TEST_CHECK_PERIOD 3 /* ms */
> +#define RTE_TEST_MAX_REPEAT 20
>
> static volatile int flag;
>
> @@ -96,6 +97,7 @@ static int
> test_multi_alarms(void)
> {
> int rm_count = 0;
> + int count = 0;
> cb_count.cnt = 0;
>
> printf("Expect 6 callbacks in order...\n"); @@ -169,7 +171,10 @@
> test_multi_alarms(void)
> printf("Error, cancelling head-of-list leads to premature
> callback\n");
> return -1;
> }
> - rte_delay_ms(10);
> +
> + while (flag != 2 && count++ < RTE_TEST_MAX_REPEAT)
> + rte_delay_ms(10);
> +
> if (flag != 2) {
> printf("Error - expected callback not called\n");
> rte_eal_alarm_cancel(test_remove_in_callback, (void *)-1);
> @@ -212,7 +217,7 @@ test_alarm(void)
> printf("fail to set alarm callback\n");
> return -1;
> }
> - while (flag == 0 && count ++ < 6)
> + while (flag == 0 && count++ < RTE_TEST_MAX_REPEAT)
> rte_delay_ms(RTE_TEST_CHECK_PERIOD);
>
> if (flag == 0){
> --
> 2.7.4
next prev parent reply other threads:[~2017-07-07 4:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 6:03 [dpdk-dev] [PATCH] " Qiming Yang
2017-05-05 2:17 ` [dpdk-dev] [PATCH v2] " Qiming Yang
2017-05-05 6:28 ` Chen, Jing D
2017-05-16 3:15 ` Yang, Qiming
2017-06-20 3:24 ` [dpdk-dev] [PATCH v3] " Qiming Yang
2017-07-06 8:28 ` Chen, Jing D
2017-07-07 4:35 ` Yang, Qiming [this message]
2017-07-12 1:31 ` Chen, Jing D
2017-07-14 5:51 ` [dpdk-dev] FW: " Yang, Qiming
2017-07-14 9:36 ` [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7C488A@SHSMSX101.ccr.corp.intel.com \
--to=qiming.yang@intel.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).