From: "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 header files
Date: Fri, 30 Jan 2015 10:56:46 +0000 [thread overview]
Message-ID: <F6F2A6264E145F47A18AB6DF8E87425D12B8FDC6@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <3047657.sxLCa6eQXg@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, January 30, 2015 11:21 AM
> To: Wodkowski, PawelX
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 header
> files
>
> Hi Pawel,
>
> > Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> > ---
> > lib/librte_pmd_bond/rte_eth_bond_8023ad.h | 8 ++++++++
> > lib/librte_pmd_bond/rte_eth_bond_8023ad_private.h | 8 ++++++++
>
> Why adding extern C in a private header file?
>
> --
> Thomas
To be consistent with rte_eth_bond_private.h where it is included.
--
Pawel
next prev parent reply other threads:[~2015-01-30 10:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 12:45 Pawel Wodkowski
2015-01-30 10:20 ` Thomas Monjalon
2015-01-30 10:56 ` Wodkowski, PawelX [this message]
2015-01-30 11:42 ` Declan Doherty
2015-01-30 12:11 ` Wodkowski, PawelX
2015-01-30 12:15 ` Declan Doherty
2015-01-30 13:21 ` [dpdk-dev] [PATCH v2] bond: fix 'extern "C"' " Pawel Wodkowski
2015-01-30 13:35 ` Declan Doherty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F6F2A6264E145F47A18AB6DF8E87425D12B8FDC6@IRSMSX102.ger.corp.intel.com \
--to=pawelx.wodkowski@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).