From: Dunk <dunk@denkimushi.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [PATCH v2] lib/eal/ppc fix compilation for musl
Date: Mon, 2 May 2022 21:18:05 +0100 [thread overview]
Message-ID: <F81C696D-BD89-4779-BB62-48DB27D5AEAF@denkimushi.com> (raw)
In-Reply-To: <CAJFAV8yPg6ZGgE-O=_6W+igZYpotcq3jdKcEQwebjTbPzvzGBQ@mail.gmail.com>
> On 2 May 2022, at 18:42, David Marchand <david.marchand@redhat.com> wrote:
>
> On Mon, May 2, 2022 at 4:26 PM Duncan Bellamy <dunk@denkimushi.com> wrote:
>>
>> musl lacks __ppc_get_timebase() but has __builtin_ppc_get_timebase()
>>
>> the __ppc_get_timebase_freq() is taken from:
>> https://git.alpinelinux.org/aports/commit/?id=06b03f70fb94972286c0c9f6278df89e53903833
>>
>> Signed-off-by: Duncan Bellamy <dunk@denkimushi.com>
>> ---
>> lib/eal/ppc/include/rte_cycles.h | 6 ++++++
>> lib/eal/ppc/rte_cycles.c | 32 ++++++++++++++++++++++++++++++++
>> 2 files changed, 38 insertions(+)
>>
>> diff --git a/lib/eal/ppc/include/rte_cycles.h b/lib/eal/ppc/include/rte_cycles.h
>> index 5585f9273c..98ffbd2592 100644
>> --- a/lib/eal/ppc/include/rte_cycles.h
>> +++ b/lib/eal/ppc/include/rte_cycles.h
>> @@ -10,7 +10,9 @@
>> extern "C" {
>> #endif
>>
>> +#if defined(__GLIBC__)
>
> features.h should be included before looking for __GLIBC__.
>
>
> --
> David Marchand
>
Okay, wondered why it wasn’t working
next prev parent reply other threads:[~2022-05-02 20:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220502115228.3AAAB1242D4@dpdk.org>
2022-05-02 14:26 ` Duncan Bellamy
2022-05-02 17:41 ` David Marchand
2022-05-02 20:18 ` Dunk [this message]
2022-05-02 17:42 ` David Christensen
2022-05-02 20:20 ` Dunk
2022-05-07 9:47 ` [PATCH v3] " Duncan Bellamy
2022-05-07 19:43 ` [PATCH v4] " Duncan Bellamy
2022-05-07 21:03 ` [PATCH v5] " Duncan Bellamy
2022-05-07 21:15 ` [PATCH v6] " Duncan Bellamy
2022-05-09 12:06 ` David Marchand
2022-05-09 22:39 ` Dunk
2022-05-14 7:14 ` [PATCH v7] eal/ppc: " Duncan Bellamy
2022-05-19 16:18 ` David Marchand
2022-05-31 17:24 ` David Christensen
2022-06-01 15:06 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F81C696D-BD89-4779-BB62-48DB27D5AEAF@denkimushi.com \
--to=dunk@denkimushi.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).