From: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Liu, Changpeng" <changpeng.liu@intel.com>,
"Bie, Tiwei" <tiwei.bie@intel.com>,
"i.maximets@samsung.com" <i.maximets@samsung.com>
Subject: Re: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend
Date: Fri, 8 Mar 2019 09:18:12 +0000 [thread overview]
Message-ID: <FBE7E039FA50BF47A673AD0BD3CD56A8462BC246@HASMSX105.ger.corp.intel.com> (raw)
In-Reply-To: <20190228153134.31865-3-maxime.coquelin@redhat.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxime Coquelin
> Sent: Thursday, February 28, 2019 4:32 PM
> To: dev@dpdk.org; Liu, Changpeng <changpeng.liu@intel.com>; Bie, Tiwei
> <tiwei.bie@intel.com>; i.maximets@samsung.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by
> external backend
>
> External backends may have specific requests to handle, and so
> we don't want the vhost-user lib to handle these requests as
> errors.
>
> This patch also changes the experimental API by introducing
> RTE_VHOST_MSG_RESULT_NOT_HANDLED so that vhost-user lib
> can report an error if a message is handled neither by
> the vhost-user library nor by the external backend.
>
> The logic changes a bit so that if the callback returns
> with ERR, OK or REPLY, it is considered the message
> is handled by the external backend so it won't be
> handled by the vhost-user library.
> It is still possible for an external backend to listen
> to requests that have to be handled by the vhost-user
> library like SET_MEM_TABLE, but the callback have to
> return NOT_HANDLED in that case.
>
> Suggested-by: Ilya Maximets <i.maximets@samsung.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
Besides the fall-through compilation issue,
Tested-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Thanks!
next prev parent reply other threads:[~2019-03-08 9:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 15:31 [dpdk-dev] [RFC v2 0/2] vhost: Support external backend only vhost-user requests Maxime Coquelin
2019-02-28 15:31 ` [dpdk-dev] [RFC v2 1/2] vhost: add API to set protocol features flags Maxime Coquelin
2019-03-08 9:13 ` Stojaczyk, Dariusz
2019-02-28 15:31 ` [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend Maxime Coquelin
2019-02-28 16:56 ` Maxime Coquelin
2019-03-04 15:25 ` Ilya Maximets
2019-03-04 16:02 ` Maxime Coquelin
2019-03-04 16:24 ` Ilya Maximets
2019-03-08 9:18 ` Stojaczyk, Dariusz [this message]
2019-03-08 10:01 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FBE7E039FA50BF47A673AD0BD3CD56A8462BC246@HASMSX105.ger.corp.intel.com \
--to=dariusz.stojaczyk@intel.com \
--cc=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).