From: Nipun Gupta <nipun.gupta@nxp.com>
To: Harry van Haaren <harry.van.haaren@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH v4 0/4] eventdev: add attribute based get APIs
Date: Fri, 15 Sep 2017 06:14:26 +0000 [thread overview]
Message-ID: <HE1PR0401MB2425C53CC73B6820B197B535E66C0@HE1PR0401MB2425.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1505405343-18234-1-git-send-email-harry.van.haaren@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren
> Sent: Thursday, September 14, 2017 21:39
> To: dev@dpdk.org
> Cc: jerin.jacob@caviumnetworks.com; Harry van Haaren
> <harry.van.haaren@intel.com>
> Subject: [dpdk-dev] [PATCH v4 0/4] eventdev: add attribute based get APIs
>
> This patchset refactors the eventdev API to be more flexible
> and capable. In particular, the API is capable of returning an
> error value if an invalid device, port or attribute ID is passed
> in, which was not possible with the previous APIs.
>
> The implementation of this patchset is based on a v1 patch[1],
> and after some discussion this API was seen as the best solution.
>
> In terms of flexibility, the attribute id allows addition of new
> common eventdev layer attributes without breaking ABI or adding
> new functions. Note that these attributes are not data-path, and
> that PMDs should continue to use the xstats API for reporting any
> unique PMD statistics that are available.
>
> Regarding API/ABI compatibility, I have removed the functions from
> the .map files - please review the .map file changes for ABI issues
> carefully.
>
> The last patch of this series adds a started attribute to the device,
> allowing the application to query if a device is currently running.
>
> -Harry
>
> [1] http://dpdk.org/dev/patchwork/patch/27152/
>
> ---
>
> v4:
> - Rework based on review by Jerin
> - default: cases into switches
> - Remove old functions from .map file
> - Remove /* out */ parameters
> - Rework header file definitions to match logical order
> - Rework patch split
> - Cleaner removal of queue_count() function
>
> v3:
> - Fix checkpatch issues... somehow I broke my checkpatch script :/
>
> v2:
> - New APIs design based on discussion of initial patch.
>
>
>
> Harry van Haaren (4):
> eventdev: add port attribute function
> eventdev: add dev attribute get function
> eventdev: add queue attribute function
> eventdev: add device started attribute
>
> lib/librte_eventdev/rte_eventdev.c | 97 ++++++++++++------
> lib/librte_eventdev/rte_eventdev.h | 115 +++++++++++----------
> lib/librte_eventdev/rte_eventdev_version.map | 14 ++-
> test/test/test_eventdev.c | 132 +++++++++++++++++++------
> test/test/test_eventdev_octeontx.c | 143 ++++++++++++++++++++-------
> 5 files changed, 345 insertions(+), 156 deletions(-)
>
> --
> 2.7.4
Changes look good.
Series Acked-by: Nipun Gupta <Nipun.gupta@nxp.com>
next prev parent reply other threads:[~2017-09-15 6:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 12:48 [dpdk-dev] [PATCH] eventdev: add dev id checks to config functions Harry van Haaren
2017-09-04 5:20 ` Jerin Jacob
2017-09-06 14:45 ` Van Haaren, Harry
2017-09-06 14:57 ` Jerin Jacob
2017-09-08 15:18 ` [dpdk-dev] [PATCH v2 0/3] eventdev: add attribute based get APIs Harry van Haaren
2017-09-08 15:18 ` [dpdk-dev] [PATCH v2 1/4] eventdev: add port attribute function Harry van Haaren
2017-09-08 15:18 ` [dpdk-dev] [PATCH v2 2/4] eventdev: add dev attribute get function Harry van Haaren
2017-09-08 15:18 ` [dpdk-dev] [PATCH v2 3/4] eventdev: add queue attribute function Harry van Haaren
2017-09-08 15:18 ` [dpdk-dev] [PATCH v2 4/4] eventdev: add device started attribute Harry van Haaren
2017-09-08 15:36 ` [dpdk-dev] [PATCH v3 0/4] eventdev: add attribute based get APIs Harry van Haaren
2017-09-08 15:36 ` [dpdk-dev] [PATCH v3 1/4] eventdev: add port attribute function Harry van Haaren
2017-09-11 16:35 ` Jerin Jacob
2017-09-08 15:36 ` [dpdk-dev] [PATCH v3 2/4] eventdev: add dev attribute get function Harry van Haaren
2017-09-11 16:51 ` Jerin Jacob
2017-09-08 15:36 ` [dpdk-dev] [PATCH v3 3/4] eventdev: add queue attribute function Harry van Haaren
2017-09-11 17:36 ` Jerin Jacob
2017-09-08 15:36 ` [dpdk-dev] [PATCH v3 4/4] eventdev: add device started attribute Harry van Haaren
2017-09-11 17:52 ` Jerin Jacob
2017-09-12 8:07 ` Van Haaren, Harry
2017-09-11 16:16 ` [dpdk-dev] [PATCH v3 0/4] eventdev: add attribute based get APIs Jerin Jacob
2017-09-14 16:08 ` [dpdk-dev] [PATCH v4 " Harry van Haaren
2017-09-14 16:09 ` [dpdk-dev] [PATCH v4 1/4] eventdev: add port attribute function Harry van Haaren
2017-09-14 16:19 ` Van Haaren, Harry
2017-09-14 16:09 ` [dpdk-dev] [PATCH v4 2/4] eventdev: add dev attribute get function Harry van Haaren
2017-09-14 16:09 ` [dpdk-dev] [PATCH v4 3/4] eventdev: add queue attribute function Harry van Haaren
2017-09-14 16:09 ` [dpdk-dev] [PATCH v4 4/4] eventdev: add device started attribute Harry van Haaren
2017-09-15 6:14 ` Nipun Gupta [this message]
2017-09-21 9:57 ` [dpdk-dev] [PATCH v4 0/4] eventdev: add attribute based get APIs Jerin Jacob
2017-09-15 12:33 ` Jerin Jacob
2017-09-20 13:35 ` [dpdk-dev] [PATCH v5 0/5] Harry van Haaren
2017-09-20 13:35 ` [dpdk-dev] [PATCH v5 1/5] eventdev: add port attribute function Harry van Haaren
2017-09-20 13:36 ` [dpdk-dev] [PATCH v5 2/5] eventdev: add dev attribute get function Harry van Haaren
2017-09-20 13:36 ` [dpdk-dev] [PATCH v5 3/5] eventdev: add queue attribute function Harry van Haaren
2017-09-20 13:36 ` [dpdk-dev] [PATCH v5 4/5] eventdev: add device started attribute Harry van Haaren
2017-09-20 13:36 ` [dpdk-dev] [PATCH v5 5/5] eventdev: bump library version Harry van Haaren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0401MB2425C53CC73B6820B197B535E66C0@HE1PR0401MB2425.eurprd04.prod.outlook.com \
--to=nipun.gupta@nxp.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).