From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Andy Green <andy@warmcat.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change eth-dev-ops API to return int
Date: Sun, 20 May 2018 02:43:58 +0000 [thread overview]
Message-ID: <HE1PR0402MB2780EBDCEE08B8A4739970FB90960@HE1PR0402MB2780.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <70fc4570-7447-a9fa-dda6-a41f220c35ca@warmcat.com>
> -----Original Message-----
> From: Andy Green [mailto:andy@warmcat.com]
> Sent: Friday, May 18, 2018 4:42 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change eth-
> dev-ops API to return int
>
>
>
> On 05/18/2018 06:59 PM, Shreyansh Jain wrote:
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
> >> Sent: Thursday, May 17, 2018 7:19 PM
> >> To: dev@dpdk.org
> >> Subject: [dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change eth-
> dev-
> >> ops API to return int
> >>
> >> Signed-off-by: Andy Green <andy@warmcat.com>
> >> ---
> >> drivers/net/ark/ark_ethdev_rx.c | 4 ++--
> >> drivers/net/ark/ark_ethdev_rx.h | 3 +--
> >> drivers/net/avf/avf_rxtx.c | 4 ++--
> >> drivers/net/avf/avf_rxtx.h | 2 +-
> >> drivers/net/bnxt/bnxt_ethdev.c | 5 +++--
> >> drivers/net/dpaa/dpaa_ethdev.c | 4 ++--
> >> drivers/net/dpaa2/dpaa2_ethdev.c | 6 +++---
> >> drivers/net/e1000/e1000_ethdev.h | 6 ++----
> >> drivers/net/e1000/em_rxtx.c | 4 ++--
> >> drivers/net/e1000/igb_rxtx.c | 4 ++--
> >> drivers/net/enic/enic_ethdev.c | 9 +++------
> >> drivers/net/i40e/i40e_rxtx.c | 4 ++--
> >> drivers/net/i40e/i40e_rxtx.h | 3 +--
> >> drivers/net/ixgbe/ixgbe_ethdev.h | 3 +--
> >> drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
> >> drivers/net/nfp/nfp_net.c | 9 ++++-----
> >> drivers/net/sfc/sfc_ethdev.c | 4 ++--
> >> drivers/net/thunderx/nicvf_ethdev.c | 2 +-
> >> drivers/net/thunderx/nicvf_rxtx.c | 4 ++--
> >> drivers/net/thunderx/nicvf_rxtx.h | 2 +-
> >> drivers/net/vhost/rte_eth_vhost.c | 4 ++--
> >> examples/l3fwd-power/main.c | 2 +-
> >> lib/librte_ethdev/rte_ethdev_core.h | 4 ++--
> >> 23 files changed, 44 insertions(+), 52 deletions(-)
> >>
> >
> > [...]
> >
> >> rxq = dev->data->rx_queues[rx_queue_id];
> >> diff --git a/drivers/net/dpaa/dpaa_ethdev.c
> >> b/drivers/net/dpaa/dpaa_ethdev.c
> >> index d014a11aa..70a5b4851 100644
> >> --- a/drivers/net/dpaa/dpaa_ethdev.c
> >> +++ b/drivers/net/dpaa/dpaa_ethdev.c
> >> @@ -725,7 +725,7 @@ static void dpaa_eth_tx_queue_release(void *txq
> >> __rte_unused)
> >> PMD_INIT_FUNC_TRACE();
> >> }
> >>
> >> -static uint32_t
> >> +static int
> >> dpaa_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t
> rx_queue_id)
> >> {
> >> struct dpaa_if *dpaa_intf = dev->data->dev_private;
> >> @@ -738,7 +738,7 @@ dpaa_dev_rx_queue_count(struct rte_eth_dev *dev,
> >> uint16_t rx_queue_id)
> >> RTE_LOG(DEBUG, PMD, "RX frame count for q(%d) is %u\n",
> >> rx_queue_id, frm_cnt);
> >> }
> >> - return frm_cnt;
> >> + return (int)frm_cnt;
> >> }
> >>
> >> static int dpaa_link_down(struct rte_eth_dev *dev)
> >> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c
> >> b/drivers/net/dpaa2/dpaa2_ethdev.c
> >> index 9297725d9..eb6245b83 100644
> >> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> >> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> >> @@ -604,7 +604,7 @@ dpaa2_dev_tx_queue_release(void *q __rte_unused)
> >> PMD_INIT_FUNC_TRACE();
> >> }
> >>
> >> -static uint32_t
> >> +static int
> >> dpaa2_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t
> >> rx_queue_id)
> >> {
> >> int32_t ret;
> >> @@ -612,7 +612,7 @@ dpaa2_dev_rx_queue_count(struct rte_eth_dev
> *dev,
> >> uint16_t rx_queue_id)
> >> struct dpaa2_queue *dpaa2_q;
> >> struct qbman_swp *swp;
> >> struct qbman_fq_query_np_rslt state;
> >> - uint32_t frame_cnt = 0;
> >> + int frame_cnt = 0;
> >>
> >> PMD_INIT_FUNC_TRACE();
> >>
> >> @@ -628,7 +628,7 @@ dpaa2_dev_rx_queue_count(struct rte_eth_dev
> *dev,
> >> uint16_t rx_queue_id)
> >> dpaa2_q = (struct dpaa2_queue *)priv->rx_vq[rx_queue_id];
> >>
> >> if (qbman_fq_query_state(swp, dpaa2_q->fqid, &state) == 0) {
> >> - frame_cnt = qbman_fq_state_frame_count(&state);
> >> + frame_cnt = (int)qbman_fq_state_frame_count(&state);
> >> DPAA2_PMD_DEBUG("RX frame count for q(%d) is %u",
> >> rx_queue_id, frame_cnt);
> >> }
> >
> > This doesn't feel correct. A counter, especially the number of
> descriptors in a queue, doesn't have a negative value. So, 1) this is
> an unnatural return and 2) we litter the code with unnecessary
> typecast.
> >
> > In fact, even in the above change, the debug messages continue to
> print unsigned values. So, another typecast would be required there.
> >
> > I don't agree with this change - at least not until some strong gcc 8
> warning reason is triggering this. Can you please point me to some
> conversation on mailing list which enforces this?
> >
>
> hmmmmm.... no, it's not my idea.
>
> If you don't like it, don't do it, I don't mind either way. I sent a
> patch that just solved the compiler error only already, and was told on
> the list it would be cooler if these things returned an int instead.
>
> There's no point challenging me about the wisdom of it, although it
> seems reasonable to me. I sent a patch, list guy $1 says do X instead,
> I do X and then list guy $2 says EXPLAIN YOURSELF.
That is what a community is. Consensus has to be built, not expected automagically. If you touch a line, you are responsible for it (also, because in future git blame would point *you* out for a change).
>
> I really don't care, $1 should argue with $2 and leave me out of it.
I was expecting that you point me out to where the $1 conversation was - so that I could have understood reason for your change. You didn’t do that and rather went into a tangential conversation.
I will not be searching through your previous patches and conversations to understand why $1 said something and you *agreed* to go ahead and make changes.
>
> If I don't hear anything more I'll reissue with just the minimal change
> later.
>
> -Andy
next prev parent reply other threads:[~2018-05-20 2:44 UTC|newest]
Thread overview: 174+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 1:58 [dpdk-dev] [PATCH v3 00/24] Fixes for GCC8 against lagopus Andy Green
2018-05-12 1:58 ` [dpdk-dev] [PATCH v3 01/24] lib/librte_eal: import libbsd strlcpy Andy Green
2018-05-13 14:56 ` Thomas Monjalon
2018-05-13 23:07 ` Andy Green
2018-05-12 1:58 ` [dpdk-dev] [PATCH v3 02/24] lib/librte_ethdev: change eth-dev-ops API to return int Andy Green
2018-05-13 14:58 ` Thomas Monjalon
2018-05-13 23:10 ` Andy Green
2018-05-13 23:49 ` Thomas Monjalon
2018-05-12 1:58 ` [dpdk-dev] [PATCH v3 03/24] rte_common.h: cast gcc builtin result to avoid complaints Andy Green
2018-05-13 20:40 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 04/24] lib/librte_eal: explicit tmp cast Andy Green
2018-05-13 16:19 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 05/24] lib/librte_eal: explicit cast for signed change Andy Green
2018-05-13 20:40 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 06/24] /lib/librte_eal: stage cast from uint64 to long Andy Green
2018-05-13 16:24 ` Thomas Monjalon
2018-05-13 23:17 ` Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 07/24] rte_spinlock.h: stack declarations before code Andy Green
2018-05-13 20:42 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: " Andy Green
2018-05-13 16:47 ` Thomas Monjalon
2018-05-13 23:21 ` Andy Green
2018-05-13 23:44 ` Thomas Monjalon
2018-05-14 0:09 ` Andy Green
2018-05-14 1:49 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 09/24] rte_ring.h: remove signed type flipflopping Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 10/24] rte_dev.h: stack declaration at top of own basic block Andy Green
2018-05-13 20:41 ` Thomas Monjalon
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 11/24] rte_mbuf.h: avoid warnings from inadvertant promotion Andy Green
2018-05-13 16:54 ` Thomas Monjalon
2018-05-13 23:27 ` Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 12/24] rte_mbuf.h: explicit casts for int16 to uint16 Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 13/24] rte_mbuf.h: make sure RTE-MIN compares same types Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 14/24] rte_mbuf.h: explicit cast restricting ptrdiff to uint16 Andy Green
2018-05-12 1:59 ` [dpdk-dev] [PATCH v3 15/24] rte_mbuf.h: explicit cast for size type to uint32 Andy Green
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 16/24] rte_mbuf.h: explicit casts to uint16 to avoid warnings Andy Green
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 17/24] rte_byteorder.h: explicit cast for return promotion Andy Green
2018-05-13 16:59 ` Thomas Monjalon
2018-05-14 0:02 ` Andy Green
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 18/24] rte_ether.h: explicit cast avoiding truncation warning Andy Green
2018-05-13 17:02 ` Thomas Monjalon
2018-05-14 0:05 ` Andy Green
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 19/24] rte_ether.h: stack vars declared at top of function Andy Green
2018-05-13 20:42 ` Thomas Monjalon
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 20/24] rte_ethdev.h: align sign and scope of temp var Andy Green
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 21/24] rte_ethdev.h: explicit cast for truncation Andy Green
2018-05-13 20:43 ` Thomas Monjalon
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 22/24] rte_hash_crc.h: stack vars declared at top of function Andy Green
2018-05-13 20:44 ` Thomas Monjalon
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 23/24] rte_hash_crc.h: explicit casts for truncation Andy Green
2018-05-13 20:44 ` Thomas Monjalon
2018-05-12 2:00 ` [dpdk-dev] [PATCH v3 24/24] test_table_pipeline: repair munged indirection level Andy Green
2018-05-13 20:33 ` Thomas Monjalon
2018-05-14 0:22 ` Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 00/23] Fixes for GCC8 against lagopus Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 01/23] lib/librte_eal: import libbsd strlcpy Andy Green
2018-05-17 10:36 ` Bruce Richardson
2018-05-17 12:35 ` Andy Green
2018-05-17 12:56 ` Bruce Richardson
2018-05-17 13:00 ` Andy Green
2018-05-17 13:49 ` Bruce Richardson
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 02/23] rte_eal_version_map: export rte-strlcpy Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 03/23] lib/librte_ethdev: change eth-dev-ops API to return int Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 04/23] lib/librte_eal: explicit tmp cast Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 05/23] /lib/librte_eal: stage cast from uint64 to long Andy Green
2018-05-17 10:47 ` Bruce Richardson
2018-05-17 12:56 ` Andy Green
2018-05-14 5:09 ` [dpdk-dev] [PATCH v4 06/23] rte_ring_generic.h: stack declarations before code Andy Green
2018-05-17 8:29 ` Olivier Matz
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 07/23] rte_ring.h: remove signed type flipflopping Andy Green
2018-05-17 8:29 ` Olivier Matz
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 08/23] rte_mbuf.h: avoid warnings from inadvertant promotion Andy Green
2018-05-17 8:30 ` Olivier Matz
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 09/23] rte_mbuf.h: explicit casts for int16 to uint16 Andy Green
2018-05-17 8:30 ` Olivier Matz
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 10/23] rte_mbuf.h: make sure RTE-MIN compares same types Andy Green
2018-05-17 10:49 ` Bruce Richardson
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 11/23] rte_mbuf.h: explicit cast restricting ptrdiff to uint16 Andy Green
2018-05-17 10:50 ` Bruce Richardson
2018-05-17 11:03 ` Ananyev, Konstantin
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 12/23] rte_mbuf.h: explicit cast for size type to uint32 Andy Green
2018-05-17 10:53 ` Bruce Richardson
2018-05-17 13:09 ` Andy Green
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 13/23] rte_mbuf.h: explicit casts to uint16 to avoid warnings Andy Green
2018-05-17 10:58 ` Bruce Richardson
2018-05-17 13:28 ` Andy Green
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 14/23] rte_ether.h: explicit cast avoiding truncation warning Andy Green
2018-05-17 11:01 ` Bruce Richardson
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 15/23] rte_ethdev.h: align sign and scope of temp var Andy Green
2018-05-17 13:54 ` Bruce Richardson
2018-05-17 14:17 ` Andy Green
2018-05-17 14:26 ` Bruce Richardson
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 16/23] rte_byteorder.h: explicit cast for return promotion Andy Green
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 17/23] test_table_pipeline: repair munged indirection level Andy Green
2018-05-14 10:35 ` Singh, Jasvinder
2018-05-14 10:46 ` Andy Green
2018-05-14 5:10 ` [dpdk-dev] [PATCH v4 18/23] rte_rwlock.h: gcc8 sign conversion warnings Andy Green
2018-05-14 5:11 ` [dpdk-dev] [PATCH v4 19/23] rte_ip.h: cast input to bswap16 to be uint16 Andy Green
2018-05-14 5:11 ` [dpdk-dev] [PATCH v4 20/23] rte_ip.h: cast around promotion to int Andy Green
2018-05-14 5:11 ` [dpdk-dev] [PATCH v4 21/23] rte_ip.h: cast type decided by sizeof to uint32 Andy Green
2018-05-14 5:11 ` [dpdk-dev] [PATCH v4 22/23] rte_ip.h: cast return checksum size to uint16 Andy Green
2018-05-14 5:11 ` [dpdk-dev] [PATCH v4 23/23] rte_ip.h: cast away gcc8 warning on rte_ipv6_phdr_cksum Andy Green
2018-05-17 13:48 ` [dpdk-dev] [PATCH v5 00/21] Fixes for GCC8 against lagopus Andy Green
2018-05-17 13:48 ` [dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change eth-dev-ops API to return int Andy Green
2018-05-17 13:55 ` Bruce Richardson
2018-05-17 13:59 ` Andy Green
2018-05-18 10:59 ` Shreyansh Jain
2018-05-18 11:12 ` Andy Green
2018-05-20 2:43 ` Shreyansh Jain [this message]
2018-05-20 4:11 ` Andy Green
2018-05-21 6:52 ` Stephen Hemminger
2018-05-21 7:25 ` Andy Green
2018-05-18 13:02 ` [dpdk-dev] [PATCH] rte_ethdev.h: fix gcc8.1 sign conversion warining Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 02/21] rte_string_fns.h: fix gcc8.1 sign conv warning in lstrcpy Andy Green
2018-05-17 13:56 ` Bruce Richardson
2018-05-17 14:03 ` [dpdk-dev] [PATCH] " Andy Green
2018-05-17 14:40 ` [dpdk-dev] [PATCH v5 02/21] " Stephen Hemminger
2018-05-17 15:28 ` Bruce Richardson
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 03/21] lib/librte_eal: explicit tmp cast Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 04/21] /lib/librte_eal: stage cast from uint64 to long Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 05/21] rte_ring_generic.h: stack declarations before code Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 06/21] rte_ring.h: remove signed type flipflopping Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 07/21] rte_mbuf.h: avoid warnings from inadvertant promotion Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 08/21] rte_mbuf.h: explicit casts for int16 to uint16 Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 09/21] rte_mbuf.h: make sure RTE-MIN compares same types Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 10/21] rte_mbuf.h: explicit cast restricting ptrdiff to uint16 Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 11/21] rte_ether.h: explicit cast avoiding truncation warning Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 12/21] rte_rwlock.h: gcc8 sign conversion warnings Andy Green
2018-05-17 13:49 ` [dpdk-dev] [PATCH v5 13/21] rte_ip.h: cast input to bswap16 to be uint16 Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 14/21] rte_ip.h: cast around promotion to int Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 15/21] rte_ip.h: cast type decided by sizeof to uint32 Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 16/21] rte_ip.h: cast return checksum size to uint16 Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 17/21] rte_ip.h: cast away gcc8 warning on rte_ipv6_phdr_cksum Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 18/21] rte_mbuf.h: explicit cast for size type to uint32 Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 19/21] rte_mbuf.h: explicit casts to uint16 to avoid warnings Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 20/21] rte_ethdev.h: align sign and scope of temp var Andy Green
2018-05-17 13:50 ` [dpdk-dev] [PATCH v5 21/21] rte_byteorder.h: explicit cast for return promotion Andy Green
2018-05-20 22:18 ` [dpdk-dev] [PATCH v5 00/21] Fixes for GCC8 against lagopus Thomas Monjalon
2018-05-21 2:00 ` [dpdk-dev] [PATCH v6 0/8] " Andy Green
2018-05-21 2:00 ` [dpdk-dev] [PATCH v6 1/8] lib/librte_eal: explicit tmp cast Andy Green
2018-05-21 11:06 ` [dpdk-dev] [PATCH] lib/librte_eal: change type of tmp Andy Green
2018-05-21 12:07 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 2/8] rte_rwlock.h: gcc8 sign conversion warnings Andy Green
2018-05-21 12:10 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 3/8] rte_ip.h: cast type decided by sizeof to uint32 Andy Green
2018-05-21 12:13 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 4/8] rte_mbuf.h: reduce temp to match uint16 types Andy Green
2018-05-21 12:14 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 5/8] rte_mbuf.h: avoid implicit demotion in 64-bit arith Andy Green
2018-05-21 12:27 ` Bruce Richardson
2018-05-22 1:29 ` Andy Green
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 6/8] rte_mbuf.h: choose correct type for temp Andy Green
2018-05-21 13:09 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 7/8] rte_mbuf.h: add and subtract explicitly to avoid promotion Andy Green
2018-05-21 13:10 ` Bruce Richardson
2018-05-21 2:01 ` [dpdk-dev] [PATCH v6 8/8] rte_ethdev.h: align sign and scope of temp var Andy Green
2018-05-21 13:30 ` Bruce Richardson
2018-05-22 1:25 ` Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 0/8] Fixes for GCC8 against lagopus Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 1/8] lib/librte_eal: change type of tmp Andy Green
2018-05-22 9:13 ` Bruce Richardson
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 2/8] rte_rwlock.h: gcc8 sign conversion warnings Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 3/8] rte_ip.h: cast type decided by sizeof to uint32 Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 4/8] rte_mbuf.h: reduce temp to match uint16 types Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 5/8] rte_mbuf.h: avoid implicit demotion in 64-bit arith Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 6/8] rte_mbuf.h: choose correct type for temp Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 7/8] rte_mbuf.h: add and subtract explicitly to avoid promotion Andy Green
2018-05-22 1:24 ` [dpdk-dev] [PATCH v7 8/8] rte_ethdev.h: align sign and scope of temp var Andy Green
2018-05-22 9:12 ` Bruce Richardson
2018-05-22 14:18 ` Thomas Monjalon
2018-05-22 9:13 ` [dpdk-dev] [PATCH v7 0/8] Fixes for GCC8 against lagopus Bruce Richardson
2018-05-22 9:14 ` Andy Green
2018-05-22 14:29 ` Thomas Monjalon
2018-05-21 2:06 ` [dpdk-dev] [PATCH v5 00/21] " Andy Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0402MB2780EBDCEE08B8A4739970FB90960@HE1PR0402MB2780.eurprd04.prod.outlook.com \
--to=shreyansh.jain@nxp.com \
--cc=andy@warmcat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).