From: Ophir Munk <ophirmu@mellanox.com>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
"Olga Shern" <olgas@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/failsafe: report on supported RSS functions
Date: Wed, 9 May 2018 13:53:24 +0000 [thread overview]
Message-ID: <HE1PR0501MB2314CB972D150F9A3DD5A98DD1990@HE1PR0501MB2314.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180509120011.oyftrzgm74tmbwhk@bidouze.vm.6wind.com>
Hi,
PATCH v2 was sent
> -----Original Message-----
> From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com]
> Sent: Wednesday, May 09, 2018 3:00 PM
> To: Ophir Munk <ophirmu@mellanox.com>
> Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Olga Shern
> <olgas@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Subject: Re: [PATCH v1] net/failsafe: report on supported RSS functions
>
> Hi Ophir,
>
> The commit title could read:
>
> net/failsafe: advertize supported RSS functions
>
> Some nitpicks in the commit log:
>
> On Tue, May 08, 2018 at 06:02:41PM +0000, Ophir Munk wrote:
> > Report on failsafe supported RSS functions as part of dev_infos_get
> ^^^^^^^^^
> Advertize
>
> > callback. Set failsafe default RSS hash functions to be: ETH_RSS_IP,
> > ETH_RSS_UDP and ETH_RSS_TCP.
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^
>
> Better on its own line:
>
> ETH_RSS_IP, ETH_RSS_UDP, and ETH_RSS_TCP.
>
>
> > The net result of failsafe RSS hash functions is the logical AND of
> ^^^
> should be removed
>
> > the RSS hash functions among all failsafe sub_devices and failsafe own
> > defaults.
> >
> > Previous to this commit RSS support was reported as none. Since the
> > introduction of [1] it is required that all RSS configurations will be
> ^^^^
> should be
> removed
> > verified.
> >
> > [1] commit 8863a1fbfc66 ("ethdev: add supported hash function check")
> >
> > Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> > ---
> > drivers/net/failsafe/failsafe_ops.c | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/failsafe/failsafe_ops.c
> > b/drivers/net/failsafe/failsafe_ops.c
> > index 6d44884..d18b793 100644
> > --- a/drivers/net/failsafe/failsafe_ops.c
> > +++ b/drivers/net/failsafe/failsafe_ops.c
> > @@ -83,7 +83,10 @@ static struct rte_eth_dev_info default_infos = {
> > DEV_TX_OFFLOAD_UDP_CKSUM |
> > DEV_TX_OFFLOAD_TCP_CKSUM |
> > DEV_TX_OFFLOAD_TCP_TSO,
> > - .flow_type_rss_offloads = 0x0,
> > + .flow_type_rss_offloads =
> > + ETH_RSS_IP |
> > + ETH_RSS_UDP |
> > + ETH_RSS_TCP,
> > };
> >
> > static int
> > @@ -805,26 +808,29 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
> > } else {
> > uint64_t rx_offload_capa;
> > uint64_t rxq_offload_capa;
> > + uint64_t rss_offloads_hf;
>
> The name would read better as rss_hf_offload_capa.
>
> rss_hash_function_offload_capa is easier to understand than
> rss_offloads_hash_function.
>
> >
> > rx_offload_capa = default_infos.rx_offload_capa;
> > rxq_offload_capa = default_infos.rx_queue_offload_capa;
> > + rss_offloads_hf = default_infos.flow_type_rss_offloads;
> > FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) {
> > rte_eth_dev_info_get(PORT_ID(sdev),
> > &PRIV(dev)->infos);
> > rx_offload_capa &= PRIV(dev)-
> >infos.rx_offload_capa;
> > rxq_offload_capa &=
> > PRIV(dev)-
> >infos.rx_queue_offload_capa;
> > + rss_offloads_hf &=
> > + PRIV(dev)-
> >infos.flow_type_rss_offloads;
> > }
> > sdev = TX_SUBDEV(dev);
> > rte_eth_dev_info_get(PORT_ID(sdev), &PRIV(dev)->infos);
> > PRIV(dev)->infos.rx_offload_capa = rx_offload_capa;
> > PRIV(dev)->infos.rx_queue_offload_capa =
> rxq_offload_capa;
> > + PRIV(dev)->infos.flow_type_rss_offloads = rss_offloads_hf;
> > PRIV(dev)->infos.tx_offload_capa &=
> > default_infos.tx_offload_capa;
> > PRIV(dev)->infos.tx_queue_offload_capa &=
> >
> default_infos.tx_queue_offload_capa;
> > - PRIV(dev)->infos.flow_type_rss_offloads &=
> > -
> default_infos.flow_type_rss_offloads;
> > }
> > rte_memcpy(infos, &PRIV(dev)->infos, sizeof(*infos)); }
> > --
> > 2.7.4
> >
>
> With those nitpicks fixed,
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
>
> --
> Gaëtan Rivet
> 6WIND
next prev parent reply other threads:[~2018-05-09 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 18:02 Ophir Munk
2018-05-09 12:00 ` Gaëtan Rivet
2018-05-09 13:53 ` Ophir Munk [this message]
2018-05-09 13:46 ` [dpdk-dev] [PATCH v2] net/failsafe: advertise " Ophir Munk
2018-05-09 14:04 ` Gaëtan Rivet
2018-05-09 22:46 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0501MB2314CB972D150F9A3DD5A98DD1990@HE1PR0501MB2314.eurprd05.prod.outlook.com \
--to=ophirmu@mellanox.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=olgas@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).