From: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Ola Liljedahl <Ola.Liljedahl@arm.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail
Date: Sat, 3 Nov 2018 20:12:40 +0000 [thread overview]
Message-ID: <HE1PR0701MB239463577089E46983B2371CE1C80@HE1PR0701MB2394.eurprd07.prod.outlook.com> (raw)
In-Reply-To: <17713879.gC9jYcxDUo@xps>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: den 27 oktober 2018 17:13
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>; dev@dpdk.org;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>;
> stable@dpdk.org; Ola Liljedahl <Ola.Liljedahl@arm.com>;
> olivier.matz@6wind.com; chaozhu@linux.vnet.ibm.com;
> bruce.richardson@intel.com; konstantin.ananyev@intel.com
> Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of
> the tail
>
> 27/10/2018 17:00, Jerin Jacob:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 17/10/2018 08:35, Gavin Hu (Arm Technology China):
> > > > Hi Jerin
> > > >
> > > > As the 1st one of the 3-patch set was not concluded, I submit this 2-
> patch series to unblock the merge.
> > >
> > > The thread is totally messed up because:
> > > - there is no cover letter
> > > - some different series (testpmd, i40e and doc) are in the same
> thread
> > > - v4 replies to a different series
> > > - this version should be a v5 but has no number
> > > - this version replies to the v3
> > > - patchwork still shows v3 and "v5"
> > > - replies from Ola are not quoting previous discussion
> > >
> > > Because of all of this, it is really difficult to follow.
> > > This is probably the reason of the lack of review outside of Arm.
> > >
> > > One more issue: you must Cc the relevant maintainers.
> > > Here:
> > > - Olivier for rte_ring
> > > - Chao for IBM platform
> > > - Bruce and Konstantin for x86
> > >
> > > Guys, it is really cool to have more Arm developpers in DPDK.
> > > But please consider better formatting your discussions, it is really
> > > important in our contribution workflow.
> > >
> > > I don't know what to do.
> > > I suggest to wait for more feedbacks and integrate it in -rc2.
> >
> > This series has been acked and tested. Sure, if we are looking for
> > some more feedback we can push to -rc2 if not it a good candidate to
> > be selected for -rc1.
>
> It has been acked and tested only for Arm platforms.
> And Olivier, the ring maintainer, was not Cc.
>
> I feel it is not enough.
>
I've just run an out-of-tree test program I have for the DSW scheduler, which verify scheduler atomic semantics. The results are:
Non-C11 mode: pass
C11 mode before this patch set: fail
C11 mode after this patch set: pass
This suggests the current C11 mode is broken even on x86_64. I haven't been following this thread closely, so maybe this is known already.
I've also run an out-of-tree DSW throughput benchmark, and I've found that going from Non-C11 to C11 gives a 4% slowdown. After this patch, the slowdown is only 2,8%.
GCC 7.3.0 and a Skylake x86_64.
next prev parent reply other threads:[~2018-11-03 20:12 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 1:18 [dpdk-stable] [PATCH] ring: fix c11 memory ordering issue Gavin Hu
2018-08-06 9:19 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-08-08 1:39 ` Gavin Hu
2018-08-07 3:19 ` [dpdk-stable] [PATCH v2] " Gavin Hu
2018-08-07 5:56 ` He, Jia
2018-08-07 7:56 ` Gavin Hu
2018-08-08 3:07 ` Jerin Jacob
2018-08-08 7:23 ` Thomas Monjalon
[not found] ` <20180917074735.28161-1-gavin.hu@arm.com>
2018-09-17 7:47 ` [dpdk-stable] [PATCH v3 3/3] doc: add cross compile part for sample applications Gavin Hu
2018-09-17 9:48 ` Jerin Jacob
2018-09-17 10:28 ` Gavin Hu (Arm Technology China)
2018-09-17 10:34 ` Jerin Jacob
2018-09-17 10:55 ` Gavin Hu (Arm Technology China)
2018-09-17 10:49 ` [dpdk-stable] [PATCH v4] " Gavin Hu
2018-09-17 10:53 ` [dpdk-stable] [PATCH v5] " Gavin Hu
2018-09-18 11:00 ` Jerin Jacob
2018-09-19 0:33 ` [dpdk-stable] [PATCH v6] " Gavin Hu
2018-09-17 8:11 ` [dpdk-stable] [PATCH v4 1/4] bus/fslmc: fix undefined reference of memsegs Gavin Hu
2018-09-17 8:11 ` [dpdk-stable] [PATCH v4 2/4] ring: read tail using atomic load Gavin Hu
2018-09-20 6:41 ` Jerin Jacob
2018-09-25 9:26 ` Gavin Hu (Arm Technology China)
2018-09-17 8:11 ` [dpdk-stable] [PATCH v4 3/4] ring: synchronize the load and store of the tail Gavin Hu
2018-09-17 8:11 ` [dpdk-stable] [PATCH v4 4/4] ring: move the atomic load of head above the loop Gavin Hu
2018-10-27 14:21 ` Thomas Monjalon
2018-09-17 8:17 ` [dpdk-stable] [PATCH v3 1/3] ring: read tail using atomic load Gavin Hu
2018-09-17 8:17 ` [dpdk-stable] [PATCH v3 2/3] ring: synchronize the load and store of the tail Gavin Hu
2018-09-26 9:29 ` Gavin Hu (Arm Technology China)
2018-09-26 9:59 ` Justin He
2018-09-29 10:57 ` Jerin Jacob
2018-10-17 6:29 ` [dpdk-stable] [PATCH 1/2] " Gavin Hu
2018-10-17 6:29 ` [dpdk-stable] [PATCH 2/2] ring: move the atomic load of head above the loop Gavin Hu
2018-10-17 6:35 ` [dpdk-stable] [PATCH 1/2] ring: synchronize the load and store of the tail Gavin Hu (Arm Technology China)
2018-10-27 14:39 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-10-27 15:00 ` Jerin Jacob
2018-10-27 15:13 ` Thomas Monjalon
2018-10-27 15:34 ` Jerin Jacob
2018-10-27 15:48 ` Thomas Monjalon
2018-10-29 2:51 ` Gavin Hu (Arm Technology China)
2018-10-29 2:57 ` Gavin Hu (Arm Technology China)
2018-10-29 10:16 ` Jerin Jacob
2018-10-29 10:47 ` Thomas Monjalon
2018-10-29 11:10 ` Jerin Jacob
2018-11-03 20:12 ` Mattias Rönnblom [this message]
2018-11-05 21:51 ` Honnappa Nagarahalli
2018-11-06 11:03 ` Mattias Rönnblom
[not found] ` <1540955698-209159-1-git-send-email-gavin.hu@arm.com>
2018-10-31 3:14 ` [dpdk-stable] [PATCH v2 " Gavin Hu
2018-10-31 3:14 ` [dpdk-stable] [PATCH v2 2/2] ring: move the atomic load of head above the loop Gavin Hu
2018-10-31 3:35 ` [dpdk-stable] [PATCH v2 1/2] ring: synchronize the load and store of the tail Gavin Hu
2018-10-31 3:35 ` [dpdk-stable] [PATCH v2 2/2] ring: move the atomic load of head above the loop Gavin Hu
2018-10-31 9:36 ` Thomas Monjalon
2018-10-31 10:27 ` Gavin Hu (Arm Technology China)
2018-09-17 8:17 ` [dpdk-stable] [PATCH v3 3/3] " Gavin Hu
2018-09-26 9:29 ` Gavin Hu (Arm Technology China)
2018-09-26 10:06 ` Justin He
2018-09-29 7:19 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2018-09-29 10:59 ` [dpdk-stable] " Jerin Jacob
2018-09-26 9:29 ` [dpdk-stable] [PATCH v3 1/3] ring: read tail using atomic load Gavin Hu (Arm Technology China)
2018-09-26 10:09 ` Justin He
2018-09-29 10:48 ` Jerin Jacob
2018-10-05 0:47 ` Gavin Hu (Arm Technology China)
2018-10-05 8:21 ` Ananyev, Konstantin
2018-10-05 11:15 ` Ola Liljedahl
2018-10-05 11:36 ` Ola Liljedahl
2018-10-05 13:44 ` Ananyev, Konstantin
2018-10-05 14:21 ` Ola Liljedahl
2018-10-05 15:11 ` Honnappa Nagarahalli
2018-10-05 17:07 ` Jerin Jacob
2018-10-05 18:05 ` Ola Liljedahl
2018-10-05 20:06 ` Honnappa Nagarahalli
2018-10-05 20:17 ` Ola Liljedahl
2018-10-05 20:29 ` Honnappa Nagarahalli
2018-10-05 20:34 ` Ola Liljedahl
2018-10-06 7:41 ` Jerin Jacob
2018-10-06 19:44 ` Ola Liljedahl
2018-10-06 19:59 ` Ola Liljedahl
2018-10-07 4:02 ` Jerin Jacob
2018-10-07 20:11 ` Ola Liljedahl
2018-10-07 20:44 ` Ola Liljedahl
2018-10-08 6:06 ` Jerin Jacob
2018-10-08 9:22 ` Ola Liljedahl
2018-10-08 10:00 ` Jerin Jacob
2018-10-08 10:25 ` Ola Liljedahl
2018-10-08 10:33 ` Gavin Hu (Arm Technology China)
2018-10-08 10:39 ` Ola Liljedahl
2018-10-08 10:41 ` Gavin Hu (Arm Technology China)
2018-10-08 10:49 ` Jerin Jacob
2018-10-10 6:28 ` Gavin Hu (Arm Technology China)
2018-10-10 19:26 ` Honnappa Nagarahalli
2018-10-08 10:46 ` Jerin Jacob
2018-10-08 11:21 ` Ola Liljedahl
2018-10-08 11:50 ` Jerin Jacob
2018-10-08 11:59 ` Ola Liljedahl
2018-10-08 12:05 ` Jerin Jacob
2018-10-08 12:20 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2018-10-08 12:30 ` Ola Liljedahl
2018-10-09 8:53 ` Olivier Matz
2018-10-09 3:16 ` [dpdk-stable] " Honnappa Nagarahalli
2018-10-08 14:43 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-10-08 14:46 ` Ola Liljedahl
2018-10-08 15:45 ` Ola Liljedahl
2018-10-08 5:27 ` [dpdk-stable] " Honnappa Nagarahalli
2018-10-08 10:01 ` Ola Liljedahl
2018-10-27 14:17 ` Thomas Monjalon
[not found] <1541157688-40012-1-git-send-email-gavin.hu@arm.com>
[not found] ` <1541066031-29125-1-git-send-email-gavin.hu@arm.com>
[not found] ` <1540981587-88590-1-git-send-email-gavin.hu@arm.com>
[not found] ` <1540956945-211373-1-git-send-email-gavin.hu@arm.com>
2018-10-31 10:26 ` [dpdk-stable] [PATCH v3 1/2] ring: synchronize the load and store of the tail Gavin Hu
2018-10-31 22:07 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2018-11-01 9:56 ` Gavin Hu (Arm Technology China)
2018-10-31 10:26 ` [dpdk-stable] [PATCH v3 2/2] ring: move the atomic load of head above the loop Gavin Hu
2018-11-01 9:53 ` [dpdk-stable] [PATCH v4 1/2] ring: synchronize the load and store of the tail Gavin Hu
2018-11-01 9:53 ` [dpdk-stable] [PATCH v4 2/2] ring: move the atomic load of head above the loop Gavin Hu
2018-11-01 17:26 ` Stephen Hemminger
2018-11-02 0:53 ` Gavin Hu (Arm Technology China)
2018-11-02 4:30 ` Honnappa Nagarahalli
2018-11-02 7:15 ` Gavin Hu (Arm Technology China)
2018-11-02 9:36 ` Thomas Monjalon
2018-11-02 11:23 ` Gavin Hu (Arm Technology China)
2018-11-02 11:21 ` [dpdk-stable] [PATCH v5 1/2] ring: synchronize the load and store of the tail Gavin Hu
2018-11-05 9:30 ` Olivier Matz
2018-11-02 11:21 ` [dpdk-stable] [PATCH v5 2/2] ring: move the atomic load of head above the loop Gavin Hu
2018-11-02 11:43 ` Bruce Richardson
2018-11-03 1:19 ` Gavin Hu (Arm Technology China)
2018-11-03 9:34 ` Honnappa Nagarahalli
2018-11-05 13:17 ` Thomas Monjalon
2018-11-05 13:41 ` Jerin Jacob
2018-11-05 9:44 ` Olivier Matz
2018-11-05 13:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0701MB239463577089E46983B2371CE1C80@HE1PR0701MB2394.eurprd07.prod.outlook.com \
--to=mattias.ronnblom@ericsson.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ola.Liljedahl@arm.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).