DPDK patches and discussions
 help / color / mirror / Atom feed

From: Phil Yang <Phil.Yang@arm.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	"dev-bounces@dpdk.org" <dev-bounces@dpdk.org>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] test/link_bonding: disable HW CRC strip by default.
Date: Wed, 4 Jul 2018 01:33:11 +0000	[thread overview]
Message-ID: <HE1PR08MB0922A23DC632E9D64C3DC33BE9410@HE1PR08MB0922.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <a976ea51-0820-09c7-4891-2f599d60509d@intel.com>

Hi Ferruh,

Thanks for you patch.

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, July 2, 2018 6:00 PM
> To: dev-bounces@dpdk.org; dev@dpdk.org
> Cc: nd <nd@arm.com>; Phil Yang <Phil.Yang@arm.com>
> Subject: Re: [dpdk-dev] [PATCH 1/2] test/link_bonding: disable HW CRC strip by
> default.
> 
> On 7/2/2018 9:26 AM, dev-bounces@dpdk.org wrote:
> > Since the tested virtual device has no capacity of HW CRC offload,
> > disable it for the link bonding test by default. Otherwise, it will
> > cause test unexpected failure.
> >
> > Fixes: b219c8c("test: enable HW CRC strip by default")
> >
> > Signed-off-by: Phil Yang <phil.yang@arm.com>
> 
> Hi Phil,
> 
> There is a patch to add DEV_RX_OFFLOAD_CRC_STRIP to virtual devices [1] and
> there is another under development to remove old offload API [2], those both
> looks like can replace your patch when merged.
> 
> [1]: [on next-net] d8b0cfa797d8 ("ethdev: add new offload flag to keep CRC")

"And DEV_RX_OFFLOAD_CRC_STRIP has been added to virtual drivers since
they don't use CRC at all, when an application requires this offload
virtual PMDs should not return error."

I think you have ignored virtual_pmd driver. Since test_link_bonding use test/virtual_pmd for the testing device. 
I unstreamed a patch for this defect. Please review it.
http://patchwork.dpdk.org/patch/42197/ 

> [2]: https://patches.dpdk.org/patch/40956/

Thanks,
Phil Yang

     prev parent reply	other threads:[~2018-07-04  1:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02  8:26 Phil Yang
2018-07-02  8:26 ` [dpdk-dev] [PATCH 2/2] test/link_bonding_rssconf: " Phil Yang
2018-07-02 10:00 ` [dpdk-dev] [PATCH 1/2] test/link_bonding: " Ferruh Yigit
2018-07-04  1:33   ` Phil Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HE1PR08MB0922A23DC632E9D64C3DC33BE9410@HE1PR08MB0922.eurprd08.prod.outlook.com \
    --to=phil.yang@arm.com \
    --cc=dev-bounces@dpdk.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).