From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"Ferruh Yigit" <ferruh.yigit@amd.com>,
"Slava Ovsiienko" <viacheslavo@nvidia.com>,
"Ori Kam" <orika@nvidia.com>,
"Suanming Mou" <suanmingm@nvidia.com>,
"Matan Azrad" <matan@nvidia.com>,
"Dmitry Kozlyuk" <dmitry.kozliuk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"dkozlyuk@nvidia.com" <dkozlyuk@nvidia.com>
Subject: RE: [PATCH v2 6/8] common/mlx5: fix calloc parameters
Date: Fri, 26 Jan 2024 10:12:23 +0000 [thread overview]
Message-ID: <IA1PR12MB8311192CDB856CC81EFC4771A4792@IA1PR12MB8311.namprd12.prod.outlook.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F198@smartserver.smartshare.dk>
> -----Original Message-----
> From: Morten Brørup <mb@smartsharesystems.com>
> Sent: Wednesday, January 24, 2024 20:01
> To: Ferruh Yigit <ferruh.yigit@amd.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori
> Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Matan
> Azrad <matan@nvidia.com>; Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Cc: dev@dpdk.org; stable@dpdk.org; dkozlyuk@nvidia.com
> Subject: RE: [PATCH v2 6/8] common/mlx5: fix calloc parameters
>
> > From: Ferruh Yigit [mailto:ferruh.yigit@amd.com]
> > Sent: Wednesday, 24 January 2024 19.54
> >
> > gcc [1] generates warning [2] about calloc usage, because calloc
> > parameter order is wrong, fixing it by replacing parameters.
> >
> > [1]
> > gcc (GCC) 14.0.1 20240124 (experimental)
> >
> > [2]
> > Compiling C object .../common_mlx5_mlx5_common_mr.c.o
> > .../mlx5/mlx5_common_mr.c: In function ‘mlx5_mempool_get_chunks’:
> > .../common/mlx5/mlx5_common_mr.c:1384:29:
> > warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier
> > argument and not in the later argument [-Wcalloc-transposed-args]
> > 1384 | *out = calloc(sizeof(**out), n);
> > | ^
> >
> > Fixes: 7297d2cdecce ("common/mlx5: fix external memory pool
> > registration")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > ---
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
next prev parent reply other threads:[~2024-01-26 10:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 13:08 [PATCH 1/2] pipeline: " Ferruh Yigit
2023-11-02 13:08 ` [PATCH 2/2] net/nfp: " Ferruh Yigit
2023-11-03 1:26 ` Chaoyong He
2023-11-06 14:26 ` [PATCH 1/2] pipeline: " Dumitrescu, Cristian
2024-01-24 18:53 ` [PATCH v2 1/8] " Ferruh Yigit
2024-01-24 18:53 ` [PATCH v2 2/8] net/nfp: " Ferruh Yigit
2024-01-24 19:01 ` Morten Brørup
2024-01-24 18:54 ` [PATCH v2 3/8] rawdev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:34 ` fengchengwen
2024-01-25 3:39 ` Hemant Agrawal
2024-01-24 18:54 ` [PATCH v2 4/8] eventdev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:34 ` fengchengwen
2024-01-24 18:54 ` [PATCH v2 5/8] dmadev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:35 ` fengchengwen
2024-01-24 18:54 ` [PATCH v2 6/8] common/mlx5: " Ferruh Yigit
2024-01-24 19:01 ` Morten Brørup
2024-01-26 10:12 ` Dariusz Sosnowski [this message]
2024-01-24 18:54 ` [PATCH v2 7/8] net/bnx2x: " Ferruh Yigit
2024-01-24 19:01 ` Morten Brørup
2024-01-24 18:54 ` [PATCH v2 8/8] net/sfc: " Ferruh Yigit
2024-01-24 19:02 ` Morten Brørup
2024-01-25 7:10 ` Andrew Rybchenko
2024-01-24 19:00 ` [PATCH v2 1/8] pipeline: " Morten Brørup
2024-02-18 16:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR12MB8311192CDB856CC81EFC4771A4792@IA1PR12MB8311.namprd12.prod.outlook.com \
--to=dsosnowski@nvidia.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@nvidia.com \
--cc=dmitry.kozliuk@gmail.com \
--cc=ferruh.yigit@amd.com \
--cc=matan@nvidia.com \
--cc=mb@smartsharesystems.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).