From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Subject: RE: [PATCH v5 07/10] net/mlx5: replace zero length array with flex array
Date: Tue, 23 Jan 2024 11:18:55 +0000 [thread overview]
Message-ID: <IA1PR12MB83115B7E84B09983E7F3F3F4A4742@IA1PR12MB8311.namprd12.prod.outlook.com> (raw)
In-Reply-To: <2240162.72vocr9iq0@thomas>
From: Thomas Monjalon <thomas@monjalon.net>
Sent: Tuesday, January 23, 2024 11:28
> 23/01/2024 10:44, Thomas Monjalon:
> > 29/11/2023 03:39, Stephen Hemminger:
> > > --- a/drivers/net/mlx5/mlx5_tx.h
> > > +++ b/drivers/net/mlx5/mlx5_tx.h
> > > @@ -171,11 +171,12 @@ struct mlx5_txq_data {
> > > struct mlx5_txq_stats stats; /* TX queue counters. */
> > > struct mlx5_txq_stats stats_reset; /* stats on last reset. */
> > > struct mlx5_uar_data uar_data;
> > > - struct rte_mbuf *elts[0];
> > > + struct rte_mbuf *elts[];
> > > /* Storage for queued packets, must be the last field. */ }
> > > __rte_cache_aligned;
> > >
> > > /* TX queue control descriptor. */
> > > +__extension__
> > > struct mlx5_txq_ctrl {
> >
> > struct mlx5_txq_data is included at the end of struct mlx5_txq_ctrl I
> > don't understand why we need to declare an extension here.
>
> If I remove __extension__:
> error: invalid use of structure with flexible array member [-Werror=pedantic]
>
> Is it a problem only in pedantic mode?
Yes, because this usage is nonstandard. Using a struct which has a flexible array member, inside another struct is a compiler extension.
Best regards,
Dariusz Sosnowski
next prev parent reply other threads:[~2024-01-23 11:19 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 21:51 [PATCH 0/7] replace zero length arrays Stephen Hemminger
2023-01-13 21:51 ` [PATCH 1/7] member: replace zero length array with flex array Stephen Hemminger
2023-01-14 0:19 ` Tyler Retzlaff
2023-01-14 0:36 ` Stephen Hemminger
2023-01-14 0:42 ` Tyler Retzlaff
2023-01-13 21:52 ` [PATCH 2/7] cryptodev: " Stephen Hemminger
2023-01-13 21:52 ` [PATCH 3/7] security: " Stephen Hemminger
2023-01-13 21:52 ` [PATCH 4/7] mlx5: " Stephen Hemminger
2023-01-14 17:08 ` Stephen Hemminger
2023-03-06 13:29 ` Slava Ovsiienko
2023-01-13 21:52 ` [PATCH 5/7] nfp: " Stephen Hemminger
2023-01-15 15:22 ` Niklas Söderlund
2023-01-13 21:52 ` [PATCH 6/7] enic: " Stephen Hemminger
2023-01-14 1:12 ` John Daley (johndale)
2023-01-13 21:52 ` [PATCH 7/7] dpaax: " Stephen Hemminger
2023-01-15 11:59 ` Hemant Agrawal
2023-01-14 10:43 ` [PATCH 0/7] replace zero length arrays Morten Brørup
2023-11-17 4:03 ` [PATCH v2 00/10] " Stephen Hemminger
2023-11-17 4:03 ` [PATCH v2 01/10] member: replace zero length array with flex array Stephen Hemminger
2023-11-17 4:17 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 02/10] cryptodev: " Stephen Hemminger
2023-11-17 4:18 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 03/10] security: " Stephen Hemminger
2023-11-17 4:18 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 04/10] pipeline: " Stephen Hemminger
2023-11-17 4:19 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 05/10] net/nfp: " Stephen Hemminger
2023-11-17 4:19 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 06/10] net/enic: " Stephen Hemminger
2023-11-17 4:20 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 07/10] net/mlx5: " Stephen Hemminger
2023-11-17 4:20 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 08/10] pdcp: " Stephen Hemminger
2023-11-17 4:20 ` Tyler Retzlaff
2023-11-17 5:28 ` [EXT] " Anoob Joseph
2023-11-17 4:03 ` [PATCH v2 09/10] net/cpfl: " Stephen Hemminger
2023-11-17 4:20 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 10/10] common/dpaxx: " Stephen Hemminger
2023-11-17 4:21 ` Tyler Retzlaff
2023-11-17 8:31 ` [PATCH v2 00/10] replace zero length arrays Morten Brørup
2023-11-17 16:18 ` Stephen Hemminger
2023-11-17 19:59 ` Tyler Retzlaff
2023-11-20 17:06 ` [PATCH v4 00/10] Replace " Stephen Hemminger
2023-11-20 17:06 ` [PATCH v4 01/10] member: replace zero length array with flex array Stephen Hemminger
2023-11-20 17:06 ` [PATCH v4 02/10] cryptodev: " Stephen Hemminger
2023-11-21 5:29 ` [EXT] " Anoob Joseph
2023-11-20 17:06 ` [PATCH v4 03/10] security: " Stephen Hemminger
2023-11-21 5:30 ` [EXT] " Anoob Joseph
2023-11-20 17:06 ` [PATCH v4 04/10] pipeline: " Stephen Hemminger
2023-11-20 17:07 ` [PATCH v4 05/10] net/nfp: " Stephen Hemminger
2023-11-21 1:14 ` Chaoyong He
2023-11-20 17:07 ` [PATCH v4 06/10] net/enic: " Stephen Hemminger
2023-11-20 17:07 ` [PATCH v4 07/10] net/mlx5: " Stephen Hemminger
2023-11-23 17:54 ` Dariusz Sosnowski
2023-11-20 17:07 ` [PATCH v4 08/10] pdcp: " Stephen Hemminger
2023-11-20 17:07 ` [PATCH v4 09/10] net/cpfl: " Stephen Hemminger
2023-11-20 17:07 ` [PATCH v4 10/10] common/dpaxx: remove zero length array Stephen Hemminger
2023-11-21 10:49 ` Hemant Agrawal
2023-11-21 16:46 ` Stephen Hemminger
2023-11-21 17:01 ` Stephen Hemminger
2023-11-21 17:18 ` Tyler Retzlaff
2023-11-22 7:23 ` Hemant Agrawal
2023-11-23 1:43 ` Stephen Hemminger
2023-11-23 19:18 ` Stephen Hemminger
2023-11-28 6:43 ` Hemant Agrawal
2023-11-21 7:26 ` [PATCH v4 00/10] Replace zero length arrays Morten Brørup
2023-11-21 8:30 ` fengchengwen
2023-11-29 2:39 ` [PATCH v5 " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 01/10] member: replace zero length array with flex array Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 02/10] cryptodev: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 03/10] security: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 04/10] pipeline: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 05/10] net/nfp: " Stephen Hemminger
2023-11-30 1:21 ` Chaoyong He
2023-11-29 2:39 ` [PATCH v5 06/10] net/enic: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 07/10] net/mlx5: " Stephen Hemminger
2024-01-23 9:44 ` Thomas Monjalon
2024-01-23 10:28 ` Thomas Monjalon
2024-01-23 11:18 ` Dariusz Sosnowski [this message]
2023-11-29 2:39 ` [PATCH v5 08/10] pdcp: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 09/10] net/cpfl: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 10/10] common/dpaxx: replace zero length array Stephen Hemminger
2024-01-23 9:42 ` Thomas Monjalon
2024-01-23 10:48 ` [PATCH v5 00/10] Replace zero length arrays Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR12MB83115B7E84B09983E7F3F3F4A4742@IA1PR12MB8311.namprd12.prod.outlook.com \
--to=dsosnowski@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).