From: Dave Burley <dave.burley@accelercomm.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
Aidan Goddard <aidan.goddard@accelercomm.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/7] app/bbdev: add explicit check for counters
Date: Tue, 15 Sep 2020 10:02:48 +0000 [thread overview]
Message-ID: <LOYP265MB21744CE81543C55866A01884EB200@LOYP265MB2174.GBRP265.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <1597795557-39612-3-git-send-email-nicolas.chautru@intel.com>
Acked-by: Dave Burley <dave.burley@accelercomm.com>
From: dev <dev-bounces@dpdk.org> on behalf of Nicolas Chautru <nicolas.chautru@intel.com>
Sent: 19 August 2020 01:05
To: dev@dpdk.org <dev@dpdk.org>; akhil.goyal@nxp.com <akhil.goyal@nxp.com>
Cc: bruce.richardson@intel.com <bruce.richardson@intel.com>; Nicolas Chautru <nicolas.chautru@intel.com>
Subject: [dpdk-dev] [PATCH v3 2/7] app/bbdev: add explicit check for counters
Adding explicit check in ut that the stats counters
have the expected values. Was missing for coverage.
Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
app/test-bbdev/test_bbdev_perf.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 1319afd..b0b6f18 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -4769,6 +4769,23 @@ typedef int (test_case_function)(struct active_device *ad,
(double)(time_st.deq_max_time * 1000000) /
rte_get_tsc_hz());
+ struct rte_bbdev_stats stats = {0};
+ get_bbdev_queue_stats(ad->dev_id, queue_id, &stats);
+ if (op_type != RTE_BBDEV_OP_LDPC_DEC) {
+ TEST_ASSERT_SUCCESS(stats.enqueued_count != num_to_process,
+ "Mismatch in enqueue count %10"PRIu64" %d",
+ stats.enqueued_count, num_to_process);
+ TEST_ASSERT_SUCCESS(stats.dequeued_count != num_to_process,
+ "Mismatch in dequeue count %10"PRIu64" %d",
+ stats.dequeued_count, num_to_process);
+ }
+ TEST_ASSERT_SUCCESS(stats.enqueue_err_count != 0,
+ "Enqueue count Error %10"PRIu64"",
+ stats.enqueue_err_count);
+ TEST_ASSERT_SUCCESS(stats.dequeue_err_count != 0,
+ "Dequeue count Error (%10"PRIu64"",
+ stats.dequeue_err_count);
+
return TEST_SUCCESS;
#endif
}
--
1.8.3.1
next prev parent reply other threads:[~2020-09-15 10:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 0:05 [dpdk-dev] [PATCH v3 0/7] BBDEV test updates Nicolas Chautru
2020-08-19 0:05 ` [dpdk-dev] [PATCH v3 1/7] app/bbdev: add explicit ut for latency vs validation Nicolas Chautru
2020-09-15 9:49 ` Aidan Goddard
2020-09-15 10:01 ` Dave Burley
2020-08-19 0:05 ` [dpdk-dev] [PATCH v3 2/7] app/bbdev: add explicit check for counters Nicolas Chautru
2020-09-15 9:53 ` Aidan Goddard
2020-09-15 10:02 ` Dave Burley [this message]
2020-08-19 0:05 ` [dpdk-dev] [PATCH v3 3/7] app/bbdev: include explicit HARQ preloading Nicolas Chautru
2020-08-19 0:05 ` [dpdk-dev] [PATCH v3 4/7] app/bbdev: define wait for offload Nicolas Chautru
2020-08-19 0:05 ` [dpdk-dev] [PATCH v3 5/7] app/bbdev: skip bler ut when compression is used Nicolas Chautru
2020-09-15 9:55 ` Aidan Goddard
2020-09-15 10:03 ` Dave Burley
2020-08-19 0:05 ` [dpdk-dev] [PATCH v3 6/7] app/bbdev: reduce duration of throughput test Nicolas Chautru
2020-08-19 0:05 ` [dpdk-dev] [PATCH v3 7/7] app/bbdev: update offload test to dequeue full ring Nicolas Chautru
2020-09-15 9:55 ` Aidan Goddard
2020-09-15 10:05 ` Dave Burley
2020-10-07 0:13 ` [dpdk-dev] [PATCH v3 0/7] BBDEV test updates Chautru, Nicolas
2020-10-07 6:37 ` Akhil Goyal
2020-10-07 16:00 ` Chautru, Nicolas
2020-10-20 16:08 ` Chautru, Nicolas
2020-09-15 2:56 [dpdk-dev] [PATCH v3 2/7] app/bbdev: add explicit check for counters Liu, Tianjiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=LOYP265MB21744CE81543C55866A01884EB200@LOYP265MB2174.GBRP265.PROD.OUTLOOK.COM \
--to=dave.burley@accelercomm.com \
--cc=aidan.goddard@accelercomm.com \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nicolas.chautru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).