DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Su, Simei" <simei.su@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	 "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Wu, Wenjun1" <wenjun1.wu@intel.com>
Subject: RE: [PATCH v3] common/idpf: refactor single queue Tx function
Date: Wed, 13 Sep 2023 06:07:11 +0000	[thread overview]
Message-ID: <LV2PR11MB59970F45180FCD1405A1AB85F7F0A@LV2PR11MB5997.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230908102827.2256297-1-simei.su@intel.com>



> -----Original Message-----
> From: Su, Simei <simei.su@intel.com>
> Sent: Friday, September 8, 2023 6:28 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Wu, Wenjun1 <wenjun1.wu@intel.com>; Su, Simei
> <simei.su@intel.com>
> Subject: [PATCH v3] common/idpf: refactor single queue Tx function
> 
> This patch replaces flex Tx descriptor with base Tx descriptor to align with kernel
> driver practice.
> 
> Signed-off-by: Simei Su <simei.su@intel.com>
> ---
> v3:
> * Change context TSO descriptor from base mode to flex mode.
> 
> v2:
> * Refine commit title and commit log.
> * Remove redundant definition.
> * Modify base mode context TSO descriptor.
> 
>  drivers/common/idpf/idpf_common_rxtx.c        | 39 +++++++++----------
>  drivers/common/idpf/idpf_common_rxtx.h        |  2 +-
>  drivers/common/idpf/idpf_common_rxtx_avx512.c | 37 +++++++++---------
>  drivers/net/idpf/idpf_rxtx.c                  |  2 +-
>  4 files changed, 39 insertions(+), 41 deletions(-)
> 


> diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c index
> 3e3d81ca6d..64f2235580 100644
> --- a/drivers/net/idpf/idpf_rxtx.c
> +++ b/drivers/net/idpf/idpf_rxtx.c
> @@ -74,7 +74,7 @@ idpf_dma_zone_reserve(struct rte_eth_dev *dev, uint16_t
> queue_idx,
>  			ring_size = RTE_ALIGN(len * sizeof(struct
> idpf_flex_tx_sched_desc),
>  					      IDPF_DMA_MEM_ALIGN);
>  		else
> -			ring_size = RTE_ALIGN(len * sizeof(struct
> idpf_flex_tx_desc),
> +			ring_size = RTE_ALIGN(len * sizeof(struct
> idpf_base_tx_desc),

Check if idpf_flex_tx_desc is used in cpfl PMD.

>  					      IDPF_DMA_MEM_ALIGN);
>  		rte_memcpy(ring_name, "idpf Tx ring", sizeof("idpf Tx ring"));
>  		break;
> --
> 2.25.1


  parent reply	other threads:[~2023-09-13  6:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25  7:21 [PATCH] common/idpf: rework " Simei Su
2023-08-25  7:48 ` Wu, Wenjun1
2023-08-25  8:14 ` Zhang, Qi Z
2023-09-04  7:02 ` [PATCH v2] common/idpf: refactor " Simei Su
2023-09-08 10:28   ` [PATCH v3] " Simei Su
2023-09-13  5:57     ` Wu, Wenjun1
2023-09-13  7:45       ` Zhang, Qi Z
2023-09-14  1:47         ` Zhang, Qi Z
2023-09-13  6:07     ` Xing, Beilei [this message]
2023-09-14  1:50     ` [PATCH v4 0/3] refactor single queue Tx data path Simei Su
2023-09-14  1:50       ` [PATCH v4 1/3] common/idpf: " Simei Su
2023-09-14  1:50       ` [PATCH v4 2/3] net/idpf: refine Tx queue setup Simei Su
2023-09-14  1:50       ` [PATCH v4 3/3] net/cpfl: " Simei Su
2023-09-14  1:54       ` [PATCH v4 0/3] refactor single queue Tx data path Xing, Beilei
2023-09-14  6:37       ` [PATCH v5] common/idpf: " Simei Su
2023-09-14 11:08         ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=LV2PR11MB59970F45180FCD1405A1AB85F7F0A@LV2PR11MB5997.namprd11.prod.outlook.com \
    --to=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=simei.su@intel.com \
    --cc=wenjun1.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).