From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Zhang, Yuying" <yuying.zhang@intel.com>,
"Zhang, Yuying" <yuying.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: RE: [PATCH v1] net/cpfl: fix incorrect status calculation
Date: Mon, 23 Oct 2023 09:01:21 +0000 [thread overview]
Message-ID: <LV2PR11MB5997F4108B1F6D3BD275114FF7D8A@LV2PR11MB5997.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230822011710.20492-1-yuying.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Tuesday, August 22, 2023 9:17 AM
> To: Zhang, Yuying <yuying.zhang@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: [PATCH v1] net/cpfl: fix incorrect status calculation
>
> From: Yuying Zhang <yuying.zhang@intel.com>
>
> Fix the incorrect ingress packet number calculation.
>
> Fixes: e3289d8fb63f ("net/cpfl: support basic statistics")
>
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
> drivers/net/cpfl/cpfl_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c
> index c4ca9343c3..8c02c84c5b 100644
> --- a/drivers/net/cpfl/cpfl_ethdev.c
> +++ b/drivers/net/cpfl/cpfl_ethdev.c
> @@ -304,7 +304,7 @@ cpfl_dev_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
>
> idpf_vport_stats_update(&vport->eth_stats_offset, pstats);
> stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
> - pstats->rx_broadcast - pstats->rx_discards;
> + pstats->rx_broadcast;
> stats->opackets = pstats->tx_broadcast + pstats->tx_multicast
> +
> pstats->tx_unicast;
> stats->imissed = pstats->rx_discards;
> --
> 2.25.1
Acked-by: Beilei Xing <beilei.xing@intel.com>
next prev parent reply other threads:[~2023-10-23 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 1:17 Zhang, Yuying
2023-10-23 9:01 ` Xing, Beilei [this message]
2023-10-24 5:26 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=LV2PR11MB5997F4108B1F6D3BD275114FF7D8A@LV2PR11MB5997.namprd11.prod.outlook.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).