From: Raslan Darawsheh <rasland@nvidia.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/mlx5: fix offset field size in conntrack action
Date: Tue, 21 Nov 2023 15:11:05 +0000 [thread overview]
Message-ID: <MN0PR12MB60564B22A6587FE361914A82CFBBA@MN0PR12MB6056.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231120082458.9020-1-dsosnowski@nvidia.com>
Hi,
> -----Original Message-----
> From: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Sent: Monday, November 20, 2023 10:25 AM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou
> <suanmingm@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix offset field size in conntrack action
>
> In mlx5 PMD, struct mlx5_aso_ct_action represents a single ASO CT object
> inside a ASO CT bulk, which is used to implement conntrack flow action.
> offset field, which is 16 bits wide, in this struct represents
> an offset of the given object inside a bulk.
>
> When SW Steering flow engine is used, ASO CT bulks are allocated on
> demand, each having 64 objects. In this case offset field can fit any
> valid object offset.
>
> When HW Steering flow engine is used, a single ASO CT bulk is allocated
> during flow engine configuration. Since HW supports bulks bigger
> than 2^16 this offset field is too small to fit all valid values.
> This causes some ASO CT objects to be incorrectly reused on multiple
> connections, when more than 2^16 conntrack flow actions are used.
>
> This patch fixes this behavior. offset field size is increased
> to 32 bits.
>
> Fixes: 463170a7c934 ("net/mlx5: support connection tracking with HWS")
> Cc: suanmingm@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
prev parent reply other threads:[~2023-11-21 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 8:24 Dariusz Sosnowski
2023-11-21 15:11 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR12MB60564B22A6587FE361914A82CFBBA@MN0PR12MB6056.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).