From: Raslan Darawsheh <rasland@nvidia.com>
To: Michael Baum <michaelba@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Gregory Etelson <getelson@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] net/mlx5: fix index choosing in TAG modification
Date: Sun, 7 Jan 2024 12:36:16 +0000 [thread overview]
Message-ID: <MN0PR12MB605677C488AFAE865CCF1D50CF642@MN0PR12MB6056.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231127160102.450506-1-michaelba@nvidia.com>
Hi,
> -----Original Message-----
> From: Michael Baum <michaelba@nvidia.com>
> Sent: Monday, November 27, 2023 6:01 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Gregory
> Etelson <getelson@nvidia.com>; stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix index choosing in TAG modification
>
> When MPLS modification support was added [1], the "tag_index" field was
> added into "rte_flow_action_modify_data" structure.
> As part of this change, the "RTE_FLOW_FIELD_TAG" type moved to use it for
> tag array instead of using "level" field.
> Using "level" is still supported for backwards compatibility when "tag_index"
> field is zero.
>
> The "mlx5_flow_field_id_to_modify_info()" function calls
> "flow_hw_get_reg_id()" function with "level" without checking first whether
> "tag_index" field is valid.
>
> This patch calls first to "flow_tag_index_get()" function to get the index before
> sending it to "flow_hw_get_reg_id()" function.
>
> [1] commit c23626f27b09 ("ethdev: add MPLS header modification")
>
> Fixes: 04e740e69512 ("net/mlx5: separate registers usage per port")
> Cc: getelson@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
> ---
> v2: fix the commit reference format.
>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
prev parent reply other threads:[~2024-01-07 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 14:50 [PATCH] " Michael Baum
2023-11-27 16:01 ` [PATCH v2] " Michael Baum
2024-01-07 12:36 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR12MB605677C488AFAE865CCF1D50CF642@MN0PR12MB6056.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).