From: Anoob Joseph <anoobj@marvell.com>
To: Akhil Goyal <akhil.goyal@nxp.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"Jerin Jacob Kollanukkaran" <jerinj@marvell.com>,
'Thomas Monjalon' <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default
Date: Wed, 16 Oct 2019 04:18:52 +0000 [thread overview]
Message-ID: <MN2PR18MB28771AA7890F26DFB2762845DF920@MN2PR18MB2877.namprd18.prod.outlook.com> (raw)
In-Reply-To: <VE1PR04MB66394E65C755CF041E9F6067E6970@VE1PR04MB6639.eurprd04.prod.outlook.com>
Hi Akhil,
Marvell is NOT OK with this change in this cycle. The library is still emerging and the boundary between ipsec-secgw and lib ipsec still hasn't emerged clearly. Moreover, lib_ipsec mode isn't even working with the default conf (I believe the fix for this still in discussion. The issue was reported by a Marvell engineer some time back). There are questionable features getting pushed, for which Marvell's concerns were subdued.
I would expect this taken up after lib ipsec is found stable for atleast one release cycle.
As for the performance, we found 2-3% drop with the lib ipsec in the last release (lookaside crypto mode). Yet to try out with latest codebase. With some of the recent submissions, I expect an even higher performance hit. Also, eventmode ipsec-secgw (already submitted RFC) is using non lib ipsec mode. We don't have plans to move that to lib ipsec mode until lib ipsec is made stable.
Thanks,
Anoob
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Friday, October 11, 2019 6:10 PM
> To: Bernard Iremonger <bernard.iremonger@intel.com>; dev@dpdk.org;
> konstantin.ananyev@intel.com; Anoob Joseph <anoobj@marvell.com>;
> Jerin Jacob Kollanukkaran <jerinj@marvell.com>; 'Thomas Monjalon'
> <thomas@monjalon.net>
> Subject: [EXT] RE: [PATCH v2 0/3] examples/ipsec-secgw: set default
>
> External Email
>
> ----------------------------------------------------------------------
> Hi All,
>
> This patchset would need ack from more vendors as it will impact user
> experience on a key example application which is normally demonstrated to
> customers.
>
> IPSec library is still evolving and there are new functionality added every
> release.
> Atleast from NXP side we are not OK with this change.
>
> I would hold this patch till RC2 atleast.
>
> Regards,
> Akhil
>
> > -----Original Message-----
> > From: Bernard Iremonger <bernard.iremonger@intel.com>
> > Sent: Tuesday, October 1, 2019 8:48 PM
> > To: dev@dpdk.org; konstantin.ananyev@intel.com; Akhil Goyal
> > <akhil.goyal@nxp.com>
> > Cc: Bernard Iremonger <bernard.iremonger@intel.com>
> > Subject: [PATCH v2 0/3] examples/ipsec-secgw: set default
> >
> > This patch set, sets the default code path in the ipsec-secgw
> > application to use the librte_ipsec.
> > The *_old test scripts have been modified to use the legacy code path.
> >
> > Changes in v2:
> > -------------
> > The error messages for the -l option have been updated.
> > The pktest.sh script has been updated to drop the -l option.
> >
> > Bernard Iremonger (3):
> > examples/ipsec-secgw: set default to IPsec library mode
> > examples/ipsec-secgw: add -l 0 parameter to old scripts
> > examples/ipsec-secgw: update pktest.sh script
> >
> > doc/guides/rel_notes/release_19_11.rst | 8 ++++
> > doc/guides/sample_app_ug/ipsec_secgw.rst | 6 ++-
> > examples/ipsec-secgw/ipsec-secgw.c | 46 ++++++++++++++-------
> -
> > examples/ipsec-secgw/test/pkttest.sh | 1 -
> > .../ipsec-secgw/test/trs_3descbc_sha1_old_defs.sh | 2 +-
> > .../ipsec-secgw/test/trs_aescbc_sha1_old_defs.sh | 2 +-
> > .../ipsec-secgw/test/trs_aesctr_sha1_old_defs.sh | 2 +-
> > .../test/trs_aesgcm_inline_crypto_old_defs.sh | 2 +-
> > examples/ipsec-secgw/test/trs_aesgcm_old_defs.sh | 2 +-
> > .../ipsec-secgw/test/tun_3descbc_sha1_old_defs.sh | 2 +-
> > .../ipsec-secgw/test/tun_aescbc_sha1_old_defs.sh | 2 +-
> > .../ipsec-secgw/test/tun_aesctr_sha1_old_defs.sh | 2 +-
> > .../test/tun_aesgcm_inline_crypto_old_defs.sh | 2 +-
> > examples/ipsec-secgw/test/tun_aesgcm_old_defs.sh | 2 +-
> > 14 files changed, 52 insertions(+), 29 deletions(-)
> >
> > --
> > 2.7.4
next prev parent reply other threads:[~2019-10-16 4:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 8:59 [dpdk-dev] [PATCH 0/2] " Bernard Iremonger
2019-08-29 8:59 ` [dpdk-dev] [PATCH 1/2] examples/ipsec-secgw: set default to IPsec library mode Bernard Iremonger
2019-09-26 13:47 ` Ananyev, Konstantin
2019-09-26 13:51 ` Iremonger, Bernard
2019-08-29 8:59 ` [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add -l 0 parameter to old scripts Bernard Iremonger
2019-09-26 13:43 ` Ananyev, Konstantin
2019-09-26 13:46 ` Iremonger, Bernard
2019-10-01 15:17 ` [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default Bernard Iremonger
2019-10-01 17:30 ` Ananyev, Konstantin
2019-10-02 8:59 ` Iremonger, Bernard
2019-10-02 9:11 ` Ananyev, Konstantin
2019-10-11 12:40 ` Akhil Goyal
2019-10-11 15:13 ` Iremonger, Bernard
2019-10-11 15:23 ` Thomas Monjalon
2019-10-15 6:42 ` Akhil Goyal
2019-10-15 8:54 ` Iremonger, Bernard
2019-10-15 15:05 ` Akhil Goyal
2019-10-16 10:44 ` Ananyev, Konstantin
2019-10-30 9:29 ` Iremonger, Bernard
2019-11-01 13:19 ` Akhil Goyal
2019-11-04 15:24 ` Ananyev, Konstantin
2019-11-05 8:01 ` Akhil Goyal
2019-11-05 9:10 ` Ananyev, Konstantin
2019-11-06 13:55 ` Anoob Joseph
2019-11-18 13:03 ` Ananyev, Konstantin
2019-10-16 4:18 ` Anoob Joseph [this message]
2019-10-01 15:17 ` [dpdk-dev] [PATCH v2 1/3] examples/ipsec-secgw: set default to IPsec library mode Bernard Iremonger
2019-10-14 13:53 ` Nicolau, Radu
2019-10-01 15:17 ` [dpdk-dev] [PATCH v2 2/3] examples/ipsec-secgw: add -l 0 parameter to old scripts Bernard Iremonger
2019-10-01 17:28 ` Ananyev, Konstantin
2019-10-14 13:55 ` Nicolau, Radu
2019-10-01 15:18 ` [dpdk-dev] [PATCH v2 3/3] examples/ipsec-secgw: update pktest.sh script Bernard Iremonger
2019-10-01 17:29 ` Ananyev, Konstantin
2019-10-14 13:56 ` Nicolau, Radu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR18MB28771AA7890F26DFB2762845DF920@MN2PR18MB2877.namprd18.prod.outlook.com \
--to=anoobj@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).