From: Ori Kam <orika@nvidia.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>,
Bing Zhao <bingz@nvidia.com>
Subject: RE: [PATCH 00/11] net/mlx5: flow insertion performance improvements
Date: Thu, 29 Feb 2024 08:52:34 +0000 [thread overview]
Message-ID: <MW2PR12MB466610DB7370CDFAF210A9FED65F2@MW2PR12MB4666.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240228170046.176600-1-dsosnowski@nvidia.com>
Hi Dariusz,
> -----Original Message-----
> From: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Sent: Wednesday, February 28, 2024 7:01 PM
>
> Goal of this patchset is to improve the throughput of flow insertion
> and deletion in mlx5 PMD when HW Steering flow engine is used.
>
> - Patch 1 - Use preallocated per-queue, per-actions template buffer
> for storing translated flow actions, instead of allocating and
> filling it on demand, on each flow operation.
> - Patches 2-4 - Make resource index allocation optional. This allocation
> will be skipped when it is not required by the created template table.
> - Patches 5-7 - Reduce memory footprint of the internal flow queue.
> - Patch 8 - Remove indirection between flow job and flow itself,
> by using flow as an operation container.
> - Patches 9-10 - Reduce memory footpring of flow struct by moving
> rarely used flow fields outside of the main flow struct.
> These fields will accesses only when needed.
> Also remove unneeded `zmalloc` usage.
> - Patch 11 - Remove unneeded device status check in flow create.
>
> In general all of these changes result in the following improvements
> (all numbers are averaged Kflows/sec):
>
> | | Insertion) | +% | Deletion | +% |
> |--------------|:----------:|:------:|:--------:|:-----:|
> | baseline | 6338.7 | | 9739.6 | |
> | improvements | 6978.8 | +10.1% | 10432.4 | +7.1% |
>
> The basic benchmark was run on ConnectX-6 Dx (22.40.1000),
> on the system with Intel Xeon Platinum 8380 CPU.
>
> Bing Zhao (2):
> net/mlx5: skip the unneeded resource index allocation
> net/mlx5: remove unneeded device status checking
>
> Dariusz Sosnowski (7):
> net/mlx5: allocate local DR rule action buffers
> net/mlx5: remove action params from job
> net/mlx5: remove flow pattern from job
> net/mlx5: remove updated flow from job
> net/mlx5: use flow as operation container
> net/mlx5: move rarely used flow fields outside
> net/mlx5: reuse flow fields
>
> Erez Shitrit (2):
> net/mlx5/hws: add check for matcher rule update support
> net/mlx5/hws: add check if matcher contains complex rules
>
> drivers/net/mlx5/hws/mlx5dr.h | 16 +
> drivers/net/mlx5/hws/mlx5dr_action.c | 6 +
> drivers/net/mlx5/hws/mlx5dr_action.h | 2 +
> drivers/net/mlx5/hws/mlx5dr_matcher.c | 29 +
> drivers/net/mlx5/mlx5.h | 29 +-
> drivers/net/mlx5/mlx5_flow.h | 128 ++++-
> drivers/net/mlx5/mlx5_flow_hw.c | 794 ++++++++++++++++----------
> 7 files changed, 666 insertions(+), 338 deletions(-)
>
> --
> 2.39.2
Series-acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori
next prev parent reply other threads:[~2024-02-29 8:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 17:00 Dariusz Sosnowski
2024-02-28 17:00 ` [PATCH 01/11] net/mlx5: allocate local DR rule action buffers Dariusz Sosnowski
2024-02-28 17:00 ` [PATCH 02/11] net/mlx5/hws: add check for matcher rule update support Dariusz Sosnowski
2024-02-28 17:00 ` [PATCH 03/11] net/mlx5/hws: add check if matcher contains complex rules Dariusz Sosnowski
2024-02-28 17:00 ` [PATCH 04/11] net/mlx5: skip the unneeded resource index allocation Dariusz Sosnowski
2024-02-28 17:00 ` [PATCH 05/11] net/mlx5: remove action params from job Dariusz Sosnowski
2024-02-28 17:00 ` [PATCH 06/11] net/mlx5: remove flow pattern " Dariusz Sosnowski
2024-02-28 17:00 ` [PATCH 07/11] net/mlx5: remove updated flow " Dariusz Sosnowski
2024-02-28 17:00 ` [PATCH 08/11] net/mlx5: use flow as operation container Dariusz Sosnowski
2024-02-28 17:00 ` [PATCH 09/11] net/mlx5: move rarely used flow fields outside Dariusz Sosnowski
2024-02-28 17:00 ` [PATCH 10/11] net/mlx5: reuse flow fields Dariusz Sosnowski
2024-02-28 17:00 ` [PATCH 11/11] net/mlx5: remove unneeded device status checking Dariusz Sosnowski
2024-02-29 8:52 ` Ori Kam [this message]
2024-02-29 11:51 ` [PATCH v2 00/11] net/mlx5: flow insertion performance improvements Dariusz Sosnowski
2024-02-29 11:51 ` [PATCH v2 01/11] net/mlx5: allocate local DR rule action buffers Dariusz Sosnowski
2024-02-29 11:51 ` [PATCH v2 02/11] net/mlx5/hws: add check for matcher rule update support Dariusz Sosnowski
2024-02-29 11:51 ` [PATCH v2 03/11] net/mlx5/hws: add check if matcher contains complex rules Dariusz Sosnowski
2024-02-29 11:51 ` [PATCH v2 04/11] net/mlx5: skip the unneeded resource index allocation Dariusz Sosnowski
2024-02-29 11:51 ` [PATCH v2 05/11] net/mlx5: remove action params from job Dariusz Sosnowski
2024-02-29 11:51 ` [PATCH v2 06/11] net/mlx5: remove flow pattern " Dariusz Sosnowski
2024-02-29 11:51 ` [PATCH v2 07/11] net/mlx5: remove updated flow " Dariusz Sosnowski
2024-02-29 11:51 ` [PATCH v2 08/11] net/mlx5: use flow as operation container Dariusz Sosnowski
2024-02-29 11:51 ` [PATCH v2 09/11] net/mlx5: move rarely used flow fields outside Dariusz Sosnowski
2024-02-29 11:51 ` [PATCH v2 10/11] net/mlx5: reuse flow fields Dariusz Sosnowski
2024-02-29 11:51 ` [PATCH v2 11/11] net/mlx5: remove unneeded device status checking Dariusz Sosnowski
2024-03-03 12:16 ` [PATCH v2 00/11] net/mlx5: flow insertion performance improvements Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR12MB466610DB7370CDFAF210A9FED65F2@MW2PR12MB4666.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).