From: Ori Kam <orika@nvidia.com>
To: Alexander Kozyrev <akozyrev@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: RE: [PATCH] net/mlx5: fix matcher index in case of insertion by index
Date: Tue, 18 Jul 2023 09:19:19 +0000 [thread overview]
Message-ID: <MW2PR12MB46663FC828DD986E5C4F796BD638A@MW2PR12MB4666.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230628125437.1834231-1-akozyrev@nvidia.com>
Hi Alexander,
> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Wednesday, June 28, 2023 3:55 PM
> Subject: [PATCH] net/mlx5: fix matcher index in case of insertion by index
>
> There is only one matcher in an index-based template tables.
> Pass the 0 as the matcher index, not actions template index.
>
> Fixes: adfa4b1445 ("net/mlx5: add flow rule insertion by index")
>
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_flow_hw.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_hw.c
> b/drivers/net/mlx5/mlx5_flow_hw.c
> index b5137a822a..2cf9e6ef3a 100644
> --- a/drivers/net/mlx5/mlx5_flow_hw.c
> +++ b/drivers/net/mlx5/mlx5_flow_hw.c
> @@ -2796,8 +2796,7 @@ flow_hw_async_flow_create_by_index(struct
> rte_eth_dev *dev,
> */
> if (flow_hw_actions_construct(dev, job,
> &table->ats[action_template_index],
> - action_template_index, actions,
> - rule_acts, queue, error)) {
> + 0, actions, rule_acts, queue, error)) {
> rte_errno = EINVAL;
> goto free;
> }
> --
> 2.18.2
Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori
next prev parent reply other threads:[~2023-07-18 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 12:54 Alexander Kozyrev
2023-07-18 9:19 ` Ori Kam [this message]
2023-07-18 15:02 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR12MB46663FC828DD986E5C4F796BD638A@MW2PR12MB4666.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).