From: Ori Kam <orika@nvidia.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"NBU-Contact-N?lio Laranjeiro (EXTERNAL)"
<nelio.laranjeiro@6wind.com>,
"NBU-Contact-Adrien Mazarguil (EXTERNAL)"
<adrien.mazarguil@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"nd@arm.com" <nd@arm.com>, "stable@dpdk.org" <stable@dpdk.org>,
Luca Boccassi <bluca@debian.org>
Subject: RE: [PATCH] ethdev: fix 32-bit build with GCC-13
Date: Wed, 1 Nov 2023 08:12:59 +0000 [thread overview]
Message-ID: <MW2PR12MB466642545DCF9A9E3F872058D6A7A@MW2PR12MB4666.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231101071554.1316358-1-ruifeng.wang@arm.com>
Hi
> -----Original Message-----
> From: Ruifeng Wang <ruifeng.wang@arm.com>
> Sent: Wednesday, November 1, 2023 9:16 AM
>
> aarch32 build with gcc-13.0.1 generated following warning:
>
> In function 'memcpy',
> inlined from 'rte_memcpy' at
> ../lib/eal/arm/include/rte_memcpy_32.h:296:9,
> inlined from 'rte_flow_conv_action_conf' at ../lib/ethdev/rte_flow.c:726:20,
> inlined from 'rte_flow_conv_actions' at ../lib/ethdev/rte_flow.c:936:10:
> warning: '__builtin_memcpy' specified bound 4294967264 exceeds maximum
> object size 2147483647 [-Wstringop-overflow=]
>
> The issue is due to possible wrapping in unsigned arithmetic.
> The 'size' can be 0. 'off' is 32. When 'tmp' is equal to (unsigned)-32,
> the copy length is more than half the address space. Hence the warning.
>
> Casted variables to 64-bit to avoid wrapping.
>
> Fixes: 063911ee1df4 ("ethdev: add flow API object converter")
> Cc: adrien.mazarguil@6wind.com
> Cc: stable@dpdk.org
>
> Reported-by: Luca Boccassi <bluca@debian.org>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> lib/ethdev/rte_flow.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
> index 3a67f1aaba..2a5a057195 100644
> --- a/lib/ethdev/rte_flow.c
> +++ b/lib/ethdev/rte_flow.c
> @@ -722,7 +722,7 @@ rte_flow_conv_action_conf(void *buf, const size_t
> size,
> if (src.rss->key_len && src.rss->key) {
> off = RTE_ALIGN_CEIL(off, sizeof(*dst.rss->key));
> tmp = sizeof(*src.rss->key) * src.rss->key_len;
> - if (size >= off + tmp)
> + if (size >= (uint64_t)off + (uint64_t)tmp)
> dst.rss->key = rte_memcpy
> ((void *)((uintptr_t)dst.rss + off),
> src.rss->key, tmp);
> @@ -731,7 +731,7 @@ rte_flow_conv_action_conf(void *buf, const size_t
> size,
> if (src.rss->queue_num) {
> off = RTE_ALIGN_CEIL(off, sizeof(*dst.rss->queue));
> tmp = sizeof(*src.rss->queue) * src.rss->queue_num;
> - if (size >= off + tmp)
> + if (size >= (uint64_t)off + (uint64_t)tmp)
> dst.rss->queue = rte_memcpy
> ((void *)((uintptr_t)dst.rss + off),
> src.rss->queue, tmp);
> --
> 2.25.1
Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori
next prev parent reply other threads:[~2023-11-01 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 7:15 Ruifeng Wang
2023-11-01 8:12 ` Ori Kam [this message]
2023-11-01 16:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR12MB466642545DCF9A9E3F872058D6A7A@MW2PR12MB4666.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=adrien.mazarguil@6wind.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).