From: Ori Kam <orika@nvidia.com>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"mb@smartsharesystems.com" <mb@smartsharesystems.com>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
"helin.zhang@intel.com" <helin.zhang@intel.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"john.mcnamara@intel.com" <john.mcnamara@intel.com>
Cc: "techboard@dpdk.org" <techboard@dpdk.org>,
"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>
Subject: RE: [PATCH] ethdev: add flow API support for P4-programmable devices
Date: Thu, 21 Sep 2023 16:38:50 +0000 [thread overview]
Message-ID: <MW2PR12MB4666A1066797E75DF8AC92D6D6F8A@MW2PR12MB4666.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230915185932.3070938-1-cristian.dumitrescu@intel.com>
Hi Cristian,
> -----Original Message-----
> From: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Sent: Friday, September 15, 2023 10:00 PM
> Subject: [PATCH] ethdev: add flow API support for P4-programmable devices
>
> This patch introduces the new "program" action type to enable flow API
> support for P4-programmable devices.
>
> In the case of P4-programmable devices, the device is initially blank.
> The flow items and actions are defined by the user (outside of any
> vendor control) through the P4 program, which is typically compiled
> into firmware that is loaded on the device at init time. These flow
> items and actions are then used during the run-time phase to add flows
> on the device.
>
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> Change log:
>
> V1:
> -Incorporated the feedback from the DPDK Summit 2023, sincere thanks
> to the many colleagues who contributed!
> -Based on Ori's suggestion, decided to reuse the existing "flex" flow
> item instead of defining a new flow item, so only the new "program"
> action type is required.
>
> RFC:
> -RFC link: https://mails.dpdk.org/archives/dev/2023-August/273703.html
>
> lib/ethdev/rte_flow.h | 50 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index 2ebb76dbc0..9eef5027d0 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -2981,6 +2981,15 @@ enum rte_flow_action_type {
> * @see struct rte_flow_action_indirect_list
> */
> RTE_FLOW_ACTION_TYPE_INDIRECT_LIST,
> +
> + /**
> + * Program action. These actions are defined by the program currently
> + * loaded on the device. For example, these actions are applicable to
> + * devices that can be programmed through the P4 language.
> + *
> + * @see struct rte_flow_action_prog.
> + */
> + RTE_FLOW_ACTION_TYPE_PROG,
> };
>
> /**
> @@ -4055,6 +4064,47 @@ struct rte_flow_indirect_update_flow_meter_mark
> {
> enum rte_color init_color;
> };
>
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this structure may change without prior notice.
> + *
> + * Program action argument configuration parameters.
> + *
> + * The action argument field length must be non-zero. The action argument
> field
Why can't it be zero? I can see actions that don't have any arguments.
> + * value must be non-NULL, with the value bytes specified in network byte
> order.
> + *
> + * @see struct rte_flow_action_prog
> + */
> +struct rte_flow_action_prog_argument {
> + /** Argument name. */
> + const char *arg_name;
Maybe uint32 id?
> + /** Argument field length. */
> + uint32_t arg_length;
size?
> + /** Argument field value. */
> + const uint8_t *arg_value;
data?
I just wish to make it align with other names we have in rte_flow
for example raw_encap
In any case I think we can drop the arg prefix.
> +};
> +
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this structure may change without prior notice.
> + *
> + * RTE_FLOW_ACTION_TYPE_PROG
> + *
> + * Program action configuration parameters.
> + *
> + * Each action can have zero or more arguments.
> + *
> + * @see RTE_FLOW_ACTION_TYPE_PROG
> + */
> +struct rte_flow_action_prog {
> + /** Action name. */
> + const char *action_name;
> + /** Number of action arguments. */
> + uint32_t action_args_num;
> + /** Action arguments array. */
> + const struct rte_flow_action_prog_argument *action_args;
> +};
> +
> /* Mbuf dynamic field offset for metadata. */
> extern int32_t rte_flow_dynf_metadata_offs;
>
> --
> 2.34.1
Best,
Ori
next prev parent reply other threads:[~2023-09-21 16:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 18:59 Cristian Dumitrescu
2023-09-21 16:38 ` Ori Kam [this message]
2023-09-25 11:52 ` Dumitrescu, Cristian
2023-09-25 12:35 ` Morten Brørup
2023-09-25 12:33 ` [PATCH V2] " Cristian Dumitrescu
2023-09-26 9:25 ` Ori Kam
2023-09-28 9:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR12MB4666A1066797E75DF8AC92D6D6F8A@MW2PR12MB4666.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=helin.zhang@intel.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=john.mcnamara@intel.com \
--cc=mb@smartsharesystems.com \
--cc=qi.z.zhang@intel.com \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).