From: Ori Kam <orika@nvidia.com>
To: Rongwei Liu <rongweil@nvidia.com>, Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Ferruh Yigit <ferruh.yigit@xilinx.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>
Subject: RE: [PATCH v1] ethdev: add direction info when creating the transfer table
Date: Sun, 11 Sep 2022 08:22:39 +0000 [thread overview]
Message-ID: <MW2PR12MB4666E94D987DE24A3121BCD7D6459@MW2PR12MB4666.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220907024020.2474860-1-rongweil@nvidia.com>
Hi Rongwei,
> -----Original Message-----
> From: Rongwei Liu <rongweil@nvidia.com>
> Sent: Wednesday, 7 September 2022 5:40
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH v1] ethdev: add direction info when creating the transfer
> table
>
> The transfer domain rule is able to match traffic wire/vf
> origin and it means two directions' underlayer resource.
>
> In customer deployments, they usually match only one direction
> traffic in single flow table: either from wire or from vf.
>
> Introduce one new member transfer_mode into rte_flow_attr to
> indicate the flow table direction property: from wire, from vf
> or bi-direction(default).
>
> It helps to save underlayer memory also on insertion rate.
>
> By default, the transfer domain is bi-direction, and no behavior changes.
>
> 1. Match wire origin only
> flow template_table 0 create group 0 priority 0 transfer wire_orig...
> 2. Match vf origin only
> flow template_table 0 create group 0 priority 0 transfer vf_orig...
>
> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> ---
> app/test-pmd/cmdline_flow.c | 26 +++++++++++++++++++++
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 ++-
> lib/ethdev/rte_flow.h | 9 ++++++-
> 3 files changed, 36 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 7f50028eb7..b25b595e82 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -177,6 +177,8 @@ enum index {
> TABLE_INGRESS,
> TABLE_EGRESS,
> TABLE_TRANSFER,
> + TABLE_TRANSFER_WIRE_ORIG,
> + TABLE_TRANSFER_VF_ORIG,
> TABLE_RULES_NUMBER,
> TABLE_PATTERN_TEMPLATE,
> TABLE_ACTIONS_TEMPLATE,
> @@ -1141,6 +1143,8 @@ static const enum index next_table_attr[] = {
> TABLE_INGRESS,
> TABLE_EGRESS,
> TABLE_TRANSFER,
> + TABLE_TRANSFER_WIRE_ORIG,
> + TABLE_TRANSFER_VF_ORIG,
> TABLE_RULES_NUMBER,
> TABLE_PATTERN_TEMPLATE,
> TABLE_ACTIONS_TEMPLATE,
> @@ -2881,6 +2885,18 @@ static const struct token token_list[] = {
> .next = NEXT(next_table_attr),
> .call = parse_table,
> },
> + [TABLE_TRANSFER_WIRE_ORIG] = {
> + .name = "wire_orig",
> + .help = "affect rule direction to transfer",
> + .next = NEXT(next_table_attr),
> + .call = parse_table,
> + },
> + [TABLE_TRANSFER_VF_ORIG] = {
> + .name = "vf_orig",
> + .help = "affect rule direction to transfer",
> + .next = NEXT(next_table_attr),
> + .call = parse_table,
> + },
> [TABLE_RULES_NUMBER] = {
> .name = "rules_number",
> .help = "number of rules in table",
> @@ -8894,6 +8910,16 @@ parse_table(struct context *ctx, const struct
> token *token,
> case TABLE_TRANSFER:
> out->args.table.attr.flow_attr.transfer = 1;
> return len;
> + case TABLE_TRANSFER_WIRE_ORIG:
> + if (!out->args.table.attr.flow_attr.transfer)
> + return -1;
> + out->args.table.attr.flow_attr.transfer_mode = 1;
> + return len;
> + case TABLE_TRANSFER_VF_ORIG:
> + if (!out->args.table.attr.flow_attr.transfer)
> + return -1;
> + out->args.table.attr.flow_attr.transfer_mode = 2;
> + return len;
> default:
> return -1;
> }
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 330e34427d..603b7988dd 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -3332,7 +3332,8 @@ It is bound to
> ``rte_flow_template_table_create()``::
>
> flow template_table {port_id} create
> [table_id {id}] [group {group_id}]
> - [priority {level}] [ingress] [egress] [transfer]
> + [priority {level}] [ingress] [egress]
> + [transfer [vf_orig] [wire_orig]]
> rules_number {number}
> pattern_template {pattern_template_id}
> actions_template {actions_template_id}
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index a79f1e7ef0..512b08d817 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -130,7 +130,14 @@ struct rte_flow_attr {
> * through a suitable port. @see rte_flow_pick_transfer_proxy().
> */
> uint32_t transfer:1;
> - uint32_t reserved:29; /**< Reserved, must be zero. */
> + /**
> + * 0 means bidirection,
> + * 0x1 origin uplink,
> + * 0x2 origin vport,
> + * N/A both set.
> + */
> + uint32_t transfer_mode:2;
> + uint32_t reserved:27; /**< Reserved, must be zero. */
> };
>
> /**
> --
> 2.27.0
Acked-by: Ori Kam <orika@nvidia.com>
Thanks,
Ori
next prev parent reply other threads:[~2022-09-11 8:22 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 2:40 Rongwei Liu
2022-09-11 8:22 ` Ori Kam [this message]
2022-09-12 16:57 ` Ivan Malov
2022-09-13 13:46 ` Rongwei Liu
2022-09-13 14:33 ` Ivan Malov
2022-09-14 5:16 ` Rongwei Liu
2022-09-14 7:32 ` Ivan Malov
2022-09-14 10:17 ` Rongwei Liu
2022-09-14 15:18 ` Ivan Malov
2022-09-14 21:02 ` Thomas Monjalon
2022-09-15 0:58 ` Rongwei Liu
2022-09-15 7:47 ` Ivan Malov
2022-09-15 8:18 ` Thomas Monjalon
2022-09-15 9:42 ` Ivan Malov
2022-09-15 8:48 ` Rongwei Liu
2022-09-15 10:59 ` Ivan Malov
2022-09-15 11:16 ` Thomas Monjalon
2022-09-20 9:41 ` Ori Kam
2022-09-20 12:45 ` Ivan Malov
2022-09-20 13:59 ` Ori Kam
2022-09-20 15:28 ` Ivan Malov
2022-09-21 7:34 ` Ori Kam
2022-09-21 8:39 ` Andrew Rybchenko
2022-09-21 9:04 ` Ivan Malov
2022-09-21 9:40 ` Thomas Monjalon
2022-09-21 10:04 ` Andrew Rybchenko
2022-09-21 12:41 ` Ori Kam
2022-09-21 12:51 ` Morten Brørup
2022-09-22 7:39 ` Andrew Rybchenko
2022-09-22 10:06 ` Ori Kam
2022-09-22 10:31 ` Andrew Rybchenko
2022-09-22 13:00 ` Ori Kam
2022-09-23 7:25 ` Andrew Rybchenko
2022-09-23 16:11 ` Ori Kam
2022-09-22 12:43 ` Ivan Malov
2022-09-22 14:46 ` Ori Kam
2022-09-28 9:24 ` [PATCH v3] ethdev: add hint when creating async " Rongwei Liu
2022-10-04 8:31 ` Andrew Rybchenko
2022-11-04 10:42 ` [PATCH v4] ethdev: add special flags " Rongwei Liu
2022-11-04 10:44 ` Rongwei Liu
2022-11-08 11:39 ` Andrew Rybchenko
2022-11-08 11:47 ` Andrew Rybchenko
2022-11-08 13:29 ` Thomas Monjalon
2022-11-08 14:38 ` Andrew Rybchenko
2022-11-08 15:25 ` Thomas Monjalon
2022-11-09 8:53 ` Andrew Rybchenko
2022-11-09 9:03 ` Thomas Monjalon
2022-11-09 9:36 ` Andrew Rybchenko
2022-11-09 10:50 ` Thomas Monjalon
2022-11-06 10:02 ` [PATCH v3] ethdev: add hint " Andrew Rybchenko
2022-11-07 1:58 ` Rongwei Liu
2022-11-08 9:19 ` Thomas Monjalon
2022-11-08 9:35 ` Andrew Rybchenko
2022-11-08 11:18 ` Thomas Monjalon
2022-11-08 11:48 ` Andrew Rybchenko
2022-11-14 8:47 ` [PATCH v6] ethdev: add special flags " Rongwei Liu
2022-11-14 11:59 ` [PATCH v7] " Rongwei Liu
2023-01-17 15:13 ` Ferruh Yigit
2023-01-17 17:01 ` Ferruh Yigit
2023-01-18 2:50 ` Rongwei Liu
2023-01-18 7:30 ` Andrew Rybchenko
2023-01-18 7:28 ` Andrew Rybchenko
2023-01-18 16:18 ` Thomas Monjalon
2023-02-01 10:17 ` Andrew Rybchenko
2023-02-01 10:58 ` Thomas Monjalon
2023-02-01 11:10 ` Andrew Rybchenko
2023-02-01 11:18 ` Thomas Monjalon
2023-02-01 11:38 ` Andrew Rybchenko
2023-02-01 13:48 ` Thomas Monjalon
2023-02-02 9:21 ` Andrew Rybchenko
2023-02-02 11:29 ` Thomas Monjalon
2023-02-02 12:24 ` Andrew Rybchenko
2023-02-01 11:22 ` Ori Kam
2023-02-01 11:29 ` Andrew Rybchenko
2023-02-01 11:12 ` Ori Kam
2023-02-01 11:20 ` Thomas Monjalon
2023-01-30 0:00 ` Ivan Malov
2023-01-30 2:34 ` Rongwei Liu
2023-01-30 7:40 ` Ivan Malov
2023-01-30 14:49 ` Rongwei Liu
2023-01-30 23:00 ` Ivan Malov
2023-01-31 3:06 ` Rongwei Liu
2023-01-31 5:30 ` Ivan Malov
2023-01-31 6:14 ` Rongwei Liu
2023-02-01 10:12 ` Thomas Monjalon
2023-02-01 11:50 ` Ivan Malov
2023-02-01 13:37 ` Thomas Monjalon
2023-02-01 14:04 ` Ivan Malov
2023-02-01 14:23 ` Thomas Monjalon
2023-02-01 14:29 ` Ori Kam
2023-02-02 11:19 ` [PATCH v8] ethdev: add optimization hints in flow template table Rongwei Liu
2023-02-02 11:33 ` Thomas Monjalon
2023-02-08 23:19 ` Ferruh Yigit
2022-11-09 8:11 ` [PATCH v5] ethdev: add special flags when creating async transfer table Rongwei Liu
2022-11-09 8:13 ` Rongwei Liu
2022-11-09 8:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR12MB4666E94D987DE24A3121BCD7D6459@MW2PR12MB4666.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).