From: Ori Kam <orika@nvidia.com>
To: Suanming Mou <suanmingm@nvidia.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] ethdev: fix flow action async query coverity
Date: Tue, 17 Oct 2023 12:21:46 +0000 [thread overview]
Message-ID: <MW2PR12MB4666ECABC3B4ADBD6FCF4D29D6D6A@MW2PR12MB4666.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231017082317.735106-1-suanmingm@nvidia.com>
Hi Suanming,
> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Tuesday, October 17, 2023 11:23 AM
>
> This commit adds the ops chcek to fix the coverity issue.
>
> Coverity issue: 403258
> Fixes: c9dc03840873 ("ethdev: add indirect action async query")
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> ---
> lib/ethdev/rte_flow.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
> index 874f845513..3a67f1aaba 100644
> --- a/lib/ethdev/rte_flow.c
> +++ b/lib/ethdev/rte_flow.c
> @@ -2226,6 +2226,8 @@ rte_flow_async_action_handle_query(uint16_t
> port_id,
> const struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error);
> int ret;
>
> + if (unlikely(!ops))
> + return -rte_errno;
> ret = ops->async_action_handle_query(dev, queue_id, op_attr,
> action_handle, data, user_data,
> error);
> ret = flow_err(port_id, ret, error);
> --
> 2.34.1
Acked-by: Ori Kam <orika@nvidia.com>
next prev parent reply other threads:[~2023-10-17 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 8:23 Suanming Mou
2023-10-17 12:21 ` Ori Kam [this message]
2023-10-17 13:18 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR12MB4666ECABC3B4ADBD6FCF4D29D6D6A@MW2PR12MB4666.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).