From: "He, Xingguang" <xingguang.he@intel.com>
To: "He, Xingguang" <xingguang.he@intel.com>,
"Ding, Xuan" <xuan.ding@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>,
"Yang, YvonneX" <yvonnex.yang@intel.com>,
"Jiang, Cheng1" <cheng1.jiang@intel.com>
Subject: RE: [PATCH] vhost: fix unnecessary dirty page logging
Date: Fri, 8 Jul 2022 08:13:31 +0000 [thread overview]
Message-ID: <MW3PR11MB4553799DC3DB33B859B24E3C8E829@MW3PR11MB4553.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW3PR11MB455382D4BF88088C8A72332A8E829@MW3PR11MB4553.namprd11.prod.outlook.com>
> -----Original Message-----
> From: He, Xingguang <xingguang.he@intel.com>
> Sent: Friday, July 8, 2022 3:53 PM
> To: Ding, Xuan <xuan.ding@intel.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Yang, YvonneX
> <yvonnex.yang@intel.com>; Jiang, Cheng1 <cheng1.jiang@intel.com>
> Subject: RE: [PATCH] vhost: fix unnecessary dirty page logging
>
> > -----Original Message-----
> > From: Ding, Xuan <xuan.ding@intel.com>
> > Sent: Friday, July 8, 2022 3:04 PM
> > To: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> > <chenbo.xia@intel.com>
> > Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> > <xingguang.he@intel.com>; Yang, YvonneX <yvonnex.yang@intel.com>;
> > Jiang, Cheng1 <cheng1.jiang@intel.com>
> > Subject: RE: [PATCH] vhost: fix unnecessary dirty page logging
> >
> > Hi,
> >
> > > -----Original Message-----
> > > From: Maxime Coquelin <maxime.coquelin@redhat.com>
> > > Sent: 2022年7月7日 19:31
> > > To: Xia, Chenbo <chenbo.xia@intel.com>; Ding, Xuan
> > > <xuan.ding@intel.com>
> > > Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> > > <xingguang.he@intel.com>; Yang, YvonneX <yvonnex.yang@intel.com>;
> > > Jiang,
> > > Cheng1 <cheng1.jiang@intel.com>
> > > Subject: Re: [PATCH] vhost: fix unnecessary dirty page logging
> > >
> > >
> > >
> > > On 7/7/22 11:51, Xia, Chenbo wrote:
> > > >> -----Original Message-----
> > > >> From: Ding, Xuan <xuan.ding@intel.com>
> > > >> Sent: Thursday, July 7, 2022 2:55 PM
> > > >> To: maxime.coquelin@redhat.com; Xia, Chenbo
> > > >> <chenbo.xia@intel.com>
> > > >> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> > > >> <xingguang.he@intel.com>; Yang, YvonneX
> <yvonnex.yang@intel.com>;
> > > >> Jiang,
> > > >> Cheng1 <cheng1.jiang@intel.com>; Ding, Xuan <xuan.ding@intel.com>
> > > >> Subject: [PATCH] vhost: fix unnecessary dirty page logging
> > > >>
> > > >> From: Xuan Ding <xuan.ding@intel.com>
> > > >>
> > > >> The dirty page logging is only required in vhost enqueue
> > > >> direction for live migration. This patch removes the unnecessary
> > > >> dirty page logging in vhost dequeue direction. Otherwise, it will
> > > >> result in a performance drop. Some if-else judgements are also
> > > >> optimized to improve
> > > performance.
> > > >>
> > > >> Fixes: 6d823bb302c7 ("vhost: prepare sync for descriptor to mbuf
> > > >> refactoring")
> > > >> Fixes: b6eee3e83402 ("vhost: fix sync dequeue offload")
> > > >>
> > > >> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> > > >> ---
> > > >
> > > > Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
> > > >
> > > > Although it's late in release, we can consider to merge this as I
> > > > see it impacts the performance by 5%:
> > > >
> > >
> >
> http://inbox.dpdk.org/dev/BYAPR11MB2711F13CDA2B0A4535A6591EFE839
> > @B
> > > YAPR
> > > > 11MB2711.namprd11.prod.outlook.com/T/#t
> > >
> > > Yes, I raised we need it in -rc4 at today's Release status meeting.
> > > I'll review it today.
> > >
> > > > But also, it will be good to know the performance issue is solved
> > > > by sharing the test results.
> > >
> > > Yes, Intel performance results would be appreciated.
> >
> > This fix patch is for the issue reported at 22.07-rc3. The refactoring
> > patch brings a 3%~5% perf drop in vhost sync path.
> > With fix patch, the perf drop introduced by refactoring is solved.
>
> The fix is for a critical issue, I tested dpdk22.07-rc3 with the patch, the
> performance drop introduced by refactoring have been fixed and no other
> regressions were seen as a result of the patch, but the packed ring still exist
> drop around 5%.
>
> Tested-by: Xingguang He<xingguang.he@intel.com>
>
> >
> > However, the testing result shows there still exists ~5% packed ring
> > perf drop compared with 22.03.
> > We find the improving checksum offload patch series in 22.07 may
> > contribute to the packed ring perf drop.
> > Because we always do checksum checks in PMD.
>
> I tested the performance of Vhost before and after checksum offload patch
> series, there exist ~5% performance drop.
Sorry, the drop of checksum offload patch series is ~3%.
The drop between DPDK22.03 and DPDK22.07-rc3 is ~5%.
>
> >
> > Could you help to double check this patch series, is it as expected?
> > Your assistance is really appreciated.
> >
> > Regards,
> > Xuan
> >
> > >
> > > > Thanks,
> > > > Chenbo
> > > >
> > >
> > > Thanks,
> > > Maxime
next prev parent reply other threads:[~2022-07-08 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 6:55 xuan.ding
2022-07-07 8:23 ` Hu, Jiayu
2022-07-07 9:51 ` Xia, Chenbo
2022-07-07 11:30 ` Maxime Coquelin
2022-07-08 7:04 ` Ding, Xuan
2022-07-08 7:53 ` He, Xingguang
2022-07-08 8:13 ` He, Xingguang [this message]
2022-07-08 7:57 ` Maxime Coquelin
2022-07-08 8:09 ` Ding, Xuan
2022-07-11 8:09 ` He, Xingguang
2022-07-07 12:04 ` Maxime Coquelin
2022-07-08 9:11 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW3PR11MB4553799DC3DB33B859B24E3C8E829@MW3PR11MB4553.namprd11.prod.outlook.com \
--to=xingguang.he@intel.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=xuan.ding@intel.com \
--cc=yvonnex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).