From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Peng, Yuan" <yuan.peng@intel.com>
Subject: RE: [PATCH v2] net/idpf: fix crash when launching l3fwd
Date: Fri, 18 Nov 2022 06:24:25 +0000 [thread overview]
Message-ID: <MW3PR11MB458783B8EC9B0D8DB1529DE2E3099@MW3PR11MB4587.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221117101509.14472-1-beilei.xing@intel.com>
> -
> if (conf->txmode.mq_mode != RTE_ETH_MQ_TX_NONE) {
> PMD_INIT_LOG(ERR, "Multi-queue TX mode %d is not supported",
> conf->txmode.mq_mode);
> diff --git a/drivers/net/idpf/idpf_vchnl.c b/drivers/net/idpf/idpf_vchnl.c
> index ac6486d4ef..88770447f8 100644
> --- a/drivers/net/idpf/idpf_vchnl.c
> +++ b/drivers/net/idpf/idpf_vchnl.c
> @@ -1197,6 +1197,9 @@ idpf_vc_dealloc_vectors(struct idpf_vport *vport)
> int err, len;
>
> alloc_vec = vport->recv_vectors;
> + if (alloc_vec == NULL)
> + return -EINVAL;
> +
Would it be better to check before idpf_vc_dealloc_vectors?
next prev parent reply other threads:[~2022-11-18 6:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 10:00 [PATCH] " beilei.xing
2022-11-17 10:15 ` [PATCH v2] " beilei.xing
2022-11-18 6:24 ` Wu, Jingjing [this message]
2022-11-18 7:05 ` Xing, Beilei
2022-11-18 7:02 ` [PATCH v3] " beilei.xing
2022-11-18 9:57 ` Zhang, Qi Z
2022-11-18 9:59 ` Peng, Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW3PR11MB458783B8EC9B0D8DB1529DE2E3099@MW3PR11MB4587.namprd11.prod.outlook.com \
--to=jingjing.wu@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).