From: "Loftus, Ciara" <ciara.loftus@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@xilinx.com" <ferruh.yigit@xilinx.com>
Subject: RE: [PATCH] net/af_xdp: limit libbpf version to <= v0.7.0
Date: Fri, 24 Jun 2022 08:37:10 +0000 [thread overview]
Message-ID: <MW4PR11MB5872B6A1801C8D6BDB4335438EB49@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <9193135.JRmrKFJ9eK@thomas>
>
> 24/06/2022 08:06, Ciara Loftus:
> > Linking with libbpf v0.8.0 causes deprication warnings. As a temporary
> > measure, prevent linking with libbpf versions v0.8.0 and greater. This
> > limitation should be removed in the future when appropriate
> > compatibility measures are introduced.
> >
> > Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> > ---
> > -bpf_dep = dependency('libbpf', required: false, method: 'pkg-config')
> > -if not bpf_dep.found()
> > - bpf_dep = cc.find_library('bpf', required: false)
> > -endif
> > +bpf_dep = dependency('libbpf', version : '<=0.7.0', required: false,
> method: 'pkg-config')
>
> It is also removing the find_library() method.
> Any reason it was there?
>
My understanding is that one can't check the library version using that method.
So it was a valid method of picking up the library until now where we always need to check the version before linking.
next prev parent reply other threads:[~2022-06-24 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 6:06 Ciara Loftus
2022-06-24 8:28 ` Thomas Monjalon
2022-06-24 8:37 ` Loftus, Ciara [this message]
2022-06-24 10:10 ` Thomas Monjalon
2022-06-24 11:48 ` Andrew Rybchenko
2022-07-07 11:19 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB5872B6A1801C8D6BDB4335438EB49@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).