From: "Kundapura, Ganapati" <ganapati.kundapura@intel.com>
To: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
Cc: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
Subject: RE: [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count stats
Date: Thu, 1 Dec 2022 06:56:32 +0000 [thread overview]
Message-ID: <MW4PR11MB59112BDF1A442C84CC591AB087149@MW4PR11MB5911.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BN6PR11MB3858A08066EFD0A985971805A1149@BN6PR11MB3858.namprd11.prod.outlook.com>
Hi Harish,
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Thursday, December 1, 2022 11:38 AM
> To: Kundapura, Ganapati <ganapati.kundapura@intel.com>; dev@dpdk.org;
> jerinj@marvell.com; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> Subject: RE: [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count
> stats
>
> Hi Ganapti,
>
> > -----Original Message-----
> > From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> > Sent: Wednesday, November 30, 2022 10:40 PM
> > To: dev@dpdk.org; jerinj@marvell.com; Naga Harish K, S V
> > <s.v.naga.harish.k@intel.com>; Gujjar, Abhinandan S
> > <abhinandan.gujjar@intel.com>
> > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Subject: [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count
> > stats
>
> As per the DPDK contribute guidelines, the subject line should use the
> imperative of the verb (like instructions to the code base).
> http://doc.dpdk.org/guides/contributing/patches.html
> Please change the subject lines for all patches in the patch set wherever it is
> required.
>
Updated the subject line and reposted
> Also is it optimizing the stats update or fixing wrong stats update?
>
It's fixing of wrong stats
> >
> > crypto_enq_count is updated on failure to enqueue ops to cryptodev.
> >
> > Updated crypto_enq_count on successful enqueue of ops to cryptodev.
> >
> > Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
> >
> > diff --git a/lib/eventdev/rte_event_crypto_adapter.c
> > b/lib/eventdev/rte_event_crypto_adapter.c
> > index 1c0a22b..ef3dbe9 100644
> > --- a/lib/eventdev/rte_event_crypto_adapter.c
> > +++ b/lib/eventdev/rte_event_crypto_adapter.c
> > @@ -485,6 +485,9 @@ eca_enq_to_cryptodev(struct
> event_crypto_adapter
> > *adapter, struct rte_event *ev,
> > cdev_id,
> > qp_id,
> >
> > &nb_enqueued);
> > + stats->crypto_enq_count += nb_enqueued;
> > + n += nb_enqueued;
> > +
> > /**
> > * If some crypto ops failed to flush to cdev and
> > * space for another batch is not available, stop @@ -
> > 495,9 +498,6 @@ eca_enq_to_cryptodev(struct event_crypto_adapter
> > *adapter, struct rte_event *ev,
> > &qp_info->cbuf)))
> > adapter->stop_enq_to_cryptodev = true;
> > }
> > -
> > - stats->crypto_enq_count += nb_enqueued;
> > - n += nb_enqueued;
> > }
> >
> > return n;
> > --
> > 2.6.4
next prev parent reply other threads:[~2022-12-01 6:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:10 [PATCH v1 1/5] eventdev/event_crypto: process event port's impl rel cap Ganapati Kundapura
2022-11-30 17:10 ` [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count stats Ganapati Kundapura
2022-12-01 6:07 ` Naga Harish K, S V
2022-12-01 6:56 ` Kundapura, Ganapati [this message]
2022-11-30 17:10 ` [PATCH v1 3/5] eventdev/crypto: wrong offset used while flushing events Ganapati Kundapura
2022-11-30 17:10 ` [PATCH v1 4/5] eventdev/crypto: overflow in circular buffer Ganapati Kundapura
2022-11-30 17:10 ` [PATCH v1 5/5] eventdev/crypto: add all failed events to " Ganapati Kundapura
2022-12-01 6:46 ` [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap Ganapati Kundapura
2022-12-01 6:46 ` [PATCH v2 2/5] eventdev/crypto: fix wrong crypto enqueue count stats Ganapati Kundapura
2022-12-05 11:34 ` [EXT] " Volodymyr Fialko
2022-12-07 5:40 ` Gujjar, Abhinandan S
2022-12-01 6:46 ` [PATCH v2 3/5] eventdev/crypto: fix wrong offset used while flushing events Ganapati Kundapura
2022-12-05 11:35 ` [EXT] " Volodymyr Fialko
2022-12-06 16:17 ` Gujjar, Abhinandan S
2022-12-01 6:46 ` [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer Ganapati Kundapura
2022-12-05 11:37 ` [EXT] " Volodymyr Fialko
2022-12-06 16:25 ` Gujjar, Abhinandan S
2022-12-07 6:53 ` Kundapura, Ganapati
2022-12-01 6:46 ` [PATCH v2 5/5] eventdev/crypto: add all failed events to " Ganapati Kundapura
2022-12-05 11:37 ` [EXT] " Volodymyr Fialko
2022-12-06 16:37 ` Gujjar, Abhinandan S
2022-12-01 13:20 ` [EXT] [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap Volodymyr Fialko
2022-12-06 15:44 ` Gujjar, Abhinandan S
2022-12-07 6:53 ` Kundapura, Ganapati
2022-12-07 6:49 ` [PATCH v3 " Ganapati Kundapura
2022-12-07 6:49 ` [PATCH v3 2/5] eventdev/crypto: fix wrong crypto enqueue count stats Ganapati Kundapura
2022-12-07 6:55 ` Gujjar, Abhinandan S
2022-12-07 6:49 ` [PATCH v3 3/5] eventdev/crypto: fix wrong offset used while flushing events Ganapati Kundapura
2022-12-07 6:55 ` Gujjar, Abhinandan S
2022-12-07 6:49 ` [PATCH v3 4/5] eventdev/crypto: fix overflow in circular buffer Ganapati Kundapura
2022-12-07 7:04 ` Gujjar, Abhinandan S
2022-12-07 6:49 ` [PATCH v3 5/5] eventdev/crypto: fix failed events Ganapati Kundapura
2022-12-07 6:56 ` Gujjar, Abhinandan S
2023-01-12 12:59 ` Jerin Jacob
2022-12-07 6:54 ` [PATCH v3 1/5] eventdev/event_crypto: process event port's impl rel cap Gujjar, Abhinandan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB59112BDF1A442C84CC591AB087149@MW4PR11MB5911.namprd11.prod.outlook.com \
--to=ganapati.kundapura@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).