From: "Kundapura, Ganapati" <ganapati.kundapura@intel.com>
To: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
Subject: RE: [PATCH v1] eventdev/eth_rx: sub event type gets reset
Date: Wed, 14 Sep 2022 06:22:18 +0000 [thread overview]
Message-ID: <MW4PR11MB5911C4D20D5E19034F9E2CAE87469@MW4PR11MB5911.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB43487181B1FE41D521328850FD479@DM6PR11MB4348.namprd11.prod.outlook.com>
Hi Jay,
> -----Original Message-----
> From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> Sent: 13 September 2022 22:32
> To: Kundapura, Ganapati <ganapati.kundapura@intel.com>; dev@dpdk.org;
> jerinj@marvell.com
> Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Subject: RE: [PATCH v1] eventdev/eth_rx: sub event type gets reset
>
> > -----Original Message-----
> > From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> > Sent: Tuesday, September 13, 2022 12:32 PM
> > To: dev@dpdk.org; jerinj@marvell.com
> > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Naga Harish K, S
> > V <s.v.naga.harish.k@intel.com>
> > Subject: [PATCH v1] eventdev/eth_rx: sub event type gets reset
> >
> > In rte_event_eth_rx_adapter_queue_add(), sub_event_type of
> rte_event
> > structure is reset which is used by the application
>
> Just a minor comment - application may or may not use this field. "which can
> be used" is better suited. Rest looks good. Thanks for posting.
Updated commit message as suggested in V2
>
> With this change,
> Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
>
Added Ack with commit header change in V2
> > to determine the processing function.
> >
> > Removed resetting of rte_event::sub_event_type
> >
> > Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
> >
> > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> > b/lib/eventdev/rte_event_eth_rx_adapter.c
> > index 64a6add..e42e41c 100644
> > --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> > @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter
> *rx_adapter,
> > qi_ev->event = ev->event;
> > qi_ev->op = RTE_EVENT_OP_NEW;
> > qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER;
> > - qi_ev->sub_event_type = 0;
> >
> > if (conf->rx_queue_flags &
> >
> RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {
> > --
> > 2.6.4
next prev parent reply other threads:[~2022-09-14 6:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 7:02 Ganapati Kundapura
2022-09-13 17:02 ` Jayatheerthan, Jay
2022-09-14 6:22 ` Kundapura, Ganapati [this message]
2022-09-14 13:42 ` Jerin Jacob
2022-09-14 6:20 ` [PATCH v2] " Ganapati Kundapura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB5911C4D20D5E19034F9E2CAE87469@MW4PR11MB5911.namprd11.prod.outlook.com \
--to=ganapati.kundapura@intel.com \
--cc=dev@dpdk.org \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).