From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: Amit Prakash Shukla <amitprakashs@marvell.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>
Subject: RE: [PATCH 3/3] crypto/qat: compilation fix for GCC-12
Date: Fri, 5 Aug 2022 08:12:52 +0000 [thread overview]
Message-ID: <MW5PR11MB5809591C69320D1CBA7E2320B89E9@MW5PR11MB5809.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220804134055.1816993-3-amitprakashs@marvell.com>
> -----Original Message-----
> From: Amit Prakash Shukla <amitprakashs@marvell.com>
> Sent: Thursday, August 4, 2022 2:41 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; jerinj@marvell.com; Amit Prakash Shukla
> <amitprakashs@marvell.com>
> Subject: [PATCH 3/3] crypto/qat: compilation fix for GCC-12
>
> GCC 12 raises the following warning:
>
> from ../lib/eal/x86/include/rte_vect.h:31,
> from ../lib/eal/x86/include/rte_memcpy.h:17,
> from ../drivers/crypto/qat/qat_sym_session.c:10:
> In function '_mm_storeu_si128',
> inlined from 'rte_mov16' at
> ../lib/eal/x86/include/rte_memcpy.h:508:2,
> inlined from 'rte_mov128' at
> ../lib/eal/x86/include/rte_memcpy.h:542:2,
> inlined from 'rte_memcpy_generic' at
> ../lib/eal/x86/include/rte_memcpy.h:732:4,
> inlined from 'rte_memcpy' at
> ../lib/eal/x86/include/rte_memcpy.h:882:10,
> inlined from 'qat_sym_do_precomputes.constprop' at
> ../drivers/crypto/qat/qat_sym_session.c:1434:2:
> /usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/include/emmintrin.h:739:8: error:
> array subscript 8 is outside array bounds of 'unsigned char[128]'
> [-Werror=array-bounds]
> 739 | *__P = __B;
> | ~~~~~^~~~~
>
> ../drivers/crypto/qat/qat_sym_session.c:
> In function 'qat_sym_do_precomputes.constprop':
> ../drivers/crypto/qat/qat_sym_session.c:1305:17: note:
> at offset 192 into object 'opad.750' of size 128
> 1305 | uint8_t
>
> opad[qat_hash_get_block_size(ICP_QAT_HW_AUTH_ALGO_DELIMITER)];
> | ^~~~
>
> ../drivers/crypto/qat/qat_sym_session.c:
> In function 'qat_sym_do_precomputes.constprop':
> ../drivers/crypto/qat/qat_sym_session.c:1304:17: note:
> at offset 128 into object 'ipad.749' of size 128
> 1304 | uint8_t
>
> ipad[qat_hash_get_block_size(ICP_QAT_HW_AUTH_ALGO_DELIMITER)];
> | ^~~~
>
> Added a check to prevent compiler warnings.
>
> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> ---
Thanks for the help!
The commit log could be shorter. Could you provide a V3 for that?
Apart from that
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
next prev parent reply other threads:[~2022-08-05 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 13:40 [PATCH 1/3] test/test_ipsec: " Amit Prakash Shukla
2022-08-04 13:40 ` [PATCH 2/3] ipsec: " Amit Prakash Shukla
2022-08-07 13:17 ` Konstantin Ananyev
2022-08-04 13:40 ` [PATCH 3/3] crypto/qat: " Amit Prakash Shukla
2022-08-05 8:12 ` Zhang, Roy Fan [this message]
2022-08-28 12:01 ` [EXT] [PATCH 1/3] test/test_ipsec: " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW5PR11MB5809591C69320D1CBA7E2320B89E9@MW5PR11MB5809.namprd11.prod.outlook.com \
--to=roy.fan.zhang@intel.com \
--cc=amitprakashs@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).