From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "gakhil@marvell.com" <gakhil@marvell.com>
Subject: RE: [PATCH] crypto/qat: fix structurally dead code
Date: Tue, 8 Mar 2022 11:09:02 +0000 [thread overview]
Message-ID: <MW5PR11MB58098A71E8D7F98D25692CAFB8099@MW5PR11MB5809.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220228160555.24926-1-arkadiuszx.kusztal@intel.com>
> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Monday, February 28, 2022 4:06 PM
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Kusztal,
> ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] crypto/qat: fix structurally dead code
>
> This patch fixes structurally dead code in QAT
> asym pmd.
>
> Coverity issue: 376563
> Fixes: ef2f4238a04d ("crypto/qat: refactor asymmetric session")
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> drivers/crypto/qat/qat_asym.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c
> index badf018f13..1e4304a3c0 100644
> --- a/drivers/crypto/qat/qat_asym.c
> +++ b/drivers/crypto/qat/qat_asym.c
> @@ -1183,7 +1183,6 @@ session_clear_modinv(struct
> rte_crypto_modinv_xform *modinv)
> static void
> session_clear_rsa(struct rte_crypto_rsa_xform *rsa)
> {
> - return;
> memset(rsa->n.data, 0, rsa->n.length);
> rte_free(rsa->n.data);
> memset(rsa->e.data, 0, rsa->e.length);
> --
> 2.13.6
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
prev parent reply other threads:[~2022-03-08 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 16:05 Arek Kusztal
2022-03-04 10:07 ` [EXT] " Akhil Goyal
2022-03-08 11:09 ` Zhang, Roy Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW5PR11MB58098A71E8D7F98D25692CAFB8099@MW5PR11MB5809.namprd11.prod.outlook.com \
--to=roy.fan.zhang@intel.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).