DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
Subject: Re: [dpdk-dev] [PATCH 00/14] net/qede/base: update PMD version to 2.8.0.1
Date: Mon, 9 Apr 2018 04:49:34 +0000	[thread overview]
Message-ID: <MWHPR0701MB36759881023470CA6BFF8F159FBF0@MWHPR0701MB3675.namprd07.prod.outlook.com> (raw)
In-Reply-To: <0a8a14aa-b9f5-7e60-8d8a-86a6ab20c888@intel.com>

Hi Ferruh,
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Friday, April 06, 2018 2:03 AM
> To: Mody, Rasesh <Rasesh.Mody@cavium.com>; dev@dpdk.org
> Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
> Subject: Re: [PATCH 00/14] net/qede/base: update PMD version to 2.8.0.1
> 
> On 4/1/2018 6:46 AM, Rasesh Mody wrote:
> > Hi,
> >
> > This patch set updates QEDE base driver to use FW version 8.33.12.0.
> > It contains some base driver enhancements and fixes. The PMD version
> > is updated to 2.8.0.1.
> >
> > Please apply.
> >
> > Thanks!
> > -Rasesh
> >
> > Rasesh Mody (14):
> >   net/qede/base: use path ID for HW init
> >   net/qede/base: protect DMAE transactions
> >   net/qede/base: add DMAE sanity check
> >   net/qede/base: upgrade FW to 8.33.12.0
> >   net/qede/base: symantic changes
> >   net/qede/base: add new chain API
> >   net/qede/base: allow changing VF MAC address
> >   net/qede/base: add MFW support for driver load timeout
> >   net/qede/base: refine error handling
> >   net/qede/base: add stats counter for link state
> >   net/qede/base: add APIs for xcvr
> >   net/qede/base: fix to support OVLAN mode
> >   net/qede/base: add packet pacing support
> >   net/qede: update PMD version to 2.8.0.1
> 
> Hi Rasesh,
> 
> Getting build errors for 32bit [1], I didn't dig which commit cause them.

These 32bit build errors are due to couple of log messages from patch 2 and 3. Have sent v2 series addressing the same. Please apply.

Thanks!
-Rasesh

> 
> 
> [1]
> In file included from .../dpdk/drivers/net/qede/base/ecore.h:50:0,
>                  from .../dpdk/drivers/net/qede/base/ecore_hw.c:12:
> .../dpdk/drivers/net/qede/base/ecore_hw.c: In function
> ‘ecore_dmae_execute_command’:
> .../dpdk/drivers/net/qede/base/../qede_logs.h:48:5: error: format ‘%lx’
> expects argument of type ‘long unsigned int’, but argument 7 has type ‘u64
> {aka long long unsigned int}’ [-Werror=format=]
>      "[%s:%d(%s)]" fmt,   \
>      ^
> .../dpdk/drivers/net/qede/base/ecore_hw.c:789:3: note: in expansion of
> macro ‘DP_VERBOSE’
>    DP_VERBOSE(p_hwfn, ECORE_MSG_HW,
>    ^~~~~~~~~~
> .../dpdk/drivers/net/qede/base/ecore_hw.c:790:69: note: format string is
> defined here
>        "No buffers allocated. Avoid DMAE transaction [{src: addr 0x%lx, type
> %d}, {dst: addr 0x%lx, type %d}, size %d].\n",
>                                                                    ~~^
>                                                                    %llx In file included from
> .../dpdk/drivers/net/qede/base/ecore.h:50:0,
>                  from .../dpdk/drivers/net/qede/base/ecore_hw.c:12:
> .../dpdk/drivers/net/qede/base/../qede_logs.h:48:5: error: format ‘%lx’
> expects argument of type ‘long unsigned int’, but argument 9 has type ‘u64
> {aka long long unsigned int}’ [-Werror=format=]
>      "[%s:%d(%s)]" fmt,   \
>      ^
> .../dpdk/drivers/net/qede/base/ecore_hw.c:789:3: note: in expansion of
> macro ‘DP_VERBOSE’
>    DP_VERBOSE(p_hwfn, ECORE_MSG_HW,
>    ^~~~~~~~~~
> .../dpdk/drivers/net/qede/base/ecore_hw.c:790:97: note: format string is
> defined here
>        "No buffers allocated. Avoid DMAE transaction [{src: addr 0x%lx, type
> %d}, {dst: addr 0x%lx, type %d}, size %d].\n",
> 
>               ~~^
> 
>               %llx
> In file included from .../dpdk/drivers/net/qede/base/ecore.h:50:0,
>                  from .../dpdk/drivers/net/qede/base/ecore_hw.c:12:
> .../dpdk/drivers/net/qede/base/ecore_hw.c: In function
> ‘ecore_dmae_sanity’:
> .../dpdk/drivers/net/qede/base/../qede_logs.h:48:5: error: format ‘%lx’
> expects argument of type ‘long unsigned int’, but argument 8 has type ‘long
> long unsigned int’ [-Werror=format=]
>      "[%s:%d(%s)]" fmt,   \
>      ^
> .../dpdk/drivers/net/qede/base/ecore_hw.c:995:2: note: in expansion of
> macro ‘DP_VERBOSE’
>   DP_VERBOSE(p_hwfn, ECORE_MSG_SP,
>   ^~~~~~~~~~
> .../dpdk/drivers/net/qede/base/ecore_hw.c:996:44: note: format string is
> defined here
>       "DMAE sanity [%s]: src_addr={phys 0x%lx, virt %p}, dst_addr={phys
> 0x%lx, virt %p}, size 0x%x\n",
>                                           ~~^
>                                           %llx In file included from
> .../dpdk/drivers/net/qede/base/ecore.h:50:0,
>                  from .../dpdk/drivers/net/qede/base/ecore_hw.c:12:
> .../dpdk/drivers/net/qede/base/../qede_logs.h:48:5: error: format ‘%lx’
> expects argument of type ‘long unsigned int’, but argument 10 has type ‘long
> long unsigned int’ [-Werror=format=]
>      "[%s:%d(%s)]" fmt,   \
>      ^
> .../dpdk/drivers/net/qede/base/ecore_hw.c:995:2: note: in expansion of
> macro ‘DP_VERBOSE’
>   DP_VERBOSE(p_hwfn, ECORE_MSG_SP,
>   ^~~~~~~~~~
> .../dpdk/drivers/net/qede/base/ecore_hw.c:996:76: note: format string is
> defined here
>       "DMAE sanity [%s]: src_addr={phys 0x%lx, virt %p}, dst_addr={phys
> 0x%lx, virt %p}, size 0x%x\n",
>                                                                           ~~^
>                                                                           %llx In file included from
> .../dpdk/drivers/net/qede/base/ecore.h:50:0,
>                  from .../dpdk/drivers/net/qede/base/ecore_hw.c:12:
> .../dpdk/drivers/net/qede/base/../qede_logs.h:25:4: error: format ‘%lx’
> expects argument of type ‘long unsigned int’, but argument 7 has type ‘long
> long unsigned int’ [-Werror=format=]
>     "[QEDE PMD: (%s)]%s:" fmt, \
>     ^
> .../dpdk/drivers/net/qede/base/ecore_hw.c:1018:4: note: in expansion of
> macro ‘DP_NOTICE’
>     DP_NOTICE(p_hwfn, false,
>     ^~~~~~~~~
> .../dpdk/drivers/net/qede/base/ecore_hw.c:1019:41: note: format string is
> defined here
>        "DMAE sanity [%s]: addr={phys 0x%lx, virt %p}, read_val 0x%08x,
> expected_val 0x%08x\n",
>                                        ~~^
>                                        %llx In file included from
> .../dpdk/drivers/net/qede/base/ecore.h:50:0,
>                  from .../dpdk/drivers/net/qede/base/ecore_hw.c:12:
> .../dpdk/drivers/net/qede/base/../qede_logs.h:31:4: error: format ‘%lx’
> expects argument of type ‘long unsigned int’, but argument 7 has type ‘long
> long unsigned int’ [-Werror=format=]
>     "[QEDE PMD: (%s)]%s:" fmt, \
>     ^
> .../dpdk/drivers/net/qede/base/ecore_hw.c:1018:4: note: in expansion of
> macro ‘DP_NOTICE’
>     DP_NOTICE(p_hwfn, false,
>     ^~~~~~~~~
> .../dpdk/drivers/net/qede/base/ecore_hw.c:1019:41: note: format string is
> defined here
>        "DMAE sanity [%s]: addr={phys 0x%lx, virt %p}, read_val 0x%08x,
> expected_val 0x%08x\n",
>                                        ~~^
>                                        %llx
> cc1: all warnings being treated as errors


  reply	other threads:[~2018-04-09  4:49 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-01  5:46 Rasesh Mody
2018-04-01  5:46 ` [dpdk-dev] [PATCH 01/14] net/qede/base: use path ID for HW init Rasesh Mody
2018-04-01  5:46 ` [dpdk-dev] [PATCH 02/14] net/qede/base: protect DMAE transactions Rasesh Mody
2018-04-01  5:46 ` [dpdk-dev] [PATCH 03/14] net/qede/base: add DMAE sanity check Rasesh Mody
2018-04-01  5:46 ` [dpdk-dev] [PATCH 04/14] net/qede/base: upgrade FW to 8.33.12.0 Rasesh Mody
2018-04-01  5:46 ` [dpdk-dev] [PATCH 05/14] net/qede/base: symantic changes Rasesh Mody
2018-04-01  5:46 ` [dpdk-dev] [PATCH 06/14] net/qede/base: add new chain API Rasesh Mody
2018-04-01  5:46 ` [dpdk-dev] [PATCH 07/14] net/qede/base: allow changing VF MAC address Rasesh Mody
2018-04-01  5:46 ` [dpdk-dev] [PATCH 08/14] net/qede/base: add MFW support for driver load timeout Rasesh Mody
2018-04-01  5:46 ` [dpdk-dev] [PATCH 09/14] net/qede/base: refine error handling Rasesh Mody
2018-04-01  5:47 ` [dpdk-dev] [PATCH 10/14] net/qede/base: add stats counter for link state Rasesh Mody
2018-04-01  5:47 ` [dpdk-dev] [PATCH 11/14] net/qede/base: add APIs for xcvr Rasesh Mody
2018-04-01  5:47 ` [dpdk-dev] [PATCH 12/14] net/qede/base: fix to support OVLAN mode Rasesh Mody
2018-04-01  5:47 ` [dpdk-dev] [PATCH 13/14] net/qede/base: add packet pacing support Rasesh Mody
2018-04-01  5:47 ` [dpdk-dev] [PATCH 14/14] net/qede: update PMD version to 2.8.0.1 Rasesh Mody
2018-04-06  9:03 ` [dpdk-dev] [PATCH 00/14] net/qede/base: " Ferruh Yigit
2018-04-09  4:49   ` Mody, Rasesh [this message]
2018-04-09  4:47 ` [dpdk-dev] [PATCH v2 " Rasesh Mody
2018-04-09 17:10   ` Ferruh Yigit
2018-04-09  4:47 ` [dpdk-dev] [PATCH v2 01/14] net/qede/base: use path ID for HW init Rasesh Mody
2018-04-09  4:47 ` [dpdk-dev] [PATCH v2 02/14] net/qede/base: protect DMAE transactions Rasesh Mody
2018-04-09  4:47 ` [dpdk-dev] [PATCH v2 03/14] net/qede/base: add DMAE sanity check Rasesh Mody
2018-04-09  4:48 ` [dpdk-dev] [PATCH v2 04/14] net/qede/base: upgrade FW to 8.33.12.0 Rasesh Mody
2018-04-09  4:48 ` [dpdk-dev] [PATCH v2 05/14] net/qede/base: symantic changes Rasesh Mody
2018-04-09  4:48 ` [dpdk-dev] [PATCH v2 06/14] net/qede/base: add new chain API Rasesh Mody
2018-04-09  4:48 ` [dpdk-dev] [PATCH v2 07/14] net/qede/base: allow changing VF MAC address Rasesh Mody
2018-04-09  4:48 ` [dpdk-dev] [PATCH v2 08/14] net/qede/base: add MFW support for driver load timeout Rasesh Mody
2018-04-09  4:48 ` [dpdk-dev] [PATCH v2 09/14] net/qede/base: refine error handling Rasesh Mody
2018-04-09  4:48 ` [dpdk-dev] [PATCH v2 10/14] net/qede/base: add stats counter for link state Rasesh Mody
2018-04-09  4:48 ` [dpdk-dev] [PATCH v2 11/14] net/qede/base: add APIs for xcvr Rasesh Mody
2018-04-09  4:48 ` [dpdk-dev] [PATCH v2 12/14] net/qede/base: fix to support OVLAN mode Rasesh Mody
2018-04-09  4:48 ` [dpdk-dev] [PATCH v2 13/14] net/qede/base: add packet pacing support Rasesh Mody
2018-04-09  4:48 ` [dpdk-dev] [PATCH v2 14/14] net/qede: update PMD version to 2.8.0.1 Rasesh Mody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR0701MB36759881023470CA6BFF8F159FBF0@MWHPR0701MB3675.namprd07.prod.outlook.com \
    --to=rasesh.mody@cavium.com \
    --cc=Dept-EngDPDKDev@cavium.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).