From: Vladyslav Buslov <Vladyslav.Buslov@harmonicinc.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] kni: add module parameter 'bind_to_core'
Date: Sun, 28 Aug 2016 11:20:27 +0000 [thread overview]
Message-ID: <MWHPR11MB1360F08559863251C729A61E9DEE0@MWHPR11MB1360.namprd11.prod.outlook.com> (raw)
In-Reply-To: <57BF04D6.9040108@intel.com>
Hi Ferruh,
I agree that your solution is more flexible.
I'll work on moving single thread creation to kni_ioctl_create next week and get back to you with results.
Regards,
Vladyslav
-----Original Message-----
From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
Sent: Thursday, August 25, 2016 5:47 PM
To: Vladyslav Buslov
Cc: dev@dpdk.org
Subject: Re: [PATCH] kni: add module parameter 'bind_to_core'
Hi Vladyslav,
On 8/16/2016 7:24 PM, Vladyslav Buslov wrote:
> Allow binding KNI thread to specific core in single threaded mode.
I think this is good idea.
But I am not sure about making this a module parameter, setting core can be more dynamic.
There is already a kni->core_id field, which is only used for multiple_kthread mode.
What do you think moving single thread creation into kni_ioctl_create() and use first kni->core_id to bind the thread? If there is no
kni->core_id set, it will behave as it is now.
>
> Signed-off-by: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
> ---
<...>
next prev parent reply other threads:[~2016-08-28 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 18:24 Vladyslav Buslov
2016-08-25 14:46 ` Ferruh Yigit
2016-08-28 11:20 ` Vladyslav Buslov [this message]
2016-09-02 15:13 ` [dpdk-dev] [PATCH] kni: add support for core_id param in single threaded mode Vladyslav Buslov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB1360F08559863251C729A61E9DEE0@MWHPR11MB1360.namprd11.prod.outlook.com \
--to=vladyslav.buslov@harmonicinc.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).