From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: "Li, Miao" <miao.li@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v3 5/5] examples/l3fwd-power: support virtio/vhost
Date: Wed, 29 Sep 2021 06:53:13 +0000 [thread overview]
Message-ID: <MWHPR11MB1775707C8F59475C4258A3499CA99@MWHPR11MB1775.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210924102309.231304-6-miao.li@intel.com>
> -----Original Message-----
> From: Li, Miao <miao.li@intel.com>
> Sent: Friday, September 24, 2021 6:23 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com; Li, Miao
> <miao.li@intel.com>
> Subject: [PATCH v3 5/5] examples/l3fwd-power: support virtio/vhost
>
> In l3fwd-power, there is default port configuration which requires
> RSS and IPV4/UDP/TCP checksum. Once device does not support these,
> the l3fwd-power will exit and report an error.
> This patch updates the port configuration based on device capabilities
> after getting the device information to support devices like virtio
> and vhost.
>
> Signed-off-by: Miao Li <miao.li@intel.com>
> ---
> examples/l3fwd-power/main.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index aa7b8db44a..14ae87a9d5 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -2637,6 +2637,11 @@ main(int argc, char **argv)
> local_port_conf.rx_adv_conf.rss_conf.rss_hf);
> }
>
> + if (local_port_conf.rx_adv_conf.rss_conf.rss_hf == 0)
> + local_port_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
> + local_port_conf.rxmode.offloads &= dev_info.rx_offload_capa;
> + port_conf.rxmode.offloads = local_port_conf.rxmode.offloads;
> +
> ret = rte_eth_dev_configure(portid, nb_rx_queue,
> (uint16_t)n_tx_queue, &local_port_conf);
> if (ret < 0)
> --
> 2.25.1
Just as David suggested, I think we'd better consider RFC 1812, if HW does not
support RX IP CKSUM offload, check IP CKSUM in is_valid_ipv4_pkt.
Thanks,
Chenbo
next prev parent reply other threads:[~2021-09-29 6:53 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 13:05 [dpdk-dev] [PATCH 0/5] CPU Enabling: Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-09-10 13:05 ` [dpdk-dev] [PATCH 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-09-15 8:45 ` Xia, Chenbo
2021-09-17 6:40 ` Li, Miao
2021-09-10 13:05 ` [dpdk-dev] [PATCH 2/5] lib/vhost: " Miao Li
2021-09-15 8:51 ` Xia, Chenbo
2021-09-17 6:51 ` Li, Miao
2021-09-10 13:05 ` [dpdk-dev] [PATCH 3/5] net/vhost: " Miao Li
2021-09-10 13:05 ` [dpdk-dev] [PATCH 4/5] lib/power: modify return of queue_stopped Miao Li
2021-09-10 13:15 ` Burakov, Anatoly
2021-09-10 13:05 ` [dpdk-dev] [PATCH 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-09-10 7:24 ` Maxime Coquelin
2021-09-10 8:33 ` Li, Miao
2021-09-10 8:50 ` David Marchand
2021-09-13 1:41 ` Li, Miao
2021-09-18 13:22 ` [dpdk-dev] [PATCH 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-09-18 13:22 ` [dpdk-dev] [PATCH 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-09-18 13:22 ` [dpdk-dev] [PATCH 2/5] vhost: " Miao Li
2021-09-18 13:22 ` [dpdk-dev] [PATCH 3/5] net/vhost: " Miao Li
2021-09-18 13:22 ` [dpdk-dev] [PATCH 4/5] power: modify return of queue_stopped Miao Li
2021-09-18 13:22 ` [dpdk-dev] [PATCH 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-09-29 2:34 ` Xia, Chenbo
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 2/5] vhost: " Miao Li
2021-09-29 3:01 ` Xia, Chenbo
2021-10-11 5:16 ` Li, Miao
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 3/5] net/vhost: " Miao Li
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 4/5] power: modify return of queue_stopped Miao Li
2021-09-29 3:03 ` Xia, Chenbo
2021-10-11 5:18 ` Li, Miao
2021-09-24 10:23 ` [dpdk-dev] [PATCH v3 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-09-29 6:53 ` Xia, Chenbo [this message]
2021-10-11 5:22 ` Li, Miao
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 2/5] vhost: " Miao Li
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 3/5] net/vhost: " Miao Li
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 4/5] power: modify return of queue_stopped Miao Li
2021-10-12 14:22 ` [dpdk-dev] [PATCH v4 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 2/5] vhost: " Miao Li
2021-10-15 7:38 ` Xia, Chenbo
2021-10-15 8:47 ` Li, Miao
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 3/5] net/vhost: " Miao Li
2021-10-15 7:39 ` Xia, Chenbo
2021-10-15 8:49 ` Li, Miao
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 4/5] power: modify return of queue_stopped Miao Li
2021-10-15 7:47 ` Xia, Chenbo
2021-10-15 8:50 ` Li, Miao
2021-10-15 15:12 ` [dpdk-dev] [PATCH v5 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-15 8:13 ` Xia, Chenbo
2021-10-15 8:51 ` Li, Miao
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-15 12:57 ` Maxime Coquelin
2021-10-18 1:54 ` Li, Miao
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 2/5] vhost: " Miao Li
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 3/5] net/vhost: " Miao Li
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 4/5] power: modify return of queue_stopped Miao Li
2021-10-15 17:09 ` [dpdk-dev] [PATCH v6 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-21 16:50 ` Ferruh Yigit
2021-10-22 8:22 ` Li, Miao
2021-10-21 16:59 ` Ferruh Yigit
2021-10-22 8:28 ` Li, Miao
2021-10-22 8:51 ` Li, Miao
2021-10-22 8:59 ` Ferruh Yigit
2021-10-22 9:02 ` Xia, Chenbo
2021-10-22 13:41 ` David Hunt
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 2/5] vhost: " Miao Li
2021-10-19 4:38 ` Xia, Chenbo
2021-10-22 12:34 ` David Hunt
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 3/5] net/vhost: " Miao Li
2021-10-19 4:39 ` Xia, Chenbo
2021-10-22 12:01 ` David Hunt
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped Miao Li
2021-10-21 16:48 ` Ferruh Yigit
2021-10-22 8:20 ` Li, Miao
2021-10-22 9:01 ` Ferruh Yigit
2021-10-22 9:05 ` Li, Miao
2021-10-22 11:54 ` David Hunt
2021-10-18 14:16 ` [dpdk-dev] [PATCH v7 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-19 4:39 ` Xia, Chenbo
2021-10-22 11:50 ` David Hunt
2021-10-21 16:58 ` Ferruh Yigit
2021-10-21 12:35 ` [dpdk-dev] [PATCH v7 0/5] Implement rte_power_monitor API in virtio/vhost PMD Maxime Coquelin
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 0/5] Support power monitor " Miao Li
2021-10-25 7:06 ` Xia, Chenbo
2021-10-28 8:03 ` Maxime Coquelin
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 1/5] net/virtio: support power monitor Miao Li
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 2/5] vhost: add power monitor support API Miao Li
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 3/5] net/vhost: support power monitor Miao Li
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 4/5] power: modify return of queue_stopped Miao Li
2021-10-25 14:47 ` [dpdk-dev] [PATCH v8 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-29 19:09 ` Ferruh Yigit
2021-10-29 10:34 ` [dpdk-dev] [PATCH v8 0/5] Support power monitor in virtio/vhost PMD Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB1775707C8F59475C4258A3499CA99@MWHPR11MB1775.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=miao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).